From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DD8D7A0AC5 for ; Thu, 2 May 2019 15:48:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B2C55F2C; Thu, 2 May 2019 15:48:33 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7915E5F20 for ; Thu, 2 May 2019 15:48:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 06:48:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="296381131" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 02 May 2019 06:48:30 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 2 May 2019 06:48:29 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.68]) by FMSMSX151.amr.corp.intel.com ([169.254.7.99]) with mapi id 14.03.0415.000; Thu, 2 May 2019 06:48:29 -0700 From: "Carrillo, Erik G" To: "Burakov, Anatoly" , "rsanford@akamai.com" , "thomas@monjalon.net" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] timer: fix resource leak in finalize Thread-Index: AQHVAFBf1BadAVMoPU6nNjuouLWwAaZYBJ4A//+81dCAAII0AP//lghA Date: Thu, 2 May 2019 13:48:29 +0000 Message-ID: References: <1556737217-24338-1-git-send-email-erik.g.carrillo@intel.com> <7b2dfc9d-4638-f8ab-1f4b-ad268635b386@intel.com> In-Reply-To: <7b2dfc9d-4638-f8ab-1f4b-ad268635b386@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDBkNTg5NDgtZmE1YS00ZWMzLWFmMDQtMDE2NTZmNDBkNmQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieWVOUUNGbjg0YWFPR2IxVGxEV2ptWkJRXC9IZHVWZW14b2Y5ejQ4cUpQTVlCT3NcL0R1MjRMSnI1ekg5WnBFdWJkIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502134829.6cTmZKq7kwwAC6DUcJ3ULydT8yWsI2LObmTqPQMT21s@z> DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQnVyYWtvdiwgQW5hdG9s eQ0KPiBTZW50OiBUaHVyc2RheSwgTWF5IDIsIDIwMTkgODowNCBBTQ0KPiBUbzogQ2FycmlsbG8s IEVyaWsgRyA8ZXJpay5nLmNhcnJpbGxvQGludGVsLmNvbT47IHJzYW5mb3JkQGFrYW1haS5jb207 DQo+IHRob21hc0Btb25qYWxvbi5uZXQNCj4gQ2M6IGRldkBkcGRrLm9yZw0KPiBTdWJqZWN0OiBS ZTogW2RwZGstZGV2XSBbUEFUQ0hdIHRpbWVyOiBmaXggcmVzb3VyY2UgbGVhayBpbiBmaW5hbGl6 ZQ0KPiANCj4gT24gMDItTWF5LTE5IDE6MTkgUE0sIENhcnJpbGxvLCBFcmlrIEcgd3JvdGU6DQo+ ID4NCj4gPg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBCdXJh a292LCBBbmF0b2x5DQo+ID4+IFNlbnQ6IFRodXJzZGF5LCBNYXkgMiwgMjAxOSA0OjE4IEFNDQo+ ID4+IFRvOiBDYXJyaWxsbywgRXJpayBHIDxlcmlrLmcuY2FycmlsbG9AaW50ZWwuY29tPjsNCj4g Pj4gcnNhbmZvcmRAYWthbWFpLmNvbTsgdGhvbWFzQG1vbmphbG9uLm5ldA0KPiA+PiBDYzogZGV2 QGRwZGsub3JnDQo+ID4+IFN1YmplY3Q6IFJlOiBbZHBkay1kZXZdIFtQQVRDSF0gdGltZXI6IGZp eCByZXNvdXJjZSBsZWFrIGluIGZpbmFsaXplDQo+ID4+DQo+ID4+IE9uIDAxLU1heS0xOSA4OjAw IFBNLCBFcmlrIEdhYnJpZWwgQ2FycmlsbG8gd3JvdGU6DQo+ID4+PiBUaGUgZmluYWxpemUgZnVu Y3Rpb24gc2hvdWxkIGZyZWUgdGhlIG1lbXpvbmUgY3JlYXRlZCBpbiB0aGUgaW5pdA0KPiA+Pj4g ZnVuY3Rpb24sIHJhdGhlciB0aGFuIGZyZWVpbmcgdGhlIGFsbG9jYXRpb24gdGhlIG1lbXpvbmUg cmVmZXJlbmNlcywNCj4gPj4+IG90aGVyd2lzZSBhIG1lbXpvbmUgZGVzY3JpcHRvciBjYW4gYmUg bGVha2VkLg0KPiA+Pj4NCj4gPj4+IEZpeGVzOiBjMDc0OWY3MDk2YzcgKCJ0aW1lcjogYWxsb3cg bWFuYWdlbWVudCBpbiBzaGFyZWQgbWVtb3J5IikNCj4gPj4+DQo+ID4+PiBTaWduZWQtb2ZmLWJ5 OiBFcmlrIEdhYnJpZWwgQ2FycmlsbG8gPGVyaWsuZy5jYXJyaWxsb0BpbnRlbC5jb20+DQo+ID4+ PiAtLS0NCj4gPj4+ICAgIGxpYi9saWJydGVfdGltZXIvcnRlX3RpbWVyLmMgfCAxMiArKysrKysr KysrLS0NCj4gPj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQ0KPiA+Pj4NCj4gPj4+IGRpZmYgLS1naXQgYS9saWIvbGlicnRlX3RpbWVyL3J0ZV90 aW1lci5jDQo+ID4+PiBiL2xpYi9saWJydGVfdGltZXIvcnRlX3RpbWVyLmMgaW5kZXggZWI0NjAw OS4uZmI3YTg3ZSAxMDA2NDQNCj4gPj4+IC0tLSBhL2xpYi9saWJydGVfdGltZXIvcnRlX3RpbWVy LmMNCj4gPj4+ICsrKyBiL2xpYi9saWJydGVfdGltZXIvcnRlX3RpbWVyLmMNCj4gPj4+IEBAIC02 MCw2ICs2MCw3IEBAIHN0cnVjdCBydGVfdGltZXJfZGF0YSB7DQo+ID4+PiAgICB9Ow0KPiA+Pj4N Cj4gPj4+ICAgICNkZWZpbmUgUlRFX01BWF9EQVRBX0VMUyA2NA0KPiA+Pj4gK3N0YXRpYyBjb25z dCBzdHJ1Y3QgcnRlX21lbXpvbmUgKnJ0ZV90aW1lcl9kYXRhX216Ow0KPiA+Pj4gICAgc3RhdGlj IHN0cnVjdCBydGVfdGltZXJfZGF0YSAqcnRlX3RpbWVyX2RhdGFfYXJyOw0KPiA+Pj4gICAgc3Rh dGljIGNvbnN0IHVpbnQzMl90IGRlZmF1bHRfZGF0YV9pZDsNCj4gPj4+ICAgIHN0YXRpYyB1aW50 MzJfdCBydGVfdGltZXJfc3Vic3lzdGVtX2luaXRpYWxpemVkOyBAQCAtMTY0LDYgKzE2NSw3DQo+ ID4+PiBAQA0KPiA+Pj4gcnRlX3RpbWVyX3N1YnN5c3RlbV9pbml0X3YxOTA1KHZvaWQpDQo+ID4+ PiAgICAJCWlmIChteiA9PSBOVUxMKQ0KPiA+Pj4gICAgCQkJcmV0dXJuIC1FRVhJU1Q7DQo+ID4+ Pg0KPiA+Pj4gKwkJcnRlX3RpbWVyX2RhdGFfbXogPSBtejsNCj4gPj4+ICAgIAkJcnRlX3RpbWVy X2RhdGFfYXJyID0gbXotPmFkZHI7DQo+ID4+Pg0KPiA+Pj4gICAgCQlydGVfdGltZXJfZGF0YV9h cnJbZGVmYXVsdF9kYXRhX2lkXS5pbnRlcm5hbF9mbGFncyB8PSBAQCAtDQo+ID4+IDE4MCw2DQo+ ID4+PiArMTgyLDcgQEAgcnRlX3RpbWVyX3N1YnN5c3RlbV9pbml0X3YxOTA1KHZvaWQpDQo+ID4+ PiAgICAJaWYgKG16ID09IE5VTEwpDQo+ID4+PiAgICAJCXJldHVybiAtRU5PTUVNOw0KPiA+Pj4N Cj4gPj4+ICsJcnRlX3RpbWVyX2RhdGFfbXogPSBtejsNCj4gPj4+ICAgIAlydGVfdGltZXJfZGF0 YV9hcnIgPSBtei0+YWRkcjsNCj4gPj4+DQo+ID4+PiAgICAJZm9yIChpID0gMDsgaSA8IFJURV9N QVhfREFUQV9FTFM7IGkrKykgeyBAQCAtMjA1LDggKzIwOCwxMyBAQA0KPiA+Pj4gQklORF9ERUZB VUxUX1NZTUJPTChydGVfdGltZXJfc3Vic3lzdGVtX2luaXQsIF92MTkwNSwgMTkuMDUpOw0KPiA+ Pj4gICAgdm9pZCBfX3J0ZV9leHBlcmltZW50YWwNCj4gPj4+ICAgIHJ0ZV90aW1lcl9zdWJzeXN0 ZW1fZmluYWxpemUodm9pZCkNCj4gPj4+ICAgIHsNCj4gPj4+IC0JaWYgKHJ0ZV90aW1lcl9kYXRh X2FycikNCj4gPj4+IC0JCXJ0ZV9mcmVlKHJ0ZV90aW1lcl9kYXRhX2Fycik7DQo+ID4+PiArCWlm IChydGVfZWFsX3Byb2Nlc3NfdHlwZSgpICE9IFJURV9QUk9DX1BSSU1BUlkpDQo+ID4+PiArCQly ZXR1cm47DQo+ID4+PiArDQo+ID4+PiArCWlmICghcnRlX3RpbWVyX3N1YnN5c3RlbV9pbml0aWFs aXplZCkNCj4gPj4+ICsJCXJldHVybjsNCj4gPj4+ICsNCj4gPj4+ICsJcnRlX21lbXpvbmVfZnJl ZShydGVfdGltZXJfZGF0YV9teik7DQo+ID4+DQo+ID4+IFRoZSBwYXRjaCBpcyBhIGNvcnJlY3Qg Zml4LCBidXQgdGhlIHdob2xlIGlkZWEgb2YgdGhpcyBsb29rcyBkYW5nZXJvdXMgdG8NCj4gbWUu DQo+ID4+DQo+ID4+IElmIHdlIGV4aXQgdGhlIHByaW1hcnkgd2hpbGUgc2Vjb25kYXJpZXMgYXJl IHN0aWxsIHJ1bm5pbmcsIHdvdWxkbid0DQo+ID4+IGl0IGJhc2ljYWxseSBwdWxsIG91dCB0aW1l ciBkYXRhIGZyb20gdW5kZXIgc2Vjb25kYXJpZXMnIGZlZXQ/DQo+ID4+DQo+ID4NCj4gPiBBaCB5 ZXMgLSB0aGF04oCZcyByaWdodC4gIFBlcmhhcHMgaXQgd291bGQgYmUgYmV0dGVyIHRvIG1haW50 YWluIGEgcmVmZXJlbmNlDQo+IGNvdW50IG9mIHNvbWUgc29ydCBzdWNoIHRoYXQgdGhlIGxhc3Qg cHJvY2VzcyB0byBleGl0IGNvdWxkIGNhdXNlIHRoZQ0KPiBtZW16b25lX2ZyZWUuDQo+ID4NCj4g DQo+IEl0IGZlZWxzIGxpa2UgYSBoYWNrLCB0byBiZSBob25lc3QuIEEgcHJvY2VzcyBjYW4gY3Jh c2ggb3IgZXhpdCB3aXRob3V0IGNhbGxpbmcNCj4gcnRlX2VhbF9jbGVhbnVwKCksIHdoaWNoIHdp bGwgbGVhZCB0byBhIG1lbW9yeSBsZWFrIGR1ZSB0byByZWZjb3VudCBiZWluZw0KPiBzdHVjayBh dCBhIHZhbHVlIHRoYXQncyBub3QgcmVwcmVzZW50aW5nIHJlYWxpdHkuIEl0IHdpbGwgYmUgc2Fm LWVyIHRoYW4gY3VycmVudA0KPiBhcHByb2FjaCwgYnV0IHN0aWxsIG5vdCBpZGVhbC4NCj4gDQo+ IEhvd2V2ZXIsIGkgZ3Vlc3MgaXQncyBhIGdvb2QgY29tcHJvbWlzZSwgaWYgaSB3ZXJlIHRvIGNo b29zZSBiZXR3ZWVuIGENCj4gbWVtb3J5IGxlYWsgYW5kIGEgc2VnZmF1bHQgOkQgSSB3b25kZXIg aWYgdGhlcmUgaXMgYSBiZXR0ZXIgYXBwcm9hY2guDQoNCk9rLCBJIHdpbGwgdGFrZSBhIGxvb2sg YXQgdGhhdCBhcHByb2FjaCB0aGVuIGFzIGEgZmlyc3Qgc3RlcCwgc2luY2UgYSBwcm9jZXNzIGNh biBhbHJlYWR5IGNyYXNoIGJlZm9yZSBjYWxsaW5nIHJ0ZV9lYWxfY2xlYW51cCgpLCB3aGljaCB3 b3VsZCByZXN1bHQgaW4gbGVha3MgYW55d2F5Lg0KDQpUaGFua3MsDQpFcmlrDQoNCj4gDQo+ID4g VGhhbmtzLA0KPiA+IEVyaWsNCj4gPg0KPiA+Pj4NCj4gPj4+ICAgIAlydGVfdGltZXJfc3Vic3lz dGVtX2luaXRpYWxpemVkID0gMDsNCj4gPj4+ICAgIH0NCj4gPj4+DQo+ID4+DQo+ID4+DQo+ID4+ IC0tDQo+ID4+IFRoYW5rcywNCj4gPj4gQW5hdG9seQ0KPiANCj4gDQo+IC0tDQo+IFRoYW5rcywN Cj4gQW5hdG9seQ0K