From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 71C6C5589 for ; Fri, 3 May 2019 01:15:20 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id 85so1754571pgc.3 for ; Thu, 02 May 2019 16:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=0ytswpM4JF6sSNe4iGuhjxQ5F2amNe+4pC8iF29zRyI=; b=y2ZwaPQ58nWrVlZyHCXyC/N7fkn/6n4lwNeBEuDKvmn4GQcmRbk2o+CcrU+jtry6Nc go6W0atUjjCs5E1nANz8QxkMglkbnyZ6+Er8Fx4TD2nsHBWpmZRU1wbnM8EoLUpOZC1S IEPV+RsDErnBCfSsEV18KDXHXmaodluBrN2uvnwf8OG0+5czOIjUKsZWnixpG4XkWp3N zn+XXtiKipJHgUiTwAE4Uwz72zedy/hF1GD8x1IYrBcnEnITrL4l5jAl5lcDEhRQ/aGV f/wiOwZrsVV6hLHOY4gbJyosscyyJ4BfzHW4dZvB4J2o69A0JMZs3nJtPoNdebLWx2/t UNEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ytswpM4JF6sSNe4iGuhjxQ5F2amNe+4pC8iF29zRyI=; b=oLU6tOlDWMCWQskZUzkqSnY7ztdQ3mxJKKkuXjcs2+0OTptjDmsnzDk7MLD+s3hdVs D7cy2S7n7WaOEjjnEA2b8CGVpwqjWSk1M1PaUbOYYipzgRscyYggE6syBx3fhSanu/uQ DXLObcWoqkGMWVtaemr/19g/xivNspG2lKlecoQ6vfvWaTxJxqDfkp6DpGwZQblXxfZv b+z0Tv5SJQ/TQqTZymy4yNxfCIYeyj7jfy8kw92mFI/9JORSoJgFvPz7tBenPoxERiCz P8z4TQHPSpmoNRnOdUxjZjErRZDSUmXqh+TMVPLvz2A0FXtt3GkqPxAp3Dddegecod+W 4XjQ== X-Gm-Message-State: APjAAAXrHOEkRaSOt9w/EcEOyUaISotVFt4awZ0TTLv56vgLFDiqsaKH WHN6x+Mtcd5VP8saj1hReXedtUPBRCQ= X-Google-Smtp-Source: APXvYqx24dB09IaqJct/Gqq0+dzMdEls1gFTbrt70tFVFcKzyx4S3qIse4WU+qF7bj6FLVdpp19YSQ== X-Received: by 2002:a63:374b:: with SMTP id g11mr6761851pgn.421.1556838919199; Thu, 02 May 2019 16:15:19 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d68sm328099pfc.17.2019.05.02.16.15.18 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 16:15:19 -0700 (PDT) Date: Thu, 2 May 2019 16:15:10 -0700 From: Stephen Hemminger To: dev@dpdk.org Message-ID: <20190502141553.662a1ef1@hermes.lan> In-Reply-To: <20190410171603.8979-1-stephen@networkplumber.org> References: <20190408182510.16078-1-stephen@networkplumber.org> <20190410171603.8979-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 0/5] make lcore_config internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2019 23:15:20 -0000 On Wed, 10 Apr 2019 10:15:58 -0700 Stephen Hemminger wrote: > This set of patches makes the lcore_config structure less visible > as part of the ABI. This version does not break the ABI (yet) > follow on patch moves lcore_config into eal_private.h > > The changes in v2 is to: > - new patch to use unsigned int in lcore.h first > - incorporate feedback from David > - don't include last patch to make it private > (to avoid accidental early merge) > > Stephen Hemminger (5): > eal: use unsigned int in rte_lcore.h functions > eal: add accessor functions for lcore_config > bus: use lcore accessor functions > examples/bond: use lcore accessor > app/test: use lcore accessor functions > > app/test/test_cryptodev.c | 2 +- > app/test/test_hash_readwrite_lf.c | 14 +++--- > app/test/test_ring_perf.c | 22 +++++---- > app/test/test_stack_perf.c | 20 ++++---- > doc/guides/rel_notes/release_19_05.rst | 6 +++ > drivers/bus/dpaa/dpaa_bus.c | 6 ++- > drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +- > examples/bond/main.c | 5 +- > lib/librte_eal/common/eal_common_lcore.c | 39 +++++++++++++++ > lib/librte_eal/common/include/rte_lcore.h | 58 ++++++++++++++++------- > lib/librte_eal/rte_eal_version.map | 11 +++++ > 11 files changed, 136 insertions(+), 51 deletions(-) > Why is this patchset still stuck in the queue? The parts with deprecation and accessor functions should really go in 19.05 but since it has sat around for so long, it is probably too late. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1AE4EA0AC5 for ; Fri, 3 May 2019 01:15:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB1665F14; Fri, 3 May 2019 01:15:21 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 71C6C5589 for ; Fri, 3 May 2019 01:15:20 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id 85so1754571pgc.3 for ; Thu, 02 May 2019 16:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=0ytswpM4JF6sSNe4iGuhjxQ5F2amNe+4pC8iF29zRyI=; b=y2ZwaPQ58nWrVlZyHCXyC/N7fkn/6n4lwNeBEuDKvmn4GQcmRbk2o+CcrU+jtry6Nc go6W0atUjjCs5E1nANz8QxkMglkbnyZ6+Er8Fx4TD2nsHBWpmZRU1wbnM8EoLUpOZC1S IEPV+RsDErnBCfSsEV18KDXHXmaodluBrN2uvnwf8OG0+5czOIjUKsZWnixpG4XkWp3N zn+XXtiKipJHgUiTwAE4Uwz72zedy/hF1GD8x1IYrBcnEnITrL4l5jAl5lcDEhRQ/aGV f/wiOwZrsVV6hLHOY4gbJyosscyyJ4BfzHW4dZvB4J2o69A0JMZs3nJtPoNdebLWx2/t UNEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ytswpM4JF6sSNe4iGuhjxQ5F2amNe+4pC8iF29zRyI=; b=oLU6tOlDWMCWQskZUzkqSnY7ztdQ3mxJKKkuXjcs2+0OTptjDmsnzDk7MLD+s3hdVs D7cy2S7n7WaOEjjnEA2b8CGVpwqjWSk1M1PaUbOYYipzgRscyYggE6syBx3fhSanu/uQ DXLObcWoqkGMWVtaemr/19g/xivNspG2lKlecoQ6vfvWaTxJxqDfkp6DpGwZQblXxfZv b+z0Tv5SJQ/TQqTZymy4yNxfCIYeyj7jfy8kw92mFI/9JORSoJgFvPz7tBenPoxERiCz P8z4TQHPSpmoNRnOdUxjZjErRZDSUmXqh+TMVPLvz2A0FXtt3GkqPxAp3Dddegecod+W 4XjQ== X-Gm-Message-State: APjAAAXrHOEkRaSOt9w/EcEOyUaISotVFt4awZ0TTLv56vgLFDiqsaKH WHN6x+Mtcd5VP8saj1hReXedtUPBRCQ= X-Google-Smtp-Source: APXvYqx24dB09IaqJct/Gqq0+dzMdEls1gFTbrt70tFVFcKzyx4S3qIse4WU+qF7bj6FLVdpp19YSQ== X-Received: by 2002:a63:374b:: with SMTP id g11mr6761851pgn.421.1556838919199; Thu, 02 May 2019 16:15:19 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d68sm328099pfc.17.2019.05.02.16.15.18 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 16:15:19 -0700 (PDT) Date: Thu, 2 May 2019 16:15:10 -0700 From: Stephen Hemminger To: dev@dpdk.org Message-ID: <20190502141553.662a1ef1@hermes.lan> In-Reply-To: <20190410171603.8979-1-stephen@networkplumber.org> References: <20190408182510.16078-1-stephen@networkplumber.org> <20190410171603.8979-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 0/5] make lcore_config internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502231510.vDDn8C9JfpRsqfqShG6H2J1oj2yxWxRQi0FxqBYMDAI@z> On Wed, 10 Apr 2019 10:15:58 -0700 Stephen Hemminger wrote: > This set of patches makes the lcore_config structure less visible > as part of the ABI. This version does not break the ABI (yet) > follow on patch moves lcore_config into eal_private.h > > The changes in v2 is to: > - new patch to use unsigned int in lcore.h first > - incorporate feedback from David > - don't include last patch to make it private > (to avoid accidental early merge) > > Stephen Hemminger (5): > eal: use unsigned int in rte_lcore.h functions > eal: add accessor functions for lcore_config > bus: use lcore accessor functions > examples/bond: use lcore accessor > app/test: use lcore accessor functions > > app/test/test_cryptodev.c | 2 +- > app/test/test_hash_readwrite_lf.c | 14 +++--- > app/test/test_ring_perf.c | 22 +++++---- > app/test/test_stack_perf.c | 20 ++++---- > doc/guides/rel_notes/release_19_05.rst | 6 +++ > drivers/bus/dpaa/dpaa_bus.c | 6 ++- > drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +- > examples/bond/main.c | 5 +- > lib/librte_eal/common/eal_common_lcore.c | 39 +++++++++++++++ > lib/librte_eal/common/include/rte_lcore.h | 58 ++++++++++++++++------- > lib/librte_eal/rte_eal_version.map | 11 +++++ > 11 files changed, 136 insertions(+), 51 deletions(-) > Why is this patchset still stuck in the queue? The parts with deprecation and accessor functions should really go in 19.05 but since it has sat around for so long, it is probably too late.