From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id ACC04A0AC5 for ; Thu, 2 May 2019 20:13:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8374E1B1CE; Thu, 2 May 2019 20:13:17 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70041.outbound.protection.outlook.com [40.107.7.41]) by dpdk.org (Postfix) with ESMTP id 1E0C61B1A0 for ; Thu, 2 May 2019 20:13:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LU3gd8kEvKpMZZm0H7PuKdgCD1P5+dNAq2SdSVd2M60=; b=pR+u8B3XcxwQd1KAgfAEEDOVjaSjDVWI8qg2uhP/KF/ZdSQDbMoVzyL8nHT+lcMsU0RgZGda5hIUpRjCtqCrX4xrsEh1cX+XE546sLjrxBraDxSmXUp4YbacAO3ucZPaJLvvur8V8QXEvdciAZwrn5ErpcTJSEadqJoz6vEtImw= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3979.eurprd05.prod.outlook.com (52.134.67.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.11; Thu, 2 May 2019 18:13:15 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98%5]) with mapi id 15.20.1856.008; Thu, 2 May 2019 18:13:15 +0000 From: Yongseok Koh To: Dekel Peled CC: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [PATCH v2 1/4] net/mlx5: remove unused functions Thread-Index: AQHVAPiAfNfYPLhM3E+hpu3DltTTqaZYI3kA Date: Thu, 2 May 2019 18:13:14 +0000 Message-ID: <572DA463-7F7E-4C49-9B16-2858A062CC0E@mellanox.com> References: <3a54a27536a425c608c826f79b642f5f203fc3dd.1556809050.git.dekelp@mellanox.com> In-Reply-To: <3a54a27536a425c608c826f79b642f5f203fc3dd.1556809050.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 36b59c53-bdc3-405a-0e4e-08d6cf29d863 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3979; x-ms-traffictypediagnostic: DB3PR0502MB3979: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 0025434D2D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(346002)(376002)(366004)(136003)(199004)(189003)(6436002)(6116002)(3846002)(68736007)(14454004)(73956011)(37006003)(91956017)(316002)(54906003)(6862004)(8936002)(6636002)(83716004)(4326008)(186003)(71200400001)(71190400001)(66946007)(99286004)(2906002)(66066001)(66476007)(66556008)(66446008)(64756008)(229853002)(26005)(6486002)(5660300002)(76116006)(486006)(305945005)(7736002)(6506007)(82746002)(6246003)(8676002)(53936002)(81166006)(81156014)(14444005)(25786009)(33656002)(102836004)(256004)(6512007)(86362001)(446003)(11346002)(476003)(76176011)(478600001)(36756003)(2616005)(53546011); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3979; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 2SbI1IR9GaKo7Ib1zj9oTUU7J9lsok7LHqGUxMaX+YQ9h5jfhYpnzqxQ7FQAqqJA1ucEMMfyRbP/I6GwQlkj4yVPa/ZUgNZMrXeyJP3Tk/iDOBBgcLrWh68TB3darbfDYpEynjxcRxqq2s66tmqKA97MM/cFVJpSfDSvEJDlgXZ5yZK8jmSnRb27KlIWWXg0geayyFY01cZeotZFPgFkwJe9H2+/CzYnroE7hlN4R0GjiSHF0A831bP2OgqZDyUWZgDrLysE6v0Ms70X/PMCqzUKo7Ai4lHR+0ffbuKubsl6O26jd+5LDjuLF31MYk0c03y6cYf5Qu1ES66xt4SZhu6UrSelD6dnl4/czYBIYGqyrlzm32ZGNdodSMBcaEPyZzyyarvR6gG/2SaJGEKafHIeMXZiqy+h4kKEgRoyF5k= Content-Type: text/plain; charset="UTF-8" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36b59c53-bdc3-405a-0e4e-08d6cf29d863 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2019 18:13:14.8351 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3979 Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/mlx5: remove unused functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502181314.kZuJ7LS_VJq3ObP9Hv-TMBx-4QtV35E0IJYZxGhVyJk@z> > On May 2, 2019, at 8:01 AM, Dekel Peled wrote: >=20 > Functions implemented but never called: > mlx5_rxq_ibv_releasable() > mlx5_rxq_cleanup() > mlx5_txq_ibv_releasable() >=20 > Function declared but not implemented: > rxq_alloc_mprq_buf() >=20 > This patch removes these functions from code and header file. >=20 > Signed-off-by: Dekel Peled > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_rxq.c | 31 ------------------------------- > drivers/net/mlx5/mlx5_rxtx.h | 4 ---- > drivers/net/mlx5/mlx5_txq.c | 13 ------------- > 3 files changed, 48 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index 54438a4..db8c340 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -368,24 +368,6 @@ > } >=20 > /** > - * Clean up a RX queue. > - * > - * Destroy objects, free allocated memory and reset the structure for re= use. > - * > - * @param rxq_ctrl > - * Pointer to RX queue structure. > - */ > -void > -mlx5_rxq_cleanup(struct mlx5_rxq_ctrl *rxq_ctrl) > -{ > - DRV_LOG(DEBUG, "port %u cleaning up Rx queue %u", > - PORT_ID(rxq_ctrl->priv), rxq_ctrl->rxq.idx); > - if (rxq_ctrl->ibv) > - mlx5_rxq_ibv_release(rxq_ctrl->ibv); > - memset(rxq_ctrl, 0, sizeof(*rxq_ctrl)); > -} > - > -/** > * Returns the per-queue supported offloads. > * > * @param dev > @@ -1131,19 +1113,6 @@ struct mlx5_rxq_ibv * > } >=20 > /** > - * Return true if a single reference exists on the object. > - * > - * @param rxq_ibv > - * Verbs Rx queue object. > - */ > -int > -mlx5_rxq_ibv_releasable(struct mlx5_rxq_ibv *rxq_ibv) > -{ > - assert(rxq_ibv); > - return (rte_atomic32_read(&rxq_ibv->refcnt) =3D=3D 1); > -} > - > -/** > * Callback function to initialize mbufs for Multi-Packet RQ. > */ > static inline void > diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h > index 0d88375..1732e32 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.h > +++ b/drivers/net/mlx5/mlx5_rxtx.h > @@ -251,7 +251,6 @@ struct mlx5_txq_ctrl { > int mlx5_mprq_enabled(struct rte_eth_dev *dev); > int mlx5_mprq_free_mp(struct rte_eth_dev *dev); > int mlx5_mprq_alloc_mp(struct rte_eth_dev *dev); > -void mlx5_rxq_cleanup(struct mlx5_rxq_ctrl *rxq_ctrl); > int mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t d= esc, > unsigned int socket, const struct rte_eth_rxconf *conf, > struct rte_mempool *mp); > @@ -263,7 +262,6 @@ int mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint= 16_t idx, uint16_t desc, > struct mlx5_rxq_ibv *mlx5_rxq_ibv_new(struct rte_eth_dev *dev, uint16_t i= dx); > struct mlx5_rxq_ibv *mlx5_rxq_ibv_get(struct rte_eth_dev *dev, uint16_t i= dx); > int mlx5_rxq_ibv_release(struct mlx5_rxq_ibv *rxq_ibv); > -int mlx5_rxq_ibv_releasable(struct mlx5_rxq_ibv *rxq_ibv); > struct mlx5_rxq_ibv *mlx5_rxq_ibv_drop_new(struct rte_eth_dev *dev); > void mlx5_rxq_ibv_drop_release(struct rte_eth_dev *dev); > int mlx5_rxq_ibv_verify(struct rte_eth_dev *dev); > @@ -276,7 +274,6 @@ struct mlx5_rxq_ctrl *mlx5_rxq_new(struct rte_eth_dev= *dev, uint16_t idx, > int mlx5_rxq_releasable(struct rte_eth_dev *dev, uint16_t idx); > int mlx5_rxq_verify(struct rte_eth_dev *dev); > int rxq_alloc_elts(struct mlx5_rxq_ctrl *rxq_ctrl); > -int rxq_alloc_mprq_buf(struct mlx5_rxq_ctrl *rxq_ctrl); > struct mlx5_ind_table_ibv *mlx5_ind_table_ibv_new(struct rte_eth_dev *dev= , > const uint16_t *queues, > uint32_t queues_n); > @@ -314,7 +311,6 @@ int mlx5_tx_queue_setup(struct rte_eth_dev *dev, uint= 16_t idx, uint16_t desc, > struct mlx5_txq_ibv *mlx5_txq_ibv_new(struct rte_eth_dev *dev, uint16_t i= dx); > struct mlx5_txq_ibv *mlx5_txq_ibv_get(struct rte_eth_dev *dev, uint16_t i= dx); > int mlx5_txq_ibv_release(struct mlx5_txq_ibv *txq_ibv); > -int mlx5_txq_ibv_releasable(struct mlx5_txq_ibv *txq_ibv); > int mlx5_txq_ibv_verify(struct rte_eth_dev *dev); > struct mlx5_txq_ctrl *mlx5_txq_new(struct rte_eth_dev *dev, uint16_t idx, > uint16_t desc, unsigned int socket, > diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c > index 0b6c247..2cdb1d3 100644 > --- a/drivers/net/mlx5/mlx5_txq.c > +++ b/drivers/net/mlx5/mlx5_txq.c > @@ -668,19 +668,6 @@ struct mlx5_txq_ibv * > } >=20 > /** > - * Return true if a single reference exists on the object. > - * > - * @param txq_ibv > - * Verbs Tx queue object. > - */ > -int > -mlx5_txq_ibv_releasable(struct mlx5_txq_ibv *txq_ibv) > -{ > - assert(txq_ibv); > - return (rte_atomic32_read(&txq_ibv->refcnt) =3D=3D 1); > -} > - > -/** > * Verify the Verbs Tx queue list is empty > * > * @param dev > --=20 > 1.8.3.1 >=20