* [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message
@ 2019-04-24 16:46 Stephen Hemminger
2019-04-24 16:46 ` Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Stephen Hemminger @ 2019-04-24 16:46 UTC (permalink / raw)
To: anatoly.burakov; +Cc: dev, Stephen Hemminger
This message was missing newline, and should capitalize
"Cannot" like all the others in this area.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_eal/common/hotplug_mp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/hotplug_mp.c b/lib/librte_eal/common/hotplug_mp.c
index 4052a5c7fb71..04616519cde0 100644
--- a/lib/librte_eal/common/hotplug_mp.c
+++ b/lib/librte_eal/common/hotplug_mp.c
@@ -376,7 +376,7 @@ int eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req)
ret = rte_mp_request_sync(&mp_req, &mp_reply, &ts);
if (ret || mp_reply.nb_received != 1) {
- RTE_LOG(ERR, EAL, "cannot send request to primary");
+ RTE_LOG(ERR, EAL, "Cannot send request to primary\n");
if (!ret)
return -1;
return ret;
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message
2019-04-24 16:46 [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message Stephen Hemminger
@ 2019-04-24 16:46 ` Stephen Hemminger
2019-04-24 18:48 ` Rami Rosen
2019-05-03 8:22 ` Thomas Monjalon
2 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2019-04-24 16:46 UTC (permalink / raw)
To: anatoly.burakov; +Cc: dev, Stephen Hemminger
This message was missing newline, and should capitalize
"Cannot" like all the others in this area.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_eal/common/hotplug_mp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/hotplug_mp.c b/lib/librte_eal/common/hotplug_mp.c
index 4052a5c7fb71..04616519cde0 100644
--- a/lib/librte_eal/common/hotplug_mp.c
+++ b/lib/librte_eal/common/hotplug_mp.c
@@ -376,7 +376,7 @@ int eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req)
ret = rte_mp_request_sync(&mp_req, &mp_reply, &ts);
if (ret || mp_reply.nb_received != 1) {
- RTE_LOG(ERR, EAL, "cannot send request to primary");
+ RTE_LOG(ERR, EAL, "Cannot send request to primary\n");
if (!ret)
return -1;
return ret;
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message
2019-04-24 16:46 [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message Stephen Hemminger
2019-04-24 16:46 ` Stephen Hemminger
@ 2019-04-24 18:48 ` Rami Rosen
2019-04-24 18:48 ` Rami Rosen
2019-05-03 8:22 ` Thomas Monjalon
2 siblings, 1 reply; 6+ messages in thread
From: Rami Rosen @ 2019-04-24 18:48 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: anatoly.burakov, dev
Acked-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message
2019-04-24 18:48 ` Rami Rosen
@ 2019-04-24 18:48 ` Rami Rosen
0 siblings, 0 replies; 6+ messages in thread
From: Rami Rosen @ 2019-04-24 18:48 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: anatoly.burakov, dev
Acked-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message
2019-04-24 16:46 [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message Stephen Hemminger
2019-04-24 16:46 ` Stephen Hemminger
2019-04-24 18:48 ` Rami Rosen
@ 2019-05-03 8:22 ` Thomas Monjalon
2019-05-03 8:22 ` Thomas Monjalon
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-05-03 8:22 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, anatoly.burakov
24/04/2019 18:46, Stephen Hemminger:
> This message was missing newline, and should capitalize
> "Cannot" like all the others in this area.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message
2019-05-03 8:22 ` Thomas Monjalon
@ 2019-05-03 8:22 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-05-03 8:22 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, anatoly.burakov
24/04/2019 18:46, Stephen Hemminger:
> This message was missing newline, and should capitalize
> "Cannot" like all the others in this area.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-03 8:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24 16:46 [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message Stephen Hemminger
2019-04-24 16:46 ` Stephen Hemminger
2019-04-24 18:48 ` Rami Rosen
2019-04-24 18:48 ` Rami Rosen
2019-05-03 8:22 ` Thomas Monjalon
2019-05-03 8:22 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).