DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: david.hunt@intel.com
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [RFC PATCH 0/4] allow vm_power_manager to build using pkg-config
Date: Fri,  3 May 2019 15:08:57 +0100	[thread overview]
Message-ID: <20190503140901.59064-1-bruce.richardson@intel.com> (raw)

The vm_power_manager builds using meson as part of a DPDK build, but did
not support building using make and the libdpdk.pc file. Unfortunately,
adding this support was not as easy as for other examples, as the
vm_power_manager example was depending on a non-public header file in the
power library. Since this header is needed to write real applications, like
the example, this patchset makes the header public.

A second, more minor, complication was that the build selected at
compile-time which of two C files to include in the app using DPDK
build-time variables.  Since these vars are not available when building
outside the DPDK build-system we need to change this to always compiling
both files, and using macros to select the correct set of functions to use.
[In this case, merging the files into one was also considered, and would
work fine, it just wouldn't scale as well as keeping the files separate if
solutions for other architectures were added later].


Bruce Richardson (4):
  power: make channel commands header public
  power: add namespace prefix to public header elements
  examples/vm_power_manager: always compile all C files
  examples/vm_power_manager: support build using pkg-config

 examples/vm_power_manager/Makefile            | 85 ++++++++++++++-----
 examples/vm_power_manager/channel_manager.c   |  2 +-
 examples/vm_power_manager/channel_monitor.c   | 73 ++++++++--------
 examples/vm_power_manager/channel_monitor.h   | 10 +--
 examples/vm_power_manager/guest_cli/main.c    |  2 +-
 .../guest_cli/vm_power_cli_guest.c            | 10 +--
 .../guest_cli/vm_power_cli_guest.h            |  4 +-
 examples/vm_power_manager/main.c              |  2 +-
 examples/vm_power_manager/meson.build         | 16 ++--
 examples/vm_power_manager/oob_monitor_nop.c   |  4 +
 examples/vm_power_manager/oob_monitor_x86.c   |  4 +
 examples/vm_power_manager/vm_power_cli.c      |  1 -
 lib/librte_power/Makefile                     |  4 +-
 lib/librte_power/channel_commands.h           | 85 -------------------
 lib/librte_power/guest_channel.c              |  8 +-
 lib/librte_power/guest_channel.h              |  6 +-
 lib/librte_power/meson.build                  |  4 +-
 lib/librte_power/power_kvm_vm.c               | 16 ++--
 lib/librte_power/rte_channel_commands.h       | 85 +++++++++++++++++++
 19 files changed, 235 insertions(+), 186 deletions(-)
 delete mode 100644 lib/librte_power/channel_commands.h
 create mode 100644 lib/librte_power/rte_channel_commands.h

-- 
2.20.1

             reply	other threads:[~2019-05-03 14:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03 14:08 Bruce Richardson [this message]
2019-05-03 14:08 ` Bruce Richardson
2019-05-03 14:08 ` [dpdk-dev] [RFC PATCH 1/4] power: make channel commands header public Bruce Richardson
2019-05-03 14:08   ` Bruce Richardson
2019-05-03 14:08 ` [dpdk-dev] [RFC PATCH 2/4] power: add namespace prefix to public header elements Bruce Richardson
2019-05-03 14:08   ` Bruce Richardson
2019-05-03 14:09 ` [dpdk-dev] [RFC PATCH 3/4] examples/vm_power_manager: always compile all C files Bruce Richardson
2019-05-03 14:09   ` Bruce Richardson
2019-05-03 14:09 ` [dpdk-dev] [RFC PATCH 4/4] examples/vm_power_manager: support build using pkg-config Bruce Richardson
2019-05-03 14:09   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190503140901.59064-1-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).