DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression
Date: Fri, 3 May 2019 19:16:21 +0200	[thread overview]
Message-ID: <CAJFAV8zh4XrJB1bzJvC3zMNDD-APapXfcy2oXC3beKLqXsFQWQ@mail.gmail.com> (raw)
Message-ID: <20190503171621.0oS9SmLFdn6lp931us1nSfBL_QTgTf-4YRzuqVJkvsc@z> (raw)
In-Reply-To: <20190503150346.GA32640@hmswarspite.think-freely.org>

On Fri, May 3, 2019 at 5:18 PM Neil Horman <nhorman@tuxdriver.com> wrote:

> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote:
> > Even if rare, the check script should handle removing a section.
> >
> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> >  devtools/check-symbol-change.sh | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/devtools/check-symbol-change.sh
> b/devtools/check-symbol-change.sh
> > index 8da7650..d5fad04 100755
> > --- a/devtools/check-symbol-change.sh
> > +++ b/devtools/check-symbol-change.sh
> > @@ -32,6 +32,7 @@ build_map_changes()
> >               # symbol rule below
> >               /^.*{/ {
> >                       gsub("+", "");
> > +                     gsub("-", "");
> >                       if (in_map == 1) {
> >                               sec=$(NF-1); in_sec=1;
> >                       }
> > --
> > 1.8.3.1
> >
> >
> Don't you also need to add some logic in the symbol detection match rule to
> print an appropriate indicator that a symbol is being removed?  With just
> this
> change, you will note that you are parsing a section, but you will never
> trigger
> a symbol match
>

I do remember seeing a warning about the "-EXPERIMENTAL" section.
And this is why I added this.
But since then I reorganised my series and eliminated some parts... so you
are most likely right.
I will double check and repost.


-- 
David Marchand

  parent reply	other threads:[~2019-05-03 17:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03 14:34 [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols David Marchand
2019-05-03 14:34 ` David Marchand
2019-05-03 14:34 ` [dpdk-dev] [PATCH 2/4] devtools: handle section suppression David Marchand
2019-05-03 14:34   ` David Marchand
2019-05-03 15:03   ` Neil Horman
2019-05-03 15:03     ` Neil Horman
2019-05-03 17:16     ` David Marchand [this message]
2019-05-03 17:16       ` David Marchand
2019-05-06 12:56       ` David Marchand
2019-05-06 12:56         ` David Marchand
2019-05-06 15:43         ` Neil Horman
2019-05-06 15:43           ` Neil Horman
2019-05-03 14:34 ` [dpdk-dev] [PATCH 3/4] devtools: fix symbol name in log message David Marchand
2019-05-03 14:34   ` David Marchand
2019-05-03 14:34 ` [dpdk-dev] [PATCH 4/4] devtools: fix direct additions to stable API David Marchand
2019-05-03 14:34   ` David Marchand
2019-05-09 21:40   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-09 21:40     ` Thomas Monjalon
2019-05-03 16:15 ` [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols Ray Kinsella
2019-05-03 16:15   ` Ray Kinsella
2019-05-03 17:12   ` David Marchand
2019-05-03 17:12     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8zh4XrJB1bzJvC3zMNDD-APapXfcy2oXC3beKLqXsFQWQ@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=nhorman@tuxdriver.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).