From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 15926A0AC5 for ; Sat, 4 May 2019 23:17:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF6D51F28; Sat, 4 May 2019 23:17:16 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 84CCEA49 for ; Sat, 4 May 2019 23:17:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1BDAB20CCC; Sat, 4 May 2019 17:17:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 04 May 2019 17:17:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=d6JVVT0KCTS+58Dnj5ZDh6c7QwGPtARPYstZTNOAvXA=; b=XbkNpcSi7WD+ xz/oMaY8CDYQhKvQOFfoEnVTfHFyISs+jYfDcamENhn7VF633yexR4u7I2Tp1xNV qY2EB92FSgKJALiPfpOfAoUYOhjSPLnD8ZIc8+2zLcTtk6M0XPflvORVQjZWqpHq 0dkRlsLqQzlILUvNksmjpgL0kjrpyAI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=d6JVVT0KCTS+58Dnj5ZDh6c7QwGPtARPYstZTNOAv XA=; b=mrK5pt51tm6BgzVN3M2F3ghWtTHzLwMyZ4Ow42PMRyGeN37K5mXVZvLX4 WA5A/3CcnosMOW3ncaUj5NNlRoWNMTg7j1XNse/hBjoWoCLhW4ZCYhPlDdIp6QMP X5c4209nBIQz7xePK8gXJvLa4Nnsdbr14/WQsYHtpJFrAYgNQFv4sO9U0yeoJoOg TDl4RLmUnmJbIIGW8ToLHjzwMr3dOrjNJvLb+LbQuH3dHYA4iJqjgPIB1PcTG6yM V86FcjQY0eAQ2sxUa024RLujfB26a2DjOE36cmdPhl8xgKfQjZGPl1+UWLSi2iEL HGRwU6B+2PUg5o3A/foftqerlftGA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjeefgdduiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6C833103CA; Sat, 4 May 2019 17:17:12 -0400 (EDT) From: Thomas Monjalon To: "Suanming. Mou" Cc: dev@dpdk.org, vipin.varghese@intel.com, anatoly.burakov@intel.com Date: Sat, 04 May 2019 23:17:11 +0200 Message-ID: <6913769.b5EUOLfAN7@xps> In-Reply-To: <1556862508-61677-1-git-send-email-mousuanming@huawei.com> References: <1556800505-59917-1-git-send-email-mousuanming@huawei.com> <1556862508-61677-1-git-send-email-mousuanming@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190504211711.b_dsQv4R98495UCDuA9OOxEY4sc4yCdOHcgsvx_wLcc@z> Hi, 03/05/2019 07:48, Suanming. Mou: > When primary app exits, the residual running pdump will stop the > primary app to restart. Add pdump exits with primary support. Sorry I fail to parse this sentence. Maybe it should be longer to be more explicit about what it the current issue and how it is solved. Some comments in the code may also be improved. > Signed-off-by: Suanming.Mou I think you should remove the dot in your name. > Reviewed-by: Anatoly Burakov > Reviewed-by: Vipin Varghese > --- > V8: > * reword the print info in monitor_primary. > * add release_19_05.rst update. As it is not a fix, it will slip in 19.08.