From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1A5AA1041 for ; Sun, 5 May 2019 08:01:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2019 23:01:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,431,1549958400"; d="scan'208";a="148514862" Received: from dpdk-xiao-1.sh.intel.com ([10.67.111.145]) by fmsmga007.fm.intel.com with ESMTP; 04 May 2019 23:01:16 -0700 From: Xiao Wang To: wenzhuo.lu@intel.com Cc: dev@dpdk.org, qiming.yang@intel.com, Xiao Wang Date: Sun, 5 May 2019 13:45:28 +0800 Message-Id: <20190505054528.133534-1-xiao.w.wang@intel.com> X-Mailer: git-send-email 2.15.1 Subject: [dpdk-dev] [PATCH] net/ice: minor code cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 May 2019 06:01:19 -0000 This patch is a cleanup on comment, variable modifier, coding style. Signed-off-by: Xiao Wang --- drivers/net/ice/ice_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 1f06a2c80..706632424 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -1587,7 +1587,7 @@ ice_dev_uninit(struct rte_eth_dev *dev) /* disable uio intr before callback unregister */ rte_intr_disable(intr_handle); - /* register callback func to eal lib */ + /* unregister callback func from eal lib */ rte_intr_callback_unregister(intr_handle, ice_interrupt_handler, dev); @@ -2125,7 +2125,7 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev, } static int -ice_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete) +ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) { #define CHECK_INTERVAL 100 /* 100ms */ #define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */ @@ -2502,7 +2502,7 @@ ice_vlan_tpid_set(struct rte_eth_dev *dev, reg_id = 3; else reg_id = 5; - break; + break; case ETH_VLAN_TYPE_INNER: if (qinq) { reg_id = 5; -- 2.15.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 102A0A0096 for ; Sun, 5 May 2019 08:01:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23E732082; Sun, 5 May 2019 08:01:20 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1A5AA1041 for ; Sun, 5 May 2019 08:01:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2019 23:01:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,431,1549958400"; d="scan'208";a="148514862" Received: from dpdk-xiao-1.sh.intel.com ([10.67.111.145]) by fmsmga007.fm.intel.com with ESMTP; 04 May 2019 23:01:16 -0700 From: Xiao Wang To: wenzhuo.lu@intel.com Cc: dev@dpdk.org, qiming.yang@intel.com, Xiao Wang Date: Sun, 5 May 2019 13:45:28 +0800 Message-Id: <20190505054528.133534-1-xiao.w.wang@intel.com> X-Mailer: git-send-email 2.15.1 Subject: [dpdk-dev] [PATCH] net/ice: minor code cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190505054528.AOsukMJuaaAo9co9B8ae9lduDkf3kJL-jtZYgbUyI2g@z> This patch is a cleanup on comment, variable modifier, coding style. Signed-off-by: Xiao Wang --- drivers/net/ice/ice_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 1f06a2c80..706632424 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -1587,7 +1587,7 @@ ice_dev_uninit(struct rte_eth_dev *dev) /* disable uio intr before callback unregister */ rte_intr_disable(intr_handle); - /* register callback func to eal lib */ + /* unregister callback func from eal lib */ rte_intr_callback_unregister(intr_handle, ice_interrupt_handler, dev); @@ -2125,7 +2125,7 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev, } static int -ice_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete) +ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) { #define CHECK_INTERVAL 100 /* 100ms */ #define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */ @@ -2502,7 +2502,7 @@ ice_vlan_tpid_set(struct rte_eth_dev *dev, reg_id = 3; else reg_id = 5; - break; + break; case ETH_VLAN_TYPE_INNER: if (qinq) { reg_id = 5; -- 2.15.1