From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C8A6EA0096 for ; Sun, 5 May 2019 11:42:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B52C2082; Sun, 5 May 2019 11:42:53 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 66F051F28 for ; Sun, 5 May 2019 11:42:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F360621FEC; Sun, 5 May 2019 05:42:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 05 May 2019 05:42:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=3qCVgi498UWbtPzK7S5p0zo1/v7SGsbIQ5IvEMEunhM=; b=U0KYBP6gi7N4 KxDekqVKK9hUpo7/OZ+0nrTiT42QJkyqpgA0uqqPlf7obDS+9fcWcfftEdjcjbKu zN+tp9/YlTW+BrsmYoBpsK+6IUlRs47gUN2l7ufT+0GX4C6hSIVy14pPsKv1iNmA BDPDmo9KPezwPo2m9z3Qdeq/iEbzhmI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=3qCVgi498UWbtPzK7S5p0zo1/v7SGsbIQ5IvEMEun hM=; b=44uPh25CIee5cbGhRIQfdReFdnJYUQKexP0VBdRLhWhtdZoL/3Gn0E0yW NzpAZBMhv+Z3fhXXU1wULYRzvFrECt/OjRXnxjf6/+kKkBNrTZozkq2p1HWSM9KX d2405zkAURhqZuO/sdeQiERAbjY/G5OkDNgOehSih+1TNUnjHPxngztXdccT7Jl7 507xXek/xpt6KtW++zWFxWRfennPjdGp01lpyD+IcSmq1wNVENz0qAIcCh7vH+wC 0d3biDrwnKFWSmG/OBzXj8SZrkSW8W/Eu6Cg15B689IMCgl7ghVExugxSFEU7lGk RHn8FrPDO30tNye/dKbsFiOrtJ6Gw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjeehgddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 85B5DE4382; Sun, 5 May 2019 05:42:50 -0400 (EDT) From: Thomas Monjalon To: "Suanming. Mou" Cc: dev@dpdk.org, vipin.varghese@intel.com, anatoly.burakov@intel.com Date: Sun, 05 May 2019 11:42:47 +0200 Message-ID: <45819937.3Ixltl9v64@xps> In-Reply-To: <818cde04-8f60-b3d8-a15d-37a435bbc6bf@huawei.com> References: <1556800505-59917-1-git-send-email-mousuanming@huawei.com> <6913769.b5EUOLfAN7@xps> <818cde04-8f60-b3d8-a15d-37a435bbc6bf@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190505094247.PK4rGkcHqKyLpTYNP9DMSjoX6swH3MthTnyzVuKxFHE@z> 05/05/2019 03:20, Suanming. Mou: > On 2019/5/5 5:17, Thomas Monjalon wrote: > > Hi, > > > > 03/05/2019 07:48, Suanming. Mou: > >> When primary app exits, the residual running pdump will stop the > >> primary app to restart. Add pdump exits with primary support. > > Sorry I fail to parse this sentence. > > Maybe it should be longer to be more explicit about > > what it the current issue and how it is solved. > Thanks for the suggestion. It's fine to add more contents. > > Some comments in the code may also be improved. > > Could you please help to show the detail? Or it will be hard to do the > improvement. > > ` There are a thousand Hamlets in a thousand people's eyes.` Yes, you're right :) [..] > >> V8: > >> * reword the print info in monitor_primary. > >> * add release_19_05.rst update. > > As it is not a fix, it will slip in 19.08. > > It seems 19.08 is still not started yet. > > Does that mean the patch should be hung till 19.08 be started? Yes, either to wait one week, or fake the 19.08 release notes template to do your patch on top.