DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/ip_fragmentation: fix Tx queues init
@ 2019-05-06  9:49 Ali Alnubani
  2019-05-06  9:49 ` Ali Alnubani
  2019-06-04 10:42 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  0 siblings, 2 replies; 5+ messages in thread
From: Ali Alnubani @ 2019-05-06  9:49 UTC (permalink / raw)
  To: konstantin.ananyev; +Cc: dev, stable

The application tries to configure queue ids larger
than the maximum allowed by MAX_TX_QUEUE_PER_PORT. This
causes the startup error:

"
  ...
  Initializing port 0 on lcore 0... Address:7C:FE:90:12:23:0D
  txq=0,0 txq=1,1 txq=2,2 txq=3,3 txq=4,4 txq=5,5 txq=6,6 txq=7,7 txq=8,8
  txq=9,9 txq=10,10 txq=11,11 txq=12,12 txq=13,13 txq=14,14 txq=15,15
  txq=16,16 Invalid TX queue_id=16

  EAL: Error - exiting with code: 1
    Cause: rte_eth_tx_queue_setup: err=-22, port=0
"

The error reproduces when lcores aren't set, and when the
machine has more than 16 cores.

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
 examples/ip_fragmentation/main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index e90a61e35..953115aba 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -984,6 +984,9 @@ main(int argc, char **argv)
 			if (rte_lcore_is_enabled(lcore_id) == 0)
 				continue;
 
+			if (queueid >= rte_eth_devices[portid].data->nb_tx_queues)
+				break;
+
 			socket = (int) rte_lcore_to_socket_id(lcore_id);
 			printf("txq=%u,%d ", lcore_id, queueid);
 			fflush(stdout);
-- 
2.19.2


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] examples/ip_fragmentation: fix Tx queues init
@ 2019-05-06  8:56 Ali Alnubani
  2019-05-06  8:56 ` Ali Alnubani
  0 siblings, 1 reply; 5+ messages in thread
From: Ali Alnubani @ 2019-05-06  8:56 UTC (permalink / raw)
  To: konstantin.ananyev; +Cc: dev, stable

The application tries to configure queue ids larger
than the maximum allowed by MAX_TX_QUEUE_PER_PORT. This
causes the startup error:

"
  ...
  Initializing port 0 on lcore 0... Address:7C:FE:90:12:23:0D
  txq=0,0 txq=1,1 txq=2,2 txq=3,3 txq=4,4 txq=5,5 txq=6,6 txq=7,7 txq=8,8
  txq=9,9 txq=10,10 txq=11,11 txq=12,12 txq=13,13 txq=14,14 txq=15,15
  txq=16,16 Invalid TX queue_id=16

  EAL: Error - exiting with code: 1
    Cause: rte_eth_tx_queue_setup: err=-22, port=0
"

The error reproduces when lcores aren't set, and when the
machine has more than 16 cores.

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
 examples/ip_fragmentation/main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index e90a61e35..953115aba 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -984,6 +984,9 @@ main(int argc, char **argv)
 			if (rte_lcore_is_enabled(lcore_id) == 0)
 				continue;
 
+			if (queueid >= rte_eth_devices[portid].data->nb_tx_queues)
+				break;
+
 			socket = (int) rte_lcore_to_socket_id(lcore_id);
 			printf("txq=%u,%d ", lcore_id, queueid);
 			fflush(stdout);
-- 
2.19.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-06-04 10:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-06  9:49 [dpdk-dev] [PATCH] examples/ip_fragmentation: fix Tx queues init Ali Alnubani
2019-05-06  9:49 ` Ali Alnubani
2019-06-04 10:42 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2019-05-06  8:56 [dpdk-dev] " Ali Alnubani
2019-05-06  8:56 ` Ali Alnubani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).