DPDK patches and discussions
 help / color / mirror / Atom feed
From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: Ido Goshen <Ido@cgstowernetworks.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support
Date: Mon, 6 May 2019 11:22:27 +0000	[thread overview]
Message-ID: <edc9a09e-8240-1b1d-c714-7228c3dac44c@aquantia.com> (raw)
Message-ID: <20190506112227.4Mln4Q3OfCQkq-worAzjxUrD71oj7hmUS-oSAy_7wok@z> (raw)
In-Reply-To: <AM0PR09MB32986E86FE634E60EA07B163D6340@AM0PR09MB3298.eurprd09.prod.outlook.com>


>>>
>>> The hw->allow_unsupported_sfp is used too late in
>>> https://git.dpdk.org/next/dpdk-next-net-intel/tree/drivers/net/ixgbe/b
>>> ase/ixgbe_phy.c#n1530 And if we've already got out earlier in
>>> https://git.dpdk.org/next/dpdk-next-net-intel/tree/drivers/net/ixgbe/b
>>> ase/ixgbe_phy.c#n1507
>>
>> As I can read the code that check is for 1G SFPs.
>> So if you getting out here, then comp_codes_10g == 0 here, and it means
>> that given SFP is not recognized as 10G one.
>> I wonder why that happens?
>>
>> As I can see comp_codes_10g should be initialized at line 1314:
>> status = hw->phy.ops.read_i2c_eeprom(hw,
>>                                                      IXGBE_SFF_10GBE_COMP_CODES,
>>                                                      &comp_codes_10g);
>>
> 
> The samples I have (from 2 vendors) read 0 from the eeprom IXGBE_SFF_10GBE_COMP_CODES offset
> 
> SFF-8472 spec [https://members.snia.org/document/dl/25916] doesn't define a code value for 10GBASE-T 
> 	TABLE 5-3 TRANSCEIVER COMPLIANCE CODES	
> 	10G Ethernet Compliance Codes
> 	3 	7 	10G Base-ER 	 
> 	3 	6 	10G Base-LRM 
> 	3 	5 	10G Base-LR 
> 	3 	4 	10G Base-SR 
> 	Infiniband Compliance Codes
> 	3 	3 	1X SX
> 	3 	2 	1X LX
> 	3 	1 	1X Copper Active
> 	3 	0 	1X Copper Active
> Seems they are right not to set any code from above, no?
>  
> Do you know any 10GBASE-T SFPs that does work? 
> Any idea what does it return for this field?
> 

I can confirm we saw the same issues using Aquantia SFP+ Copper modules with 550
MAC. Indeed there is no separate id for Base-T.

ixgbe logic both in kernel and dpdk discards such modules.

Regards,
  Igor

  parent reply	other threads:[~2019-05-06 11:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 11:31 Ido Goshen
2019-04-24 11:31 ` Ido Goshen
2019-04-24 11:47 ` Ananyev, Konstantin
2019-04-24 11:47   ` Ananyev, Konstantin
2019-04-24 21:25   ` Ido Goshen
2019-04-24 21:25     ` Ido Goshen
2019-04-26 12:13     ` Ananyev, Konstantin
2019-04-26 12:13       ` Ananyev, Konstantin
2019-04-28  6:54       ` Ido Goshen
2019-04-28  6:54         ` Ido Goshen
2019-05-01 23:40         ` Ananyev, Konstantin
2019-05-01 23:40           ` Ananyev, Konstantin
2019-05-02  9:15           ` Ido Goshen
2019-05-02  9:15             ` Ido Goshen
2019-05-06 11:22             ` Igor Russkikh [this message]
2019-05-06 11:22               ` Igor Russkikh
2019-05-07 22:45               ` Stillwell Jr, Paul M
2019-05-07 22:45                 ` Stillwell Jr, Paul M
2019-05-14 12:21                 ` Igor Russkikh
2019-05-14 12:21                   ` Igor Russkikh
2019-05-14 17:10                 ` Ido Goshen
2019-05-14 17:10                   ` Ido Goshen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edc9a09e-8240-1b1d-c714-7228c3dac44c@aquantia.com \
    --to=igor.russkikh@aquantia.com \
    --cc=Ido@cgstowernetworks.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).