From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 9A633A0096
	for <public@inbox.dpdk.org>; Tue,  7 May 2019 12:09:55 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 584D437AF;
	Tue,  7 May 2019 12:09:55 +0200 (CEST)
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com
 [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id AFCA6378B
 for <dev@dpdk.org>; Tue,  7 May 2019 12:09:53 +0200 (CEST)
Received: by mail-wr1-f67.google.com with SMTP id f7so11155206wrq.1
 for <dev@dpdk.org>; Tue, 07 May 2019 03:09:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
 :references:content-transfer-encoding:user-agent:mime-version;
 bh=2OEB2er7lCt72xl/q+kPZsWMW9rVQMxENNBVMYh8M0Q=;
 b=eezNdXbMRu8kIAQ41IxoMld8lL5Bc3GaLgBCaK+i9vtXh8cCC2f7+0cCUKfHpE4Cc5
 159Y+3Nokj5vplNrCzWvCBFvhT0cYhOs/BbLPWqdlHNuygohNABvTGrxqkuOyyGNCcLu
 EJ59oVzhUALsrwu+v8GTi3ooqwalL66OX0cXRA9qR+ofap6opqIncA/DFLzEQirArVP+
 1OPwNSL3gVs/9coJv3jYYcVYEDzW3U2uU/lpYrcD38SkDqzeruJIJA+tzFONx7LJq4tA
 g8BmA9j25bWc3b6C0igenbl+PGYxMitLWH+OE0IhElQZR9atjAqymVb6ITvvKT/CP70q
 4fPw==
X-Gm-Message-State: APjAAAVuNxG0gpOFKqsvG+MYHgYJFIDrkhd8G0mwA8+nMnIF2NEoph+y
 R0zmfVliHlUZKpzAm5E2Ufw=
X-Google-Smtp-Source: APXvYqwVqJmKHSwXeEPHjc/cuDiCr9K9/ZaZeYngU9nF/CuOwEHBtb8kWmHxamARndte4L7ZS0cy9A==
X-Received: by 2002:adf:eb87:: with SMTP id t7mr15536097wrn.39.1557223793201; 
 Tue, 07 May 2019 03:09:53 -0700 (PDT)
Received: from localhost ([88.98.246.218])
 by smtp.gmail.com with ESMTPSA id v12sm10850225wrw.23.2019.05.07.03.09.52
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 07 May 2019 03:09:52 -0700 (PDT)
Message-ID: <23fe250a768fc5031a7c9018c3d730764dc9e2c8.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org, 
 "thomas@monjalon.net" <thomas@monjalon.net>
Date: Tue, 07 May 2019 11:09:51 +0100
In-Reply-To: <20190503133537.58712-3-bruce.richardson@intel.com>
References: <20190503133537.58712-1-bruce.richardson@intel.com>
 <20190503133537.58712-3-bruce.richardson@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.30.5-1 
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 19.08 2/6] examples: add support for
 relocated DPDK install
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190507100951.jWCnsKpa7Tav7j3KIcZdhBzCU1Gu6kQxcyXpk_pbqNk@z>

On Fri, 2019-05-03 at 14:35 +0100, Bruce Richardson wrote:
> For testing of DPDK, we want to override the prefix given by the
> pkg-config file, so that we can get correct paths for DPDK installed
> in an unusual location.
>=20
> Signed-off-by: Bruce Richardson <
> bruce.richardson@intel.com
> >
> ---
>  examples/bbdev_app/Makefile             | 13 +++++++++----
>  examples/bond/Makefile                  | 13 +++++++++----
>  examples/cmdline/Makefile               | 13 +++++++++----
>  examples/distributor/Makefile           | 13 +++++++++----
>  examples/eventdev_pipeline/Makefile     | 13 +++++++++----
>  examples/exception_path/Makefile        | 13 +++++++++----
>  examples/fips_validation/Makefile       | 13 +++++++++----
>  examples/flow_classify/Makefile         | 13 +++++++++----
>  examples/flow_filtering/Makefile        | 13 +++++++++----
>  examples/helloworld/Makefile            | 13 +++++++++----
>  examples/ip_fragmentation/Makefile      | 13 +++++++++----
>  examples/ip_pipeline/Makefile           | 13 +++++++++----
>  examples/ip_reassembly/Makefile         | 13 +++++++++----
>  examples/ipsec-secgw/Makefile           | 13 +++++++++----
>  examples/ipv4_multicast/Makefile        | 13 +++++++++----
>  examples/kni/Makefile                   | 13 +++++++++----
>  examples/l2fwd-cat/Makefile             | 13 +++++++++----
>  examples/l2fwd-crypto/Makefile          | 13 +++++++++----
>  examples/l2fwd-jobstats/Makefile        | 13 +++++++++----
>  examples/l2fwd-keepalive/Makefile       | 13 +++++++++----
>  examples/l2fwd/Makefile                 | 13 +++++++++----
>  examples/l3fwd-acl/Makefile             | 13 +++++++++----
>  examples/l3fwd-power/Makefile           | 13 +++++++++----
>  examples/l3fwd-vf/Makefile              | 13 +++++++++----
>  examples/l3fwd/Makefile                 | 13 +++++++++----
>  examples/link_status_interrupt/Makefile | 13 +++++++++----
>  examples/load_balancer/Makefile         | 13 +++++++++----
>  examples/packet_ordering/Makefile       | 13 +++++++++----
>  examples/ptpclient/Makefile             | 13 +++++++++----
>  examples/qos_meter/Makefile             | 13 +++++++++----
>  examples/qos_sched/Makefile             | 13 +++++++++----
>  examples/rxtx_callbacks/Makefile        | 13 +++++++++----
>  examples/service_cores/Makefile         | 13 +++++++++----
>  examples/skeleton/Makefile              | 13 +++++++++----
>  examples/tep_termination/Makefile       | 13 +++++++++----
>  examples/timer/Makefile                 | 13 +++++++++----
>  examples/vhost/Makefile                 | 13 +++++++++----
>  examples/vhost_scsi/Makefile            | 13 +++++++++----
>  examples/vmdq/Makefile                  | 13 +++++++++----
>  examples/vmdq_dcb/Makefile              | 13 +++++++++----
>  40 files changed, 360 insertions(+), 160 deletions(-)
>=20
> diff --git a/examples/bbdev_app/Makefile
> b/examples/bbdev_app/Makefile
> index e8115b46a..603932ace 100644
> --- a/examples/bbdev_app/Makefile
> +++ b/examples/bbdev_app/Makefile
> @@ -18,10 +18,15 @@ shared: build/$(APP)-shared
>  static: build/$(APP)-static
>         ln -sf $(APP)-static build/$(APP)
> =20
> -PC_FILE :=3D $(shell pkg-config --path libdpdk)
> -CFLAGS +=3D -O3 $(shell pkg-config --cflags libdpdk)
> -LDFLAGS_SHARED =3D $(shell pkg-config --libs libdpdk)
> -LDFLAGS_STATIC =3D -Wl,-Bstatic $(shell pkg-config --static --libs
> libdpdk)
> +PKGCONF=3Dpkg-config
> +ifneq ($(DPDK_PC_PREFIX),)
> +       PKGCONF +=3D --define-variable=3Dprefix=3D$(DPDK_PC_PREFIX)
> +endif
> +
> +PC_FILE :=3D $(shell $(PKGCONF) --path libdpdk)
> +CFLAGS +=3D -O3 $(shell $(PKGCONF) --cflags libdpdk)
> +LDFLAGS_SHARED =3D $(shell $(PKGCONF) --libs libdpdk)
> +LDFLAGS_STATIC =3D -Wl,-Bstatic $(shell $(PKGCONF) --static --libs
> libdpdk)
> =20
>  CFLAGS +=3D -DALLOW_EXPERIMENTAL_API

Hi,

Would using "--define-prefix" allow to avoid the special-sauced
DPDK_PC_PREFIX variable?

--=20
Kind regards,
Luca Boccassi