From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 09CBB2BD5 for ; Thu, 9 May 2019 03:11:40 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id x15so246891pln.9 for ; Wed, 08 May 2019 18:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IuxToydesiXKfohRPBW5gE/sY3c9ihm1az/iNJsMQ0c=; b=cCbIWB0stSL4WOeU7/W55N3Ps3uqpBgydkH1tP0GbX5oYZ3OaDHSZs0jj5aYFOhmlt JVgRuMm2gxIyPFSYnrH2GjPY+dgIjB8zNhH/AeC95/u4dIyA9Lo0gS9nBN6fm55DIjW0 +7kG7fiXg6tanRX0uR1JxO7NhEqKzLQoo38aPAR2DDz+aR4+2f+AfGlak5zlzKKdgX1n 8QWEcOywh4Tn5JQb4Qtt5Iz9kO7hvK3UmFLby0x1qdqgwk+jPKoNtR3Iliy069okMSQj 7hxTPfS6z6GSJ0XJ0qYLryzGfAsQsIbFB2wn62noLg/g1nDQUx96iGuRpaL1X10Xt+Jj K3zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IuxToydesiXKfohRPBW5gE/sY3c9ihm1az/iNJsMQ0c=; b=RQfV0vaSojB1r5ra2sd04s/uRRs0ebc37vy1/a0oRNhRcdCfa8NWM7Q4Nte53kCoQ9 2QUbHfHISGQiRFzfAIp5cASsR0ZzZVwNk4A4nY6NLWzcR9IQeIEUI/1dCE8nzi/bTrxw fqLhFGV0GCY6p1eFLZCCxemylX/6cl98ErPe6C6fD1w5RAjrOx57X9l+r7D+PeoFyTS8 88ywZl8wj/xUBLeH01O/b5K3/+rPBil3q+n1EtvlJveO5wpH7Xn7mYFnDq546W8PUizu h2Br3dv6D5KFTrB8JPeME9p9/CIG/swc/0MPzHwCjdecMa9nA/F4M/PAnEnUFWFjLRum keTQ== X-Gm-Message-State: APjAAAVYnD1k3wz9ZaAdI0FApKBrqn8Nj8e45WEdCyQhyd/mpJUeQP53 ywqUCeEqGk97Rb3hW+9NLub9aA== X-Google-Smtp-Source: APXvYqz92xF4b6l2jMz6SE/XXo5JBa5gNI7mu3g1uBl5y+qixqriFzl0VgNiB/Ug6BltedHCW0ECIA== X-Received: by 2002:a17:902:42a5:: with SMTP id h34mr1292018pld.146.1557364299218; Wed, 08 May 2019 18:11:39 -0700 (PDT) Received: from xps13 ([167.220.105.181]) by smtp.gmail.com with ESMTPSA id h6sm612401pfk.188.2019.05.08.18.11.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 May 2019 18:11:39 -0700 (PDT) Date: Wed, 8 May 2019 18:11:37 -0700 From: Stephen Hemminger To: Erik Gabriel Carrillo Cc: thomas@monjalon.net, anatoly.burakov@intel.com, dev@dpdk.org Message-ID: <20190508181137.04112fd4@xps13> In-Reply-To: <1557355686-4216-1-git-send-email-erik.g.carrillo@intel.com> References: <1557355686-4216-1-git-send-email-erik.g.carrillo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 01:11:40 -0000 On Wed, 8 May 2019 17:48:06 -0500 Erik Gabriel Carrillo wrote: > Due to an upcoming fix to allow the timer library to safely free its > allocations during the finalize() call[1], an ABI change will be > required. A new lock will be added to the rte_mem_config structure, > which will be used by the timer library to synchronize init/finalize > calls among multiple processes. > > [1] http://patches.dpdk.org/patch/53334/ > > Signed-off-by: Erik Gabriel Carrillo > --- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index b47c8c2..7551383 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -31,6 +31,10 @@ Deprecation Notices > > + ``rte_eal_devargs_type_count`` > > +* eal: the ``rte_mem_config`` struct will change to include a new lock that > + will allow the timer subsystem to safely release its allocations at cleanup > + time. This will result in an ABI break. > + > * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which > have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap`` > functions. The due date for the removal targets DPDK 20.02. NAK Please go to the effort of making rte_mem_config not part of the visible ABI. Then change it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DD545A0096 for ; Thu, 9 May 2019 03:11:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB91E374C; Thu, 9 May 2019 03:11:41 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 09CBB2BD5 for ; Thu, 9 May 2019 03:11:40 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id x15so246891pln.9 for ; Wed, 08 May 2019 18:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IuxToydesiXKfohRPBW5gE/sY3c9ihm1az/iNJsMQ0c=; b=cCbIWB0stSL4WOeU7/W55N3Ps3uqpBgydkH1tP0GbX5oYZ3OaDHSZs0jj5aYFOhmlt JVgRuMm2gxIyPFSYnrH2GjPY+dgIjB8zNhH/AeC95/u4dIyA9Lo0gS9nBN6fm55DIjW0 +7kG7fiXg6tanRX0uR1JxO7NhEqKzLQoo38aPAR2DDz+aR4+2f+AfGlak5zlzKKdgX1n 8QWEcOywh4Tn5JQb4Qtt5Iz9kO7hvK3UmFLby0x1qdqgwk+jPKoNtR3Iliy069okMSQj 7hxTPfS6z6GSJ0XJ0qYLryzGfAsQsIbFB2wn62noLg/g1nDQUx96iGuRpaL1X10Xt+Jj K3zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IuxToydesiXKfohRPBW5gE/sY3c9ihm1az/iNJsMQ0c=; b=RQfV0vaSojB1r5ra2sd04s/uRRs0ebc37vy1/a0oRNhRcdCfa8NWM7Q4Nte53kCoQ9 2QUbHfHISGQiRFzfAIp5cASsR0ZzZVwNk4A4nY6NLWzcR9IQeIEUI/1dCE8nzi/bTrxw fqLhFGV0GCY6p1eFLZCCxemylX/6cl98ErPe6C6fD1w5RAjrOx57X9l+r7D+PeoFyTS8 88ywZl8wj/xUBLeH01O/b5K3/+rPBil3q+n1EtvlJveO5wpH7Xn7mYFnDq546W8PUizu h2Br3dv6D5KFTrB8JPeME9p9/CIG/swc/0MPzHwCjdecMa9nA/F4M/PAnEnUFWFjLRum keTQ== X-Gm-Message-State: APjAAAVYnD1k3wz9ZaAdI0FApKBrqn8Nj8e45WEdCyQhyd/mpJUeQP53 ywqUCeEqGk97Rb3hW+9NLub9aA== X-Google-Smtp-Source: APXvYqz92xF4b6l2jMz6SE/XXo5JBa5gNI7mu3g1uBl5y+qixqriFzl0VgNiB/Ug6BltedHCW0ECIA== X-Received: by 2002:a17:902:42a5:: with SMTP id h34mr1292018pld.146.1557364299218; Wed, 08 May 2019 18:11:39 -0700 (PDT) Received: from xps13 ([167.220.105.181]) by smtp.gmail.com with ESMTPSA id h6sm612401pfk.188.2019.05.08.18.11.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 May 2019 18:11:39 -0700 (PDT) Date: Wed, 8 May 2019 18:11:37 -0700 From: Stephen Hemminger To: Erik Gabriel Carrillo Cc: thomas@monjalon.net, anatoly.burakov@intel.com, dev@dpdk.org Message-ID: <20190508181137.04112fd4@xps13> In-Reply-To: <1557355686-4216-1-git-send-email-erik.g.carrillo@intel.com> References: <1557355686-4216-1-git-send-email-erik.g.carrillo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509011137.BEplxT_RWtNMMrRlPK65cRmj14lztGP6zx-IlMV_Ql0@z> On Wed, 8 May 2019 17:48:06 -0500 Erik Gabriel Carrillo wrote: > Due to an upcoming fix to allow the timer library to safely free its > allocations during the finalize() call[1], an ABI change will be > required. A new lock will be added to the rte_mem_config structure, > which will be used by the timer library to synchronize init/finalize > calls among multiple processes. > > [1] http://patches.dpdk.org/patch/53334/ > > Signed-off-by: Erik Gabriel Carrillo > --- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index b47c8c2..7551383 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -31,6 +31,10 @@ Deprecation Notices > > + ``rte_eal_devargs_type_count`` > > +* eal: the ``rte_mem_config`` struct will change to include a new lock that > + will allow the timer subsystem to safely release its allocations at cleanup > + time. This will result in an ABI break. > + > * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which > have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap`` > functions. The due date for the removal targets DPDK 20.02. NAK Please go to the effort of making rte_mem_config not part of the visible ABI. Then change it.