From: Jack Min <jackmin@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH] net/mlx5: match on TCP flags via DV/DR engine
Date: Thu, 9 May 2019 06:11:09 +0000 [thread overview]
Message-ID: <20190509061053.181091-1-jackmin@mellanox.com> (raw)
Add support to match all TCP control bits (flags)
except "NS (ECN-nonce)" via Direct Verbs (DV) or Direct Rule (DR)
engine.
Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index cf255ca95c..44b4f40404 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -2066,6 +2066,12 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
uint64_t last_item = 0;
uint8_t next_protocol = 0xff;
int actions_n = 0;
+ struct rte_flow_item_tcp nic_tcp_mask = {
+ .hdr = { .tcp_flags = 0xFF,
+ .src_port = RTE_BE16(UINT16_MAX),
+ .dst_port = RTE_BE16(UINT16_MAX),
+ }
+ };
if (items == NULL)
return -1;
@@ -2146,7 +2152,7 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
ret = mlx5_flow_validate_item_tcp
(items, item_flags,
next_protocol,
- &rte_flow_item_tcp_mask,
+ &nic_tcp_mask,
error);
if (ret < 0)
return ret;
@@ -2862,6 +2868,10 @@ flow_dv_translate_item_tcp(void *matcher, void *key,
rte_be_to_cpu_16(tcp_m->hdr.dst_port));
MLX5_SET(fte_match_set_lyr_2_4, headers_v, tcp_dport,
rte_be_to_cpu_16(tcp_v->hdr.dst_port & tcp_m->hdr.dst_port));
+ MLX5_SET(fte_match_set_lyr_2_4, headers_m, tcp_flags,
+ tcp_m->hdr.tcp_flags);
+ MLX5_SET(fte_match_set_lyr_2_4, headers_v, tcp_flags,
+ (tcp_v->hdr.tcp_flags & tcp_m->hdr.tcp_flags));
}
/**
--
2.20.1
WARNING: multiple messages have this Message-ID
From: Shahaf Shuler <shahafs@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Jack Min <jackmin@mellanox.com>
Subject: [dpdk-dev] [PATCH] net/mlx5: match on TCP flags via DV/DR engine
Date: Sun, 26 May 2019 19:20:53 +0000 [thread overview]
Message-ID: <20190509061053.181091-1-jackmin@mellanox.com> (raw)
Message-ID: <20190526192053.gi7TM9Vb7IKhi5Uy4bfEdtvT0W_iaxPpw2YHEzmR1Nc@z> (raw)
From: Jack Min <jackmin@mellanox.com>
>Add support to match all TCP control bits (flags)
>except "NS (ECN-nonce)" via Direct Verbs (DV) or Direct Rule (DR)
>engine.
>
>Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
>Acked-by: Ori Kam <orika@mellanox.com>
Applied to next-net-mlx, with few points to address:
1. Your author name is not the same as your signed-of name. please take
care.
2. fixed some identation issues
3. modifed the title. please have a look.
thanks.
>---
> drivers/net/mlx5/mlx5_flow_dv.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
>index cf255ca95c..44b4f40404 100644
>--- a/drivers/net/mlx5/mlx5_flow_dv.c
>+++ b/drivers/net/mlx5/mlx5_flow_dv.c
>@@ -2066,6 +2066,12 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
> uint64_t last_item = 0;
> uint8_t next_protocol = 0xff;
> int actions_n = 0;
>+ struct rte_flow_item_tcp nic_tcp_mask = {
>+ .hdr = { .tcp_flags = 0xFF,
>+ .src_port = RTE_BE16(UINT16_MAX),
>+ .dst_port = RTE_BE16(UINT16_MAX),
>+ }
>+ };
>
> if (items == NULL)
> return -1;
>@@ -2146,7 +2152,7 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
> ret = mlx5_flow_validate_item_tcp
> (items, item_flags,
> next_protocol,
>- &rte_flow_item_tcp_mask,
>+ &nic_tcp_mask,
> error);
> if (ret < 0)
> return ret;
>@@ -2862,6 +2868,10 @@ flow_dv_translate_item_tcp(void *matcher, void *key,
> rte_be_to_cpu_16(tcp_m->hdr.dst_port));
> MLX5_SET(fte_match_set_lyr_2_4, headers_v, tcp_dport,
> rte_be_to_cpu_16(tcp_v->hdr.dst_port & tcp_m->hdr.dst_port));
>+ MLX5_SET(fte_match_set_lyr_2_4, headers_m, tcp_flags,
>+ tcp_m->hdr.tcp_flags);
>+ MLX5_SET(fte_match_set_lyr_2_4, headers_v, tcp_flags,
>+ (tcp_v->hdr.tcp_flags & tcp_m->hdr.tcp_flags));
> }
>
> /**
next reply other threads:[~2019-05-09 6:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 6:11 Jack Min [this message]
2019-05-09 6:11 ` Jack Min
2019-05-12 6:27 ` Ori Kam
2019-05-12 6:27 ` Ori Kam
2019-05-26 19:20 ` Shahaf Shuler
2019-05-27 2:35 ` Jack Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509061053.181091-1-jackmin@mellanox.com \
--to=jackmin@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).