From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 085C4DE3; Thu, 9 May 2019 15:29:08 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E969306D332; Thu, 9 May 2019 13:29:07 +0000 (UTC) Received: from localhost (dhcp-192-206.str.redhat.com [10.33.192.206]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D4A2760BF3; Thu, 9 May 2019 13:29:02 +0000 (UTC) Date: Thu, 9 May 2019 15:29:01 +0200 From: Jens Freimann To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Maxime Coquelin , Tiwei Bie , Zhihong Wang Message-ID: <20190509132901.nvcvz374pi53mnip@jenstp.localdomain> References: <1557389028-2462-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1557389028-2462-1-git-send-email-david.marchand@redhat.com> User-Agent: NeoMutt/20180716-1376-5d6ed1 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 09 May 2019 13:29:07 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio: remove useless check on mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 13:29:08 -0000 On Thu, May 09, 2019 at 10:03:48AM +0200, David Marchand wrote: >This .rx_queue_setup devop is called after ethdev already dereferenced >the mempool pointer. >No need to check and we can remove this rte_exit. > >Fixes: 48cec290a3d2 ("net/virtio: move queue configure code to proper place") >Cc: stable@dpdk.org > >Signed-off-by: David Marchand Agree, the pointer is accessed before in the caller. That said, afaics the pointer is never checked in rte_eth_rx_queue_setup() before it's dereferenced... Reviewed-by: Jens Freimann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4A133A0096 for ; Thu, 9 May 2019 15:29:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3678F3977; Thu, 9 May 2019 15:29:09 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 085C4DE3; Thu, 9 May 2019 15:29:08 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E969306D332; Thu, 9 May 2019 13:29:07 +0000 (UTC) Received: from localhost (dhcp-192-206.str.redhat.com [10.33.192.206]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D4A2760BF3; Thu, 9 May 2019 13:29:02 +0000 (UTC) Date: Thu, 9 May 2019 15:29:01 +0200 From: Jens Freimann To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Maxime Coquelin , Tiwei Bie , Zhihong Wang Message-ID: <20190509132901.nvcvz374pi53mnip@jenstp.localdomain> References: <1557389028-2462-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Disposition: inline In-Reply-To: <1557389028-2462-1-git-send-email-david.marchand@redhat.com> User-Agent: NeoMutt/20180716-1376-5d6ed1 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 09 May 2019 13:29:07 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio: remove useless check on mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509132901.LWp-fITMhGDXfHxrZ-4IIfT7E0PzfwOHgvRMCzbzEKo@z> On Thu, May 09, 2019 at 10:03:48AM +0200, David Marchand wrote: >This .rx_queue_setup devop is called after ethdev already dereferenced >the mempool pointer. >No need to check and we can remove this rte_exit. > >Fixes: 48cec290a3d2 ("net/virtio: move queue configure code to proper place") >Cc: stable@dpdk.org > >Signed-off-by: David Marchand Agree, the pointer is accessed before in the caller. That said, afaics the pointer is never checked in rte_eth_rx_queue_setup() before it's dereferenced... Reviewed-by: Jens Freimann