From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 99D62A0096 for <public@inbox.dpdk.org>; Thu, 9 May 2019 23:54:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B9F34C6C; Thu, 9 May 2019 23:54:05 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 51D4E49DF for <dev@dpdk.org>; Thu, 9 May 2019 23:54:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EC69324094; Thu, 9 May 2019 17:54:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 May 2019 17:54:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=7jHEYUM534IyRMLlPjfgWqVoMWeFe9wH/trSmDFvhfc=; b=lFNzK8gGUzS8 HY5yu/igJX65SLG7oEIa5SeB0gKM5H9YdzZ6EeFYZlPFzPfadaAYJ1JomCwIvFfc o1rsLUUgHfHSf1tpYElrRsXppshbAvaR+CtAwA9LU1wkEGJpBOEUGObUcWdRKLd3 nhF7ThGgemuwcCGvvOZtT75ZEJOx1NI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=7jHEYUM534IyRMLlPjfgWqVoMWeFe9wH/trSmDFvh fc=; b=suQArVSwM+zJBPcTnpGBgHaLM7ctDNHriyrQ0kqs9F6J+8Y1VHyFOz4eu MPubWUDeO1eDK9ljMfCjbOFTs4beF6kV2lGXI0iiGSkZNdxwifhoMBfnWi3bTrti S0sFW4S6wvXssHRVXDR4uSLhD6wc9dWfMlhahNjg0DqZMQiSh5jVOxo6Xjl1jUYU TxKSmwRlNyuSE3ROHReUYqbOPE6fzhqsw3ZGlkaLc5qnQoEGA+K0VKe52EPgNwk6 rl3Dc7anxDqgL7Yeo8U7MPKsfIFsJS2V++H714DEqKr30UF/RybYInp2TUdhTtpW xzl4LEwfqVtASdMy+8G4gIH/O5ZVw== X-ME-Sender: <xms:eqHUXKeqlXCDhnVk3jSU3CBML6eBgrJb4QH4QA8SjE0anu8CKUKCbQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:eqHUXJLFfYUumCHLWr5bwTRj6IE4uSR015pyJ_TMWUkYU4BNIPcgYQ> <xmx:eqHUXDpeqi7bE-8iOGM7ta2pjov2xbtJhwiExXycKsj1jhWewLLn6Q> <xmx:eqHUXIawY2JU-fyihSArH0VpHRKpBOD0hEyNWNQGP8dfVgw-Z07Uhw> <xmx:eqHUXOk2ox5ObjkFcj-8Hchh_4S__OxLLxEwm-98l_oPGstX7MSsTA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 79E5E80061; Thu, 9 May 2019 17:54:01 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: David Marchand <david.marchand@redhat.com> Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Thu, 09 May 2019 23:54:00 +0200 Message-ID: <2117699.YQSt9e6Vg7@xps> In-Reply-To: <1553260606-28325-1-git-send-email-david.marchand@redhat.com> References: <1553260606-28325-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] devtools: select patches to check with git range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190509215400.sqGqqrNDmOJtzWmAzKYQHohUXYu3MMsoKToH-Sfy1QE@z> 22/03/2019 14:16, David Marchand: > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > - usage: $(basename $0) [-q] [-v] [-nX|patch1 [patch2] ...]] > + usage: $(basename $0) [-q] [-v] [-nX|patch1 [patch2] ...]] [-r range] The option -r should be before the filename arguments, and inside the same brackets as -n as they are exclusive. (je clair ne pas ;) > The patches to check can be from stdin, files specified on the command line, > - or latest git commits limited with -n option (default limit: origin/master). > + or latest git commits limited with -n option or commits in the range > + specified with -r option (default: origin/master..). I suggest this reword: The patches to check can be from stdin, files specified on the command line, latest git commits limited with -n option, or commits in the git range specified with -r option (default: "origin/master.."). [...] > if [ $number -eq 0 ] ; then > - commits=$(git rev-list --reverse origin/master..) > + commits=$(git rev-list --reverse $range) > else > commits=$(git rev-list --reverse --max-count=$number HEAD) > fi Looks good and very useful, thanks :)