From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4EF88A0096 for ; Fri, 10 May 2019 00:05:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DCA64C6C; Fri, 10 May 2019 00:05:30 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3831E3977 for ; Fri, 10 May 2019 00:05:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B76DB24417; Thu, 9 May 2019 18:05:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 May 2019 18:05:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=+XsOmWFbM5+uvbP1feImnjBjPr04VHvCM8cJqWpRqE8=; b=DWpcPXpSeLOd AfeHAEFs0VYlmj/Wf7jKUhA2RBt3hB2HaVipGdpZZMKV2Ojzux2Ou8h2cJE6JW9H TNFVPZ5hPMlgAHwXbIkP0PNv0Pu70bjKsZ6m3L2+iWhiCGwjGIlqS0LT12JPu6OG qQFsquNUqk1mdZdMNwXXgydY2yb1Jvw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=+XsOmWFbM5+uvbP1feImnjBjPr04VHvCM8cJqWpRq E8=; b=Wedt7Sr6ZE76uiKF6z5+rdoia0TVPuBo2dopG6ZntYSyI5JoOV32Gj132 QdUJBXwRtnBifVzHZYa4UW3OTvmxhsHQbefS+rpwr4neyflEDVG9/nCTMlsNOGl/ 3GzKPXkWFQIrrdTi1uSycv94I+ly6BjPzWpYD1GqjQyqrIiq0Xc+FW5qSwb2wxeD /HEb4yDw7Heeu14yM9ukiPXFsFv6e/UYeEoZrdnJn/K7PJv+NuejO/MbCJwrQqHZ lH0ESU99vxQ9e0r4BCzdkvKRFzHUj5w5mzaZRDs2rJ2nVH27Y7kn0tcn58N+/3SX Hop/KOHMumWqMbIoULgck9cku0JSw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AAC1B8005C; Thu, 9 May 2019 18:05:26 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Fri, 10 May 2019 00:05:25 +0200 Message-ID: <2845816.AoUcc6ncKd@xps> In-Reply-To: <2117699.YQSt9e6Vg7@xps> References: <1553260606-28325-1-git-send-email-david.marchand@redhat.com> <2117699.YQSt9e6Vg7@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] devtools: select patches to check with git range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509220525.dRd9IaPaMm2ar14jkPPDKLZ9TOo3z3Mzwm_TRPhL9Z8@z> 09/05/2019 23:54, Thomas Monjalon: > 22/03/2019 14:16, David Marchand: > > --- a/devtools/checkpatches.sh > > +++ b/devtools/checkpatches.sh > > - usage: $(basename $0) [-q] [-v] [-nX|patch1 [patch2] ...]] > > + usage: $(basename $0) [-q] [-v] [-nX|patch1 [patch2] ...]] [-r range] > > The option -r should be before the filename arguments, > and inside the same brackets as -n as they are exclusive. > (je clair ne pas ;) > > > The patches to check can be from stdin, files specified on the command line, > > - or latest git commits limited with -n option (default limit: origin/master). > > + or latest git commits limited with -n option or commits in the range > > + specified with -r option (default: origin/master..). > > I suggest this reword: > > The patches to check can be from stdin, files specified on the command line, > latest git commits limited with -n option, or commits in the git range > specified with -r option (default: "origin/master.."). > > [...] > > if [ $number -eq 0 ] ; then > > - commits=$(git rev-list --reverse origin/master..) > > + commits=$(git rev-list --reverse $range) > > else > > commits=$(git rev-list --reverse --max-count=$number HEAD) > > fi > > Looks good and very useful, thanks :) I'm sure I'll find this new option quite useful, so please add my agreement: Acked-by: Thomas Monjalon