DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Vipin Varghese <vipin.varghese@intel.com>
Cc: dev@dpdk.org, marko.kovacevic@intel.com, john.mcnamara@intel.com,
	wenzhuo.lu@intel.com, jingjing.wu@intel.com,
	bernard.iremonger@intel.com, sanjay.padubidri@intel.com,
	konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [PATCH] doc/testpmd: update compile steps for bpf examples
Date: Fri, 10 May 2019 00:31:42 +0200	[thread overview]
Message-ID: <67739198.mN8PHIGBQv@xps> (raw)
Message-ID: <20190509223142.4F7zEttk2P_DEZAizhbnJSTt_1Ta4QmMtsH23DtE_y0@z> (raw)
In-Reply-To: <20190507084112.35296-1-vipin.varghese@intel.com>

07/05/2019 10:41, Vipin Varghese:
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -4657,6 +4657,10 @@ To load (not JITed) t1.o at TX queue 0, port 0::
>  
>     testpmd> bpf-load tx 0 0 - ./dpdk.org/examples/bpf/t1.o
>  
> +.. note::
> +
> +   In order to build t2.c and t3.c; pass DPDK target's include and library path as compiler options.

This note should be below the compilation command.
When adding more BPF examples, it will be easily outdated.
We could say "to build other examples, more arguments may be required".
About the compiler options, I suggest to name them: -I, -L?




  parent reply	other threads:[~2019-05-09 22:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07  8:41 Vipin Varghese
2019-05-07  8:41 ` Vipin Varghese
2019-05-07 15:07 ` Mcnamara, John
2019-05-07 15:07   ` Mcnamara, John
2019-05-09 22:31 ` Thomas Monjalon [this message]
2019-05-09 22:31   ` Thomas Monjalon
2019-05-10  1:41   ` Varghese, Vipin
2019-05-10  1:41     ` Varghese, Vipin
2019-05-23 13:47 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2019-05-29 11:17   ` Thomas Monjalon
2019-05-30 15:40     ` Varghese, Vipin
2019-06-10  5:41   ` [dpdk-dev] [PATCH v3] " Vipin Varghese
2023-06-12 16:31     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67739198.mN8PHIGBQv@xps \
    --to=thomas@monjalon.net \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=sanjay.padubidri@intel.com \
    --cc=vipin.varghese@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).