From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F1E6FA0096 for ; Fri, 10 May 2019 11:34:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8E795699; Fri, 10 May 2019 11:34:09 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 862E5568A for ; Fri, 10 May 2019 11:34:08 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 02:34:07 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.96]) by fmsmga004.fm.intel.com with SMTP; 10 May 2019 02:34:05 -0700 Received: by (sSMTP sendmail emulation); Fri, 10 May 2019 10:34:04 +0100 Date: Fri, 10 May 2019 10:34:04 +0100 From: Bruce Richardson To: "Burakov, Anatoly" Cc: Erik Gabriel Carrillo , thomas@monjalon.net, stephen@networkplumber.org, david.marchand@redhat.com, mdr@ashroe.eu, dev@dpdk.org Message-ID: <20190510093404.GC76@bricha3-MOBL.ger.corp.intel.com> References: <1557355686-4216-1-git-send-email-erik.g.carrillo@intel.com> <1557427905-13766-1-git-send-email-erik.g.carrillo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice on EAL mem config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190510093404.b7beqDfD7cxAwvAtxczXdV_kY0w_UokzsVBIbjl5tZA@z> On Fri, May 10, 2019 at 10:31:21AM +0100, Burakov, Anatoly wrote: > On 09-May-19 7:51 PM, Erik Gabriel Carrillo wrote: > > It is planned to make the rte_mem_config struct of the EAL private to > > remove it from the visible ABI. Add a notice to announce the intention. > > > > Signed-off-by: Erik Gabriel Carrillo > > --- > > changes in v2: > > - Original deprecation notice announced a change to the rte_mem_config > > struct that would break ABI. Update the notice to instead announce > > the struct will be made private. (Stephen, Anatoly, David) > > > > doc/guides/rel_notes/deprecation.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index b47c8c2..a7dff6b 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -31,6 +31,9 @@ Deprecation Notices > > + ``rte_eal_devargs_type_count`` > > +* eal: the ``rte_mem_config`` struct will be made private to remove it from the > > + externally visible ABI and allow it to be updated in the future. > > + > > * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which > > have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap`` > > functions. The due date for the removal targets DPDK 20.02. > > > > Acked-by: Anatoly Burakov > Acked-by: Bruce Richardson