DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] event/dsw: ignore scheduling type for single-link queues
@ 2019-05-10  9:47 Mattias Rönnblom
  2019-05-10  9:47 ` Mattias Rönnblom
  2019-05-10  9:53 ` Mattias Rönnblom
  0 siblings, 2 replies; 10+ messages in thread
From: Mattias Rönnblom @ 2019-05-10  9:47 UTC (permalink / raw)
  To: dev; +Cc: Jerin Jacob, stefan.sundkvist, Mattias Rönnblom

The scheduling type parameter is not applicable for single link
queues. DSW would, at the time of rte_event_queue_setup(), erroneously
verify that scheduling type was one of the supported types, and
returned -ENOTSUP in case of RTE_SCHED_TYPE_ORDERED.

Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
 drivers/event/dsw/dsw_evdev.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index 4157d130c..9387d4149 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -102,9 +102,6 @@ dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id,
 	if (RTE_EVENT_QUEUE_CFG_ALL_TYPES & conf->event_queue_cfg)
 		return -ENOTSUP;
 
-	if (conf->schedule_type == RTE_SCHED_TYPE_ORDERED)
-		return -ENOTSUP;
-
 	/* SINGLE_LINK is better off treated as TYPE_ATOMIC, since it
 	 * avoid the "fake" TYPE_PARALLEL flow_id assignment. Since
 	 * the queue will only have a single serving port, no
@@ -113,8 +110,12 @@ dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id,
 	 */
 	if (RTE_EVENT_QUEUE_CFG_SINGLE_LINK & conf->event_queue_cfg)
 		queue->schedule_type = RTE_SCHED_TYPE_ATOMIC;
-	else /* atomic or parallel */
+	else {
+		if (conf->schedule_type == RTE_SCHED_TYPE_ORDERED)
+			return -ENOTSUP;
+		/* atomic or parallel */
 		queue->schedule_type = conf->schedule_type;
+	}
 
 	queue->num_serving_ports = 0;
 
-- 
2.17.1

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] event/dsw: ignore scheduling type for single-link queues
@ 2019-05-10 16:55 Eads, Gage
  2019-05-10 16:55 ` Eads, Gage
  0 siblings, 1 reply; 10+ messages in thread
From: Eads, Gage @ 2019-05-10 16:55 UTC (permalink / raw)
  To: dev; +Cc: jerin.jacob, Stefan Sundkvist, stable, Mattias Rönnblom

> The scheduling type parameter is not applicable for single link

> queues. DSW would, at the time of rte_event_queue_setup(), erroneously

> verify that scheduling type was one of the supported types, and

> returned -ENOTSUP in case of RTE_SCHED_TYPE_ORDERED.

>

> Fixes: 4540ee9c68 ("event/dsw: add device and queue configuration")

> Cc: stable@dpdk.org<mailto:stable@dpdk.org>

>

> Signed-off-by: Mattias Ronnblom <mattias.ronnblom@ericsson.com<mailto:mattias.ronnblom@ericsson.com>>

Acked-by: Gage Eads <gage.eads@intel.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-05-10 16:55 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-10  9:47 [dpdk-dev] [PATCH] event/dsw: ignore scheduling type for single-link queues Mattias Rönnblom
2019-05-10  9:47 ` Mattias Rönnblom
2019-05-10  9:53 ` Mattias Rönnblom
2019-05-10  9:53   ` Mattias Rönnblom
2019-05-10 10:26   ` Kevin Traynor
2019-05-10 10:26     ` Kevin Traynor
2019-05-10 12:18     ` [dpdk-dev] [PATCH v2] " Mattias Rönnblom
2019-05-10 12:18       ` Mattias Rönnblom
2019-05-10 16:55 Eads, Gage
2019-05-10 16:55 ` Eads, Gage

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).