DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Stephen Hemminger <stephen@networkplumber.org>,
	 "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	 Ray Kinsella <mdr@ashroe.eu>, dev <dev@dpdk.org>,
	mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com,
	evgenys@amazon.com
Subject: Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice on EAL mem config
Date: Fri, 10 May 2019 15:44:13 +0200	[thread overview]
Message-ID: <CAJFAV8zu21625Cpp-c0Q_-c2G0Cs6i3OWa6H3fW+tg2GpxpwOw@mail.gmail.com> (raw)
Message-ID: <20190510134413.UQk6iHb0mVBcMkeGq3OtnvETELQ2orW96LKncaz0H4c@z> (raw)
In-Reply-To: <1557427905-13766-1-git-send-email-erik.g.carrillo@intel.com>

On Thu, May 9, 2019 at 8:53 PM Erik Gabriel Carrillo <
erik.g.carrillo@intel.com> wrote:

> It is planned to make the rte_mem_config struct of the EAL private to
> remove it from the visible ABI.  Add a notice to announce the intention.
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> changes in v2:
>  - Original deprecation notice announced a change to the rte_mem_config
>    struct that would break ABI.  Update the notice to instead announce
>    the struct will be made private.  (Stephen, Anatoly, David)
>
>  doc/guides/rel_notes/deprecation.rst | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index b47c8c2..a7dff6b 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -31,6 +31,9 @@ Deprecation Notices
>
>      + ``rte_eal_devargs_type_count``
>
> +* eal: the ``rte_mem_config`` struct will be made private to remove it
> from the
> +  externally visible ABI and allow it to be updated in the future.
> +
>  * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs
> which
>    have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``
>    functions.  The due date for the removal targets DPDK 20.02.
> --
> 2.6.4
>
>
I had a look at the current callers, trying to see what "hiding" means.

$ git grep -Elw '(rte_mem_config|mem_config)' origin/master --
origin/master:app/test/test_memzone.c
origin/master:doc/guides/rel_notes/release_18_11.rst
origin/master:drivers/bus/fslmc/fslmc_vfio.c
origin/master:drivers/net/ena/ena_ethdev.c
origin/master:drivers/net/mlx4/mlx4_mr.c
origin/master:drivers/net/mlx5/mlx5_mr.c
origin/master:drivers/net/virtio/virtio_user/virtio_user_dev.c
origin/master:lib/librte_eal/common/eal_common_memory.c
origin/master:lib/librte_eal/common/eal_common_memzone.c
origin/master:lib/librte_eal/common/eal_common_tailqs.c
origin/master:lib/librte_eal/common/include/rte_eal.h
origin/master:lib/librte_eal/common/include/rte_eal_memconfig.h
origin/master:lib/librte_eal/common/malloc_heap.c
origin/master:lib/librte_eal/common/rte_malloc.c
origin/master:lib/librte_eal/freebsd/eal/eal.c
origin/master:lib/librte_eal/freebsd/eal/eal_memory.c
origin/master:lib/librte_eal/linux/eal/eal.c
origin/master:lib/librte_eal/linux/eal/eal_memalloc.c
origin/master:lib/librte_eal/linux/eal/eal_memory.c
origin/master:lib/librte_eal/linux/eal/eal_vfio.c

- I understand that the following drivers will need a new lock/unlock api
to protect calls to the memory api.
drivers/bus/fslmc/fslmc_vfio.c
drivers/net/mlx4/mlx4_mr.c
drivers/net/mlx5/mlx5_mr.c
drivers/net/virtio/virtio_user/virtio_user_dev.c

- I have a little trouble with this one, so there might be a new api for
this driver usecase.
A discussion will have to happen with its maintainers (added in CC:).
drivers/net/ena/ena_ethdev.c


Apart from this, I am ok with the objective, which is to hide one more eal
internal structure.

Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand

  parent reply	other threads:[~2019-05-10 13:44 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 22:48 [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup Erik Gabriel Carrillo
2019-05-08 22:48 ` Erik Gabriel Carrillo
2019-05-09  1:11 ` Stephen Hemminger
2019-05-09  1:11   ` Stephen Hemminger
2019-05-09  7:05   ` David Marchand
2019-05-09  7:05     ` David Marchand
2019-05-09  8:33     ` Burakov, Anatoly
2019-05-09  8:33       ` Burakov, Anatoly
2019-05-09  9:06       ` Bruce Richardson
2019-05-09  9:06         ` Bruce Richardson
2019-05-09  9:37         ` Burakov, Anatoly
2019-05-09  9:37           ` Burakov, Anatoly
2019-05-09  9:38           ` Thomas Monjalon
2019-05-09  9:38             ` Thomas Monjalon
2019-05-09  9:50             ` Ray Kinsella
2019-05-09  9:50               ` Ray Kinsella
2019-05-09 10:08               ` Burakov, Anatoly
2019-05-09 10:08                 ` Burakov, Anatoly
2019-05-09 19:02                 ` Stephen Hemminger
2019-05-09 19:02                   ` Stephen Hemminger
2019-05-10 14:42                 ` Stephen Hemminger
2019-05-10 14:42                   ` Stephen Hemminger
2019-05-09 11:53 ` Burakov, Anatoly
2019-05-09 11:53   ` Burakov, Anatoly
2019-05-09 18:51 ` [dpdk-dev] [PATCH v2] doc: add deprecation notice on EAL mem config Erik Gabriel Carrillo
2019-05-09 18:51   ` Erik Gabriel Carrillo
2019-05-10  9:31   ` Burakov, Anatoly
2019-05-10  9:31     ` Burakov, Anatoly
2019-05-10  9:34     ` Bruce Richardson
2019-05-10  9:34       ` Bruce Richardson
2019-05-13 21:03       ` Thomas Monjalon
2019-05-13 21:03         ` Thomas Monjalon
2019-05-10 13:44   ` David Marchand [this message]
2019-05-10 13:44     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8zu21625Cpp-c0Q_-c2G0Cs6i3OWa6H3fW+tg2GpxpwOw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=evgenys@amazon.com \
    --cc=gtzalik@amazon.com \
    --cc=mdr@ashroe.eu \
    --cc=mk@semihalf.com \
    --cc=mw@semihalf.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).