DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ola Liljedahl <Ola.Liljedahl@arm.com>
To: "stephen@networkplumber.org" <stephen@networkplumber.org>,
	"gage.eads@intel.com" <gage.eads@intel.com>
Cc: "arybchenko@solarflare.com" <arybchenko@solarflare.com>,
	nd <nd@arm.com>,
	 "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
Subject: Re: [dpdk-dev] [PATCH v4] doc: announce ring API change
Date: Fri, 10 May 2019 15:19:09 +0000	[thread overview]
Message-ID: <d88b1c63a421e72d14cd1bd790f98333a6f34f33.camel@arm.com> (raw)
Message-ID: <20190510151909.pu-ZG9Pd3NwzHDmBkeNmnsuUxNXBJ6dmCjJuxmsL3hA@z> (raw)
In-Reply-To: <20190510075855.2899716e@hermes.lan>

On Fri, 2019-05-10 at 07:58 -0700, Stephen Hemminger wrote:
> On Fri, 10 May 2019 14:53:56 +0000
> "Eads, Gage" <gage.eads@intel.com> wrote:
> 
> 01/02/2019 15:36, Gage Eads:  
> In order to support the non-blocking ring[1], an API change
> (additional argument to rte_ring_get_memsize()) is required in
> librte_ring. This commit updates the deprecation notice to pave the
> way for its inclusion in 19.08.
> 
> [1] http://mails.dpdk.org/archives/dev/2019-January/124162.html
> 
> Signed-off-by: Gage Eads <gage.eads@intel.com>  
> 
> There is still no agreement on this change?
>   
> 
> Still none. I was hoping this discussion (
> http://mails.dpdk.org/archives/dev/2019-April/129229.html) would lead to some
> clear direction, but at this point the effort is stalled.
> 
> The fundamental tradeoff is between non-blocking rings and ABI breakage.

It is also possible to do "non-blocking" (but not lock-free) rings with the
original element size (a pointer per ring slot) as implemented here:
https://github.com/ARM-software/progress64/blob/master/src/p64_ringbuf.c
Some extra (head&tail) metadata is required but I think there is space for that
in the rte_ring structure.

> Why not have a new ring type for non-blocking rings since non-blocking
> rings are not necessary for all use cases.

I proposed a new library ("rte_lfring") with lock-free rings here:
https://mails.dpdk.org/archives/dev/2019-January/124242.html
The lock-free design should be the same as in Gage's patch.

rte_lfring could of course be part of the rte_ring library.


-- 
Ola Liljedahl, Networking System Architect, Arm
Phone +46706866373, Skype ola.liljedahl

  parent reply	other threads:[~2019-05-10 15:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 23:59 [dpdk-dev] [PATCH] doc: announce ring ABI and API changes Gage Eads
2019-01-16  0:34 ` Stephen Hemminger
2019-01-16 18:21   ` Eads, Gage
2019-01-18 15:28 ` [dpdk-dev] [PATCH v2] doc: announce ring API change Gage Eads
2019-01-18 15:31   ` [dpdk-dev] [PATCH v3] " Gage Eads
2019-02-01 11:16     ` Thomas Monjalon
2019-02-01 14:18       ` Eads, Gage
2019-02-01 14:36     ` [dpdk-dev] [PATCH v4] " Gage Eads
2019-05-09 23:29       ` Thomas Monjalon
2019-05-09 23:29         ` Thomas Monjalon
2019-05-10 14:53         ` Eads, Gage
2019-05-10 14:53           ` Eads, Gage
2019-05-10 14:58           ` Stephen Hemminger
2019-05-10 14:58             ` Stephen Hemminger
2019-05-10 15:19             ` Ola Liljedahl [this message]
2019-05-10 15:19               ` Ola Liljedahl
2019-05-10 16:28               ` Eads, Gage
2019-05-10 16:28                 ` Eads, Gage
2019-05-13 11:46                 ` Olivier Matz
2019-05-13 11:46                   ` Olivier Matz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d88b1c63a421e72d14cd1bd790f98333a6f34f33.camel@arm.com \
    --to=ola.liljedahl@arm.com \
    --cc=Gavin.Hu@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=nd@arm.com \
    --cc=olivier.matz@6wind.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).