From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 8113AA00E6
	for <public@inbox.dpdk.org>; Mon, 13 May 2019 14:04:07 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 539504C9D;
	Mon, 13 May 2019 14:04:07 +0200 (CEST)
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id E5A0B3253
 for <dev@dpdk.org>; Mon, 13 May 2019 14:04:05 +0200 (CEST)
Received: from lfbn-lil-1-768-100.w81-254.abo.wanadoo.fr ([81.254.99.100]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1hQ9jG-0001cg-U0; Mon, 13 May 2019 14:06:52 +0200
Received: by droids-corp.org (sSMTP sendmail emulation);
 Mon, 13 May 2019 14:04:04 +0200
Date: Mon, 13 May 2019 14:04:04 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <20190513120404.3qbngkjmmclq5uey@platinum>
References: <20181024081833.21432-1-olivier.matz@6wind.com>
 <20190410083218.17531-1-olivier.matz@6wind.com>
 <20190410083218.17531-2-olivier.matz@6wind.com>
 <20190422090327.6fef2599@hermes.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
In-Reply-To: <20190422090327.6fef2599@hermes.lan>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [RFC v2 01/14] net: add rte prefix to arp structures
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190513120404.p_ooJc7Cjqd2a3Eg2R0WcS13HE2ma_wnAnUXfORhZO8@z>

On Mon, Apr 22, 2019 at 09:03:27AM -0700, Stephen Hemminger wrote:
> On Wed, 10 Apr 2019 10:32:05 +0200
> Olivier Matz <olivier.matz@6wind.com> wrote:
> 
> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> > index f30422a6d..9c5425ef5 100644
> > --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> > @@ -489,9 +489,9 @@ uint32_t burstnumberTX;
> >  #ifdef RTE_LIBRTE_BOND_DEBUG_ALB
> >  
> >  static void
> > -arp_op_name(uint16_t arp_op, char *buf, size_t buf_len)
> > +arp_opcode_name(uint16_t arp_opcode, char *buf, size_t buf_len)
> >  {
> > -	switch (arp_op) {
> > +	switch (arp_opcode) {
> >  	case ARP_OP_REQUEST:
> >  		strlcpy(buf, "ARP Request", buf_len);
> >  		return;
> > @@ -566,7 +566,7 @@ update_cli
> 
> This is an internal function, why did it have to be renamed?

This is a mistake, thanks.

> 
> > diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h
> > index cf6ef63e3..f988e74c6 100644
> > --- a/drivers/net/i40e/base/i40e_adminq_cmd.h
> > +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h
> > @@ -458,7 +458,7 @@ struct i40e_aqc_cppm_configuration {
> >  I40E_CHECK_CMD_LENGTH(i40e_aqc_cppm_configuration);
> >  
> >  /* Set ARP Proxy command / response (indirect 0x0104) */
> > -struct i40e_aqc_arp_proxy_data {
> > +struct i40e_aqc_arp_protocolxy_data {
> >  	__le16	command_flags;
> 
> Don't change private data or function names in base code.

Right, I'll fix that too.


Thanks