From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "Olivier Matz" <olivier.matz@6wind.com>, <thomas@monjalon.net>,
<ferruh.yigit@intel.com>, <arybchenko@solarflare.com>,
<dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] librte_net: define TCP flags in rte_tcp.h instead of in rte_eth_ctrl.h
Date: Mon, 13 May 2019 07:47:08 -0700 [thread overview]
Message-ID: <20190513074708.775d0559@hermes.lan> (raw)
Message-ID: <20190513144708.-oPhQtfOiQthqnpjZ7xRMGp8cS4e-J0hrBw8vTu4hDY@z> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B42847@smartserver.smartshare.dk>
On Mon, 13 May 2019 15:02:57 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> >
> > IMHO, adding the copyright for flags move is a bit overkill.
>
> I also added the two ECN flags and descriptions of all the flags. And removed the misleading ALL flag.
>
> I don't know the formal or customary threshold criteria for adding a copyright notice, so I just added it. It's our first direct contribution where we didn't just send the corrections to another contributor, so I thought it would be nice to have our name in here. You're the maintainer, so I'll leave the final decision up to you.
Most projects including DPDK do not add additional copyrights unless it
is a complete rewrite. Please don't clutter the code with this stuff.
next prev parent reply other threads:[~2019-05-13 14:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 17:34 Morten Brørup
2019-05-10 17:34 ` Morten Brørup
2019-05-13 11:54 ` Olivier Matz
2019-05-13 11:54 ` Olivier Matz
2019-05-13 13:02 ` Morten Brørup
2019-05-13 13:02 ` Morten Brørup
2019-05-13 14:47 ` Stephen Hemminger [this message]
2019-05-13 14:47 ` Stephen Hemminger
2019-05-13 15:15 ` Morten Brørup
2019-05-13 15:15 ` Morten Brørup
2019-05-13 17:00 ` Ferruh Yigit
2019-05-13 17:00 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2019-05-10 17:10 Morten Brørup
2019-05-10 17:10 ` Morten Brørup
2019-05-10 16:10 Morten Brørup
2019-05-10 16:10 ` Morten Brørup
2019-05-10 14:10 Morten Brørup
2019-05-10 14:10 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513074708.775d0559@hermes.lan \
--to=stephen@networkplumber.org \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mb@smartsharesystems.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).