From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id CF6B55F36 for ; Tue, 14 May 2019 17:25:58 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id y11so9298856pfm.13 for ; Tue, 14 May 2019 08:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RsZP2jLQSV59rbeZAanmZ5HVHOSZAPOnZaaHnx19OyI=; b=GV1CFb9jWB/WYBbYbEHPpbX8Eym4h0BZr0Y718CaGa1NdKESZoKZZdalIN8RMWIvU3 hRIeiyyGxL4emJn828YLxcXFFvF+PMWpFoOHSVx3/FyJJzECbIAouwsApSgD7SMQXjYD Pjq7Xki+PHhJn2NQvW09lpxoi1wVb5IhkLHPql7UwO8MiTsN706HtYmqJnhAy9t7Wm6m S9dYOWiqu5cNVhZv2WrjrwFO8uPg9Ez3kVAGG+5VOT5cDcUwFxipX1LGGcivh+V3wsRO mwf5cLAYvYEhMK3clicrphkggXq3iqSPMAqr6AIRtrHhOGzm5MNOUsFJX+VaX/+Kaq66 XzAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RsZP2jLQSV59rbeZAanmZ5HVHOSZAPOnZaaHnx19OyI=; b=uQn7LRsDl7v/lo3XQtvxxO5ZwpdsC0+G3sZRb0sGSOoLmDlJ3c+KtqtlZcMHxf8qS1 5fWAm+foBOqjC4nmo8mTvrCdMUNakILeIVZWeHoxvxCALO48WzUz5te7O4xHFwJQNy/H XlxDv2KJbUQ0dWJ8dsEtjG/+iI7fusc41/3dpnxRchUtJnmQiwChP/IWcRlsmg3/x5W6 x1bDi5BOPWvmgWD4NBIsFfKnm72llWjgnvW3RfFmT6D2sW9b7YaE2AoMK3jPfMIzQYxA hcv8RzYlak5MEfZpF7nW9ytoqtlnWE8F769YJCJsi6RvMoyOR95c4lAEsgvbJsPw2zuM Npng== X-Gm-Message-State: APjAAAVuZ0/pWM+1MmbrX8fEg6X3TGYi6L8NpYKRkAD19doKGa1FcjN4 ism+T90Iu45gS1GUg9SxPHzVZg== X-Google-Smtp-Source: APXvYqyQ5Itm1Wkz1bsQzupobRqpN/J+XpcsRIf0VQky5InwgJN88mI/lWyQK7Uw0vjTs/1kuKD8Wg== X-Received: by 2002:a63:17:: with SMTP id 23mr38139675pga.206.1557847557787; Tue, 14 May 2019 08:25:57 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n184sm31412077pfn.21.2019.05.14.08.25.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 08:25:57 -0700 (PDT) Date: Tue, 14 May 2019 08:25:51 -0700 From: Stephen Hemminger To: Xiaoyu Min Cc: Adrien Mazarguil , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org Message-ID: <20190514082551.2611299e@hermes.lan> In-Reply-To: <20190514071829.5251-1-jackmin@mellanox.com> References: <20190514071829.5251-1-jackmin@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 May 2019 15:25:59 -0000 On Tue, 14 May 2019 10:18:29 +0300 Xiaoyu Min wrote: > Add GRE's checksum, key, and sequence field to the > struct rte_flow_item_gre in order to match. > > Signed-off-by: Xiaoyu Min > --- > lib/librte_ethdev/rte_flow.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index 63f84fca65..fb04af3268 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -847,6 +847,10 @@ struct rte_flow_item_gre { > */ > rte_be16_t c_rsvd0_ver; > rte_be16_t protocol; /**< Protocol type. */ > + rte_be16_t checksum; /**< chksum for the header and payload, optional.*/ > + rte_be16_t rsvd1; /**< present when C bit is set, optional. */ > + rte_be32_t key; /**< application specific key value, optional. */ > + rte_be32_t sequence; /**< sequence num for the GRE packet, optional. */ > }; > > /** Default mask for RTE_FLOW_ITEM_TYPE_GRE. */ This breaks ABI. To extend you need to add a new flow item type and keep old one as legacy. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 771FAA00E6 for ; Tue, 14 May 2019 17:26:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55BCF5F3C; Tue, 14 May 2019 17:26:00 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id CF6B55F36 for ; Tue, 14 May 2019 17:25:58 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id y11so9298856pfm.13 for ; Tue, 14 May 2019 08:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RsZP2jLQSV59rbeZAanmZ5HVHOSZAPOnZaaHnx19OyI=; b=GV1CFb9jWB/WYBbYbEHPpbX8Eym4h0BZr0Y718CaGa1NdKESZoKZZdalIN8RMWIvU3 hRIeiyyGxL4emJn828YLxcXFFvF+PMWpFoOHSVx3/FyJJzECbIAouwsApSgD7SMQXjYD Pjq7Xki+PHhJn2NQvW09lpxoi1wVb5IhkLHPql7UwO8MiTsN706HtYmqJnhAy9t7Wm6m S9dYOWiqu5cNVhZv2WrjrwFO8uPg9Ez3kVAGG+5VOT5cDcUwFxipX1LGGcivh+V3wsRO mwf5cLAYvYEhMK3clicrphkggXq3iqSPMAqr6AIRtrHhOGzm5MNOUsFJX+VaX/+Kaq66 XzAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RsZP2jLQSV59rbeZAanmZ5HVHOSZAPOnZaaHnx19OyI=; b=uQn7LRsDl7v/lo3XQtvxxO5ZwpdsC0+G3sZRb0sGSOoLmDlJ3c+KtqtlZcMHxf8qS1 5fWAm+foBOqjC4nmo8mTvrCdMUNakILeIVZWeHoxvxCALO48WzUz5te7O4xHFwJQNy/H XlxDv2KJbUQ0dWJ8dsEtjG/+iI7fusc41/3dpnxRchUtJnmQiwChP/IWcRlsmg3/x5W6 x1bDi5BOPWvmgWD4NBIsFfKnm72llWjgnvW3RfFmT6D2sW9b7YaE2AoMK3jPfMIzQYxA hcv8RzYlak5MEfZpF7nW9ytoqtlnWE8F769YJCJsi6RvMoyOR95c4lAEsgvbJsPw2zuM Npng== X-Gm-Message-State: APjAAAVuZ0/pWM+1MmbrX8fEg6X3TGYi6L8NpYKRkAD19doKGa1FcjN4 ism+T90Iu45gS1GUg9SxPHzVZg== X-Google-Smtp-Source: APXvYqyQ5Itm1Wkz1bsQzupobRqpN/J+XpcsRIf0VQky5InwgJN88mI/lWyQK7Uw0vjTs/1kuKD8Wg== X-Received: by 2002:a63:17:: with SMTP id 23mr38139675pga.206.1557847557787; Tue, 14 May 2019 08:25:57 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n184sm31412077pfn.21.2019.05.14.08.25.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 08:25:57 -0700 (PDT) Date: Tue, 14 May 2019 08:25:51 -0700 From: Stephen Hemminger To: Xiaoyu Min Cc: Adrien Mazarguil , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org Message-ID: <20190514082551.2611299e@hermes.lan> In-Reply-To: <20190514071829.5251-1-jackmin@mellanox.com> References: <20190514071829.5251-1-jackmin@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190514152551.nSRYG0W7EAnGMeD634Eoko-qywahK-a7lFnOu20i1kc@z> On Tue, 14 May 2019 10:18:29 +0300 Xiaoyu Min wrote: > Add GRE's checksum, key, and sequence field to the > struct rte_flow_item_gre in order to match. > > Signed-off-by: Xiaoyu Min > --- > lib/librte_ethdev/rte_flow.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index 63f84fca65..fb04af3268 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -847,6 +847,10 @@ struct rte_flow_item_gre { > */ > rte_be16_t c_rsvd0_ver; > rte_be16_t protocol; /**< Protocol type. */ > + rte_be16_t checksum; /**< chksum for the header and payload, optional.*/ > + rte_be16_t rsvd1; /**< present when C bit is set, optional. */ > + rte_be32_t key; /**< application specific key value, optional. */ > + rte_be32_t sequence; /**< sequence num for the GRE packet, optional. */ > }; > > /** Default mask for RTE_FLOW_ITEM_TYPE_GRE. */ This breaks ABI. To extend you need to add a new flow item type and keep old one as legacy.