From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5D75EA00E6 for ; Tue, 14 May 2019 13:49:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 452CB5A4A; Tue, 14 May 2019 13:49:49 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 733F74F91 for ; Tue, 14 May 2019 13:49:47 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id r4so18839394wro.10 for ; Tue, 14 May 2019 04:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rrRkjsZF4wOIqHiDSevuyFehj7+jSzLTWtomXKgBjAE=; b=NiuqCpZ36FM+pXXNFrHUGnDspZFq5R4lAcJpFPFu40JqIOBXp4MuhDi5zr8qSjKywf mD7AVsDYV1JUJ019KwJ34f/t0IxX9+k2WhnIpe0+wMAgsyDO/BQ1sYCj8FsZQcMeqAHO 5ooTxAFMI6J1H//NxmiDiFQgObbuLVBj5LHuU3SAyuDZgkzFQllprty/jtpkngu1zDPB ylMPzNi8YmpUzDUorbk9+bb3RKqQQyAxHvJ5vCS/AKGqg1uayYGkCbO/7FSwmsBWZT0+ MWYCmW4J/V92+cMUKVFj+t6jwiTkbzCUBpJ5aFVMZokjWtfy4940SOCISgBJo/uAeXAH xqbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rrRkjsZF4wOIqHiDSevuyFehj7+jSzLTWtomXKgBjAE=; b=TghoaQRbJ+mTJDd6LWYnkuveYnhlwKriNahRuv91SQVWQWwRYDFSmqZztgStxtei4J ElppKJLiKSqpSoLas9EWd4tOt149PMpN+Lj06mASEYz6S5WGLtboCnlXGUK5fJbXytWj s+IkQqz2c5mx+cARiMOkxAhpKjBbj9z9AcxDRf2zvFdAIrcbU1LQz0gY3vo+8ogaPiU4 uNwBO32xRsja3os9Dlmx01QYNx9Yru41mE/jIT0iy3FyReArrVAqRAn0O1kLoasVNvAx uv2ryRy3mxxwQRVRedNtHkNK1H9fTegVnypbHBJlHFgIJ1L5lWXNt5KVYJnMJsdU8aNw CiNA== X-Gm-Message-State: APjAAAV3j7KJLkUntuUzD93iwwnqeAm1ew3oG9qayvYUv8tWNItIV1o6 AMRurab78aS06nhtYz64ivKwXQ== X-Google-Smtp-Source: APXvYqxmEp4cOA+Ngid8S254hbKPQE+K71UF9g9zTZeLjjy88Ao+bHVkrXGVAIdz2HMkSGjDd7HtRw== X-Received: by 2002:adf:c98f:: with SMTP id f15mr21916530wrh.279.1557834587250; Tue, 14 May 2019 04:49:47 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s3sm29023424wre.97.2019.05.14.04.49.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 May 2019 04:49:46 -0700 (PDT) Date: Tue, 14 May 2019 13:49:45 +0200 From: Adrien Mazarguil To: Marcin Smoczynski Cc: bruce.richardson@intel.com, thomas@monjalon.net, dev@dpdk.org, konstantin.ananyev@intel.com Message-ID: <20190514114945.GP4284@6wind.com> References: <20190514114354.16212-1-marcinx.smoczynski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190514114354.16212-1-marcinx.smoczynski@intel.com> Subject: Re: [dpdk-dev] [PATCH] build: enable BSD features visibility for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190514114945.GibbzmFa1MZbgC7SrSHh6lGaTLhiaGp_rnXbiCcH-Es@z> On Tue, May 14, 2019 at 01:43:54PM +0200, Marcin Smoczynski wrote: > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro > explicitly in its build recipe, it restricts visibility of a non POSIX > features subset, such as IANA protocol numbers (IPPROTO_* macros). > Non standard features are enabled by default for DPDK both for Linux > thanks to _GNU_SOURCE and for FreeBSD thanks to __BSD_VISIBLE. However > using XOPEN_SOURCE or POSIX_(C_)SOURCE in a component causes > __BSD_VISIBLE to be defined to 0 for FreeBSD, causing different feature > sets visibility for Linux and FreeBSD. It restricts from using IPPROTO > macros in public headers, such as rte_ip.h, despite the fact they are > already widely used in sources. > > Add __BSD_VISIBLE macro specified unconditionally for FreeBSD targets > which enforces feature sets visibility unification between Linux and > FreeBSD. > > This patch solves the problem of build breaks for [1] on FreeBSD [2] > following the discussion [3]. > > [1] https://mails.dpdk.org/archives/dev/2019-May/131885.html > [2] http://mails.dpdk.org/archives/test-report/2019-May/082263.html > [3] https://mails.dpdk.org/archives/dev/2019-May/132110.html > > Signed-off-by: Marcin Smoczynski Thanks! Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND