From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 33888A00E6 for ; Tue, 14 May 2019 17:37:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA1AF695D; Tue, 14 May 2019 17:37:33 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id CBA1A5F62; Tue, 14 May 2019 17:37:31 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4EFZgSK023276; Tue, 14 May 2019 08:37:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Dc7bZmZkZemY2aMp5YMZM2WRunRXCxp2Bqr1Xq3boZQ=; b=EXE0N1HWS3On6cj+fho4FlQsd6ung9GXUUHly2NniGqK0hzAYcpOCypI8Vp6tBFljxRH /6fsOXb79eJ2hH5ILZbBuW3zdkr/PSxxDZkJVR5hOk05Q2gQgvoJzbpamJBZd4ij9wfn Z10Jls6AJYXVQf8elE3Ekh1TQK+51VuswL5A3Rjiu4Upd8eR0dsy37+JHB9+MebmGHwH MQKh5n+TEhTP2dlYgAk1aFR3I1xhITbn22fSinBEi8OEwdwyC1DmxaumPIF3cQwMo6Z1 SsDyidxT+4rZPKl8gre9K+Lc9D/ltj3RgwwpLWACyaW0P653OggmNm8FVoQczw4gfzKs zQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2sfyhdrabv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 14 May 2019 08:37:30 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 14 May 2019 08:37:30 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.51) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 14 May 2019 08:37:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dc7bZmZkZemY2aMp5YMZM2WRunRXCxp2Bqr1Xq3boZQ=; b=odc6IgVduE5/bg75yBlzx5RuzU9alWvygnHh/XAGxnuzY1ZDmkD2qct5cj9FaoMumDA9OmymsKQ9fLSKopre5Zhcf9M0zK0B9kJtheSI9hWWd959udG0uof2NyBWv6hSF4aEor8Q/ytHMrhxTk+uRGOyu1Nk16HySIRJM4O0wX4= Received: from CY4PR1801MB2053.namprd18.prod.outlook.com (10.171.255.158) by CY4PR1801MB2006.namprd18.prod.outlook.com (10.171.255.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Tue, 14 May 2019 15:37:25 +0000 Received: from CY4PR1801MB2053.namprd18.prod.outlook.com ([fe80::d1ea:e4ef:5fcc:1f42]) by CY4PR1801MB2053.namprd18.prod.outlook.com ([fe80::d1ea:e4ef:5fcc:1f42%5]) with mapi id 15.20.1878.022; Tue, 14 May 2019 15:37:25 +0000 From: Shally Verma To: "Trahe, Fiona" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , Ashish Gupta , "Daly, Lee" , Sunila Sahu , "stable@dpdk.org" Thread-Topic: [PATCH v2] doc/compress: clarify error handling on data-plane Thread-Index: AQHU7uRcY1b0dFOFhkSSkiDYaczK7aZitxdAgAg+ygCAAAGvwA== Date: Tue, 14 May 2019 15:37:24 +0000 Message-ID: References: <1554740072-11898-1-git-send-email-fiona.trahe@intel.com> <1554821747-27868-1-git-send-email-fiona.trahe@intel.com> <348A99DA5F5B7549AA880327E580B43589767E7F@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B43589767E7F@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [110.224.130.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: be8fba62-7f29-482b-ea1d-08d6d882105f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:CY4PR1801MB2006; x-ms-traffictypediagnostic: CY4PR1801MB2006: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0037FD6480 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(396003)(39860400002)(366004)(346002)(13464003)(189003)(199004)(66946007)(316002)(486006)(66556008)(73956011)(66476007)(64756008)(66446008)(76176011)(76116006)(6506007)(7696005)(102836004)(74316002)(8936002)(53546011)(476003)(186003)(26005)(8676002)(99286004)(11346002)(4326008)(7736002)(305945005)(229853002)(9686003)(81166006)(6436002)(446003)(55016002)(14444005)(53936002)(6246003)(66066001)(25786009)(68736007)(54906003)(110136005)(5660300002)(478600001)(33656002)(81156014)(2501003)(71190400001)(71200400001)(256004)(3846002)(6116002)(2906002)(52536014)(86362001)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2006; H:CY4PR1801MB2053.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 6t8iHUtHtKsmJAprIB/Dq+lmvIbPR0S8m81kyj5467ePt/NmeYGt04kcCbUSEqwLqXeItbYSzT5hxk5y/zfDSRWZSxpp1FrzsPYSFe8NqJic1cZ9DYsaVEgR4HK+vWUJr6xiQXXF3tjsBIEyUcdkaSfOmhpK5dkhxKDA80bE92pno9ehUQXWQso1AifYmn5Gl0z5j1ug9w0vy+0h83gxGIRQqEYQ7oE3yWRlkCyTTuXYp/8qRGkaePaHZkUFqun3ltsU6gHvx/ZTCx+EKrq2Ca17rtZwesp8VEo4dyjNsysYyCE199uuI1F17lXr4VVHkZloz8UI0QMFXzXkk4s1MZr2w/905VCQpdgCwZRyMh94wxNOGDzWZZztYqMeLlTM9CWRYtF4PMqioI+msvIKVYZHYozxAXwdA6+g1/CVu4k= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: be8fba62-7f29-482b-ea1d-08d6d882105f X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2019 15:37:24.9884 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2006 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-14_10:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190514153724.xnI-0duRUpS7e0_lme9NGuTHMkPlgIjLHbhN3kjTF_E@z> HI Fiona > -----Original Message----- > From: Trahe, Fiona > Sent: Tuesday, May 14, 2019 9:00 PM > To: Shally Verma ; dev@dpdk.org > Cc: akhil.goyal@nxp.com; Ashish Gupta ; Daly, Lee > ; Sunila Sahu ; stable@dpdk.org; > Trahe, Fiona > Subject: RE: [PATCH v2] doc/compress: clarify error handling on data-plan= e >=20 > Hi Shally, >=20 > Although we're close to agreement on this, I'm reconsidering. > I think the difficulty we've had finding the best wording highlights the = confusion > an app developer will have in figuring out how to handle errors on enqueu= e. > So I'm proposing to drop this - which was intended to allow some optimisa= tion - > and instead propose a more robust approach, i.e. add this to the doc: >=20 > Operation status after enqueue / dequeue > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Some of the above values may arise in the op after an > ``rte_compressdev_enqueue_burst()``. If number ops enqueued < number > ops requested then > the app should check the op.status of nb_enqd+1. If status is > RTE_COMP_OP_STATUS_NOT_PROCESSED, it likely indicates a full-queue > case for a hardware device > and a retry after dequeuing some ops is likely to be successful. If t= he op holds > any other status, e.g. > RTE_COMP_OP_STATUS_INVALID_ARGS, a retry with the same op is unlikely > to be successful. >=20 >=20 > I know this adds an extra fork, so is less optimal, but once there's even= a small > chance that an error may occur on the enqueue, a robust application shoul= d > probably check anyway. > What do you think? > If you agree, I'll send the doc update and a perf tool update to add the = status > check on the enqueue. [Shally] Yup This looks absolutely perfect to me. So it is acked by me. >=20 > Btw - this doesn't stop PMDs from minimising those cases, just means they= 're > not bound by the API to do it. >=20 > Fiona