From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80058.outbound.protection.outlook.com [40.107.8.58]) by dpdk.org (Postfix) with ESMTP id EFC975F0F for ; Wed, 15 May 2019 10:56:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LNkodVEdQxc4Im97jRCq5s9f98iDsMvbMtpKUZ+AdSQ=; b=HRiRKWJk6a8BfCywGr7uwoHWsBEbo5it/zFFWZ1un4aPjBffnfn6j4sP07uDIFGLrDSH5M9otyMnPaNXT2Rrbq4YGAMcBEBSH6B/y+heUfYR0fDjR3APOfAbR2ImYVWBU+q/2YYRYhzkn9ZsYbh8le/SDAQV1d/Y8bMLR8V6Wk8= Received: from AM6PR05MB6567.eurprd05.prod.outlook.com (20.179.6.215) by AM6PR05MB5879.eurprd05.prod.outlook.com (20.179.0.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Wed, 15 May 2019 08:56:14 +0000 Received: from AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::1da7:7c33:b730:38f4]) by AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::1da7:7c33:b730:38f4%6]) with mapi id 15.20.1900.010; Wed, 15 May 2019 08:56:14 +0000 From: Jack Min To: Stephen Hemminger CC: Adrien Mazarguil , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API Thread-Index: AQHVCiVSUK0hXhoI+UWxSLmfa8K4SaZqvlWAgAElcAA= Date: Wed, 15 May 2019 08:56:14 +0000 Message-ID: <20190515085606.2q7bkpl2vtcxygas@mellanox.com> References: <20190514071829.5251-1-jackmin@mellanox.com> <20190514082551.2611299e@hermes.lan> In-Reply-To: <20190514082551.2611299e@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR04CA0046.apcprd04.prod.outlook.com (2603:1096:202:14::14) To AM6PR05MB6567.eurprd05.prod.outlook.com (2603:10a6:20b:bc::23) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jackmin@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [139.227.41.201] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6721f7f1-007f-480f-2215-08d6d9132f63 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM6PR05MB5879; x-ms-traffictypediagnostic: AM6PR05MB5879: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0038DE95A2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(396003)(39860400002)(366004)(376002)(199004)(189003)(8936002)(476003)(14444005)(11346002)(446003)(81166006)(81156014)(8676002)(1076003)(256004)(486006)(26005)(5660300002)(71190400001)(71200400001)(3846002)(186003)(6116002)(86362001)(73956011)(66946007)(6246003)(6486002)(6436002)(229853002)(53936002)(66476007)(36756003)(66556008)(64756008)(66446008)(4326008)(7736002)(25786009)(66066001)(6512007)(316002)(2616005)(305945005)(99286004)(68736007)(76176011)(52116002)(2906002)(54906003)(14454004)(6916009)(102836004)(6506007)(386003)(508600001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB5879; H:AM6PR05MB6567.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gTEW56c1VcdKCHoHx3XUI7MIOeojHcBcFdrZWzV+WdNDnq9VOO2zt4qrw85rrQLvaFOSlcJm7U5xP4HgHvd59MBy/Oire2zKHRLEZxvDfqMUbmXZcIvMvtpu3hC4GbxcdxB4ck9OBVNfkZynl1cIjAY6ZAz54H6YKC14jlbYBRcNE5HsCSZeAmc6nTyt+w852H9UNcdr32NIJP/3RqfZtSmRNVb5JMLsi9Gp5zQBTQoqWu6MOH4vhAJiLqh9+oInRBhsXu8wLqQiNq+VO9aqiXmpxTPHBxRGRvEDjZBPo9k79UkmdTAPjynsz3BecbtmFIyKA2FBaHJYYc3O2lBGV5nx1xVOkTYk1h69/L98Ajj18BW13Ug0ciQrypErOGqWADoY/p473IcAqE+UzJCbw/tZSmp9BXRbEwWCr2wO/gE= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6721f7f1-007f-480f-2215-08d6d9132f63 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2019 08:56:14.6633 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5879 Subject: Re: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 May 2019 08:56:17 -0000 On Tue, 19-05-14, 08:25, Stephen Hemminger wrote: > On Tue, 14 May 2019 10:18:29 +0300 > Xiaoyu Min wrote: >=20 > > Add GRE's checksum, key, and sequence field to the > > struct rte_flow_item_gre in order to match. > >=20 > > Signed-off-by: Xiaoyu Min > > --- > > lib/librte_ethdev/rte_flow.h | 4 ++++ > > 1 file changed, 4 insertions(+) > >=20 > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.= h > > index 63f84fca65..fb04af3268 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -847,6 +847,10 @@ struct rte_flow_item_gre { > > */ > > rte_be16_t c_rsvd0_ver; > > rte_be16_t protocol; /**< Protocol type. */ > > + rte_be16_t checksum; /**< chksum for the header and payload, optional= .*/ > > + rte_be16_t rsvd1; /**< present when C bit is set, optional. */ > > + rte_be32_t key; /**< application specific key value, optional. */ > > + rte_be32_t sequence; /**< sequence num for the GRE packet, optional. = */ > > }; > > =20 > > /** Default mask for RTE_FLOW_ITEM_TYPE_GRE. */ >=20 > This breaks ABI. >=20 > To extend you need to add a new flow item type and keep old > one as legacy. OK, I'll add a new flow item. Thank you. -Jack From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 78BC3A00E6 for ; Wed, 15 May 2019 10:56:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B2095F20; Wed, 15 May 2019 10:56:18 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80058.outbound.protection.outlook.com [40.107.8.58]) by dpdk.org (Postfix) with ESMTP id EFC975F0F for ; Wed, 15 May 2019 10:56:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LNkodVEdQxc4Im97jRCq5s9f98iDsMvbMtpKUZ+AdSQ=; b=HRiRKWJk6a8BfCywGr7uwoHWsBEbo5it/zFFWZ1un4aPjBffnfn6j4sP07uDIFGLrDSH5M9otyMnPaNXT2Rrbq4YGAMcBEBSH6B/y+heUfYR0fDjR3APOfAbR2ImYVWBU+q/2YYRYhzkn9ZsYbh8le/SDAQV1d/Y8bMLR8V6Wk8= Received: from AM6PR05MB6567.eurprd05.prod.outlook.com (20.179.6.215) by AM6PR05MB5879.eurprd05.prod.outlook.com (20.179.0.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Wed, 15 May 2019 08:56:14 +0000 Received: from AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::1da7:7c33:b730:38f4]) by AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::1da7:7c33:b730:38f4%6]) with mapi id 15.20.1900.010; Wed, 15 May 2019 08:56:14 +0000 From: Jack Min To: Stephen Hemminger CC: Adrien Mazarguil , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API Thread-Index: AQHVCiVSUK0hXhoI+UWxSLmfa8K4SaZqvlWAgAElcAA= Date: Wed, 15 May 2019 08:56:14 +0000 Message-ID: <20190515085606.2q7bkpl2vtcxygas@mellanox.com> References: <20190514071829.5251-1-jackmin@mellanox.com> <20190514082551.2611299e@hermes.lan> In-Reply-To: <20190514082551.2611299e@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR04CA0046.apcprd04.prod.outlook.com (2603:1096:202:14::14) To AM6PR05MB6567.eurprd05.prod.outlook.com (2603:10a6:20b:bc::23) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jackmin@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [139.227.41.201] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6721f7f1-007f-480f-2215-08d6d9132f63 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM6PR05MB5879; x-ms-traffictypediagnostic: AM6PR05MB5879: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0038DE95A2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(396003)(39860400002)(366004)(376002)(199004)(189003)(8936002)(476003)(14444005)(11346002)(446003)(81166006)(81156014)(8676002)(1076003)(256004)(486006)(26005)(5660300002)(71190400001)(71200400001)(3846002)(186003)(6116002)(86362001)(73956011)(66946007)(6246003)(6486002)(6436002)(229853002)(53936002)(66476007)(36756003)(66556008)(64756008)(66446008)(4326008)(7736002)(25786009)(66066001)(6512007)(316002)(2616005)(305945005)(99286004)(68736007)(76176011)(52116002)(2906002)(54906003)(14454004)(6916009)(102836004)(6506007)(386003)(508600001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB5879; H:AM6PR05MB6567.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gTEW56c1VcdKCHoHx3XUI7MIOeojHcBcFdrZWzV+WdNDnq9VOO2zt4qrw85rrQLvaFOSlcJm7U5xP4HgHvd59MBy/Oire2zKHRLEZxvDfqMUbmXZcIvMvtpu3hC4GbxcdxB4ck9OBVNfkZynl1cIjAY6ZAz54H6YKC14jlbYBRcNE5HsCSZeAmc6nTyt+w852H9UNcdr32NIJP/3RqfZtSmRNVb5JMLsi9Gp5zQBTQoqWu6MOH4vhAJiLqh9+oInRBhsXu8wLqQiNq+VO9aqiXmpxTPHBxRGRvEDjZBPo9k79UkmdTAPjynsz3BecbtmFIyKA2FBaHJYYc3O2lBGV5nx1xVOkTYk1h69/L98Ajj18BW13Ug0ciQrypErOGqWADoY/p473IcAqE+UzJCbw/tZSmp9BXRbEwWCr2wO/gE= Content-Type: text/plain; charset="UTF-8" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6721f7f1-007f-480f-2215-08d6d9132f63 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2019 08:56:14.6633 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5879 Subject: Re: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190515085614.WV06P-aYu1tvGN3HA5HdTfogVkoGIRVJ4VTjpUVU9Xw@z> On Tue, 19-05-14, 08:25, Stephen Hemminger wrote: > On Tue, 14 May 2019 10:18:29 +0300 > Xiaoyu Min wrote: >=20 > > Add GRE's checksum, key, and sequence field to the > > struct rte_flow_item_gre in order to match. > >=20 > > Signed-off-by: Xiaoyu Min > > --- > > lib/librte_ethdev/rte_flow.h | 4 ++++ > > 1 file changed, 4 insertions(+) > >=20 > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.= h > > index 63f84fca65..fb04af3268 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -847,6 +847,10 @@ struct rte_flow_item_gre { > > */ > > rte_be16_t c_rsvd0_ver; > > rte_be16_t protocol; /**< Protocol type. */ > > + rte_be16_t checksum; /**< chksum for the header and payload, optional= .*/ > > + rte_be16_t rsvd1; /**< present when C bit is set, optional. */ > > + rte_be32_t key; /**< application specific key value, optional. */ > > + rte_be32_t sequence; /**< sequence num for the GRE packet, optional. = */ > > }; > > =20 > > /** Default mask for RTE_FLOW_ITEM_TYPE_GRE. */ >=20 > This breaks ABI. >=20 > To extend you need to add a new flow item type and keep old > one as legacy. OK, I'll add a new flow item. Thank you. -Jack