From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 448DFA00E6 for ; Wed, 15 May 2019 11:29:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B7115A4A; Wed, 15 May 2019 11:29:23 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 513FB34F0; Wed, 15 May 2019 11:29:21 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 901A13082DD3; Wed, 15 May 2019 09:29:20 +0000 (UTC) Received: from [10.36.112.52] (ovpn-112-52.ams2.redhat.com [10.36.112.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CFD4919949; Wed, 15 May 2019 09:29:16 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, stephen@networkplumber.org, stable@dpdk.org, Rahul Lakkireddy References: <1557906862-1116-1-git-send-email-david.marchand@redhat.com> From: Maxime Coquelin Message-ID: Date: Wed, 15 May 2019 11:29:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1557906862-1116-1-git-send-email-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 15 May 2019 09:29:20 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/4] net/cxgbe: do not dereference global config struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190515092913.sGZvNMyP0Riu5_MBLL-DLQcrdWSSmjeAo7cUHNmUlRk@z> On 5/15/19 9:54 AM, David Marchand wrote: > Prefer the existing apis rather than direct access the configuration > structure. > > Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support") > Cc:stable@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/cxgbe/cxgbe_main.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime