From: Bruce Richardson <bruce.richardson@intel.com>
To: David Harton <dharton@cisco.com>
Cc: dev@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/i40e: Eliminate weak symbols in i40e_rxtx.c
Date: Wed, 15 May 2019 15:13:33 +0100 [thread overview]
Message-ID: <20190515141333.GA614@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190515130512.6366-1-dharton@cisco.com>
On Wed, May 15, 2019 at 09:05:12AM -0400, David Harton wrote:
> Use of weak symbols can hide makefile errors especially when
> custom makefiles are used. Removing the use of weak symbols
> to avoid a stub function being linked in production code.
>
> Signed-off-by: David Harton <dharton@cisco.com>
> ---
Looks reasonable to me.
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2019-05-15 14:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 13:05 David Harton
2019-05-15 13:05 ` David Harton
2019-05-15 14:13 ` Bruce Richardson [this message]
2019-05-15 14:13 ` Bruce Richardson
2019-05-15 16:13 ` [dpdk-dev] [PATCH v2] " David Harton
2019-05-15 16:13 ` David Harton
2019-05-16 14:08 ` Bruce Richardson
2019-06-04 15:59 ` Ferruh Yigit
2019-06-04 16:19 ` David Harton (dharton)
2019-06-06 9:07 ` Ferruh Yigit
2019-06-04 16:25 ` Bruce Richardson
2019-05-16 18:28 ` [dpdk-dev] [PATCH v3] " David Harton
2019-05-17 10:21 ` Bruce Richardson
2019-05-29 17:18 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515141333.GA614@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).