* [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
@ 2019-05-15 16:25 Fan Zhang
2019-05-15 16:25 ` Fan Zhang
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Fan Zhang @ 2019-05-15 16:25 UTC (permalink / raw)
To: dev; +Cc: maxime.coquelin, Fan Zhang, stable
This patch tries to fix the coverity issue of unchecked
return value. Since the function that causes the problem
is unused, it is removed completely.
Coverity issue: 336816
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: stable@dpdk.org
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
examples/vhost_crypto/main.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
index ac7118e7e..cfb9dfda2 100644
--- a/examples/vhost_crypto/main.c
+++ b/examples/vhost_crypto/main.c
@@ -354,12 +354,6 @@ static const struct vhost_device_ops virtio_crypto_device_ops = {
.destroy_device = destroy_device,
};
-__attribute__((unused))
-static void clrscr(void)
-{
- system("@cls||clear");
-}
-
static int
vhost_crypto_worker(void *arg)
{
--
2.14.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
2019-05-15 16:25 [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value Fan Zhang
@ 2019-05-15 16:25 ` Fan Zhang
2019-05-16 8:07 ` Jens Freimann
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Fan Zhang @ 2019-05-15 16:25 UTC (permalink / raw)
To: dev; +Cc: maxime.coquelin, Fan Zhang, stable
This patch tries to fix the coverity issue of unchecked
return value. Since the function that causes the problem
is unused, it is removed completely.
Coverity issue: 336816
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: stable@dpdk.org
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
examples/vhost_crypto/main.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
index ac7118e7e..cfb9dfda2 100644
--- a/examples/vhost_crypto/main.c
+++ b/examples/vhost_crypto/main.c
@@ -354,12 +354,6 @@ static const struct vhost_device_ops virtio_crypto_device_ops = {
.destroy_device = destroy_device,
};
-__attribute__((unused))
-static void clrscr(void)
-{
- system("@cls||clear");
-}
-
static int
vhost_crypto_worker(void *arg)
{
--
2.14.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
2019-05-15 16:25 [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value Fan Zhang
2019-05-15 16:25 ` Fan Zhang
@ 2019-05-16 8:07 ` Jens Freimann
2019-05-16 8:07 ` Jens Freimann
2019-06-17 9:09 ` Zhang, Roy Fan
2019-06-17 9:26 ` Kovacevic, Marko
` (2 subsequent siblings)
4 siblings, 2 replies; 10+ messages in thread
From: Jens Freimann @ 2019-05-16 8:07 UTC (permalink / raw)
To: Fan Zhang; +Cc: dev, maxime.coquelin, stable
On Wed, May 15, 2019 at 05:25:48PM +0100, Fan Zhang wrote:
>This patch tries to fix the coverity issue of unchecked
>return value. Since the function that causes the problem
>is unused, it is removed completely.
>
>Coverity issue: 336816
>Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
>Cc: stable@dpdk.org
>
>Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>---
> examples/vhost_crypto/main.c | 6 ------
> 1 file changed, 6 deletions(-)
>
It really is unused.
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
2019-05-16 8:07 ` Jens Freimann
@ 2019-05-16 8:07 ` Jens Freimann
2019-06-17 9:09 ` Zhang, Roy Fan
1 sibling, 0 replies; 10+ messages in thread
From: Jens Freimann @ 2019-05-16 8:07 UTC (permalink / raw)
To: Fan Zhang; +Cc: dev, maxime.coquelin, stable
On Wed, May 15, 2019 at 05:25:48PM +0100, Fan Zhang wrote:
>This patch tries to fix the coverity issue of unchecked
>return value. Since the function that causes the problem
>is unused, it is removed completely.
>
>Coverity issue: 336816
>Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
>Cc: stable@dpdk.org
>
>Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>---
> examples/vhost_crypto/main.c | 6 ------
> 1 file changed, 6 deletions(-)
>
It really is unused.
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
2019-05-16 8:07 ` Jens Freimann
2019-05-16 8:07 ` Jens Freimann
@ 2019-06-17 9:09 ` Zhang, Roy Fan
2019-06-19 11:56 ` Jens Freimann
1 sibling, 1 reply; 10+ messages in thread
From: Zhang, Roy Fan @ 2019-06-17 9:09 UTC (permalink / raw)
To: Jens Freimann; +Cc: dev
Hi Jens,
You are right. Sorry the code wasn't cleaned up properly in the first place.
Do you want me to send a v2 with new title?
Regards,
Fan
> -----Original Message-----
> From: Jens Freimann [mailto:jfreimann@redhat.com]
> Sent: Thursday, May 16, 2019 9:07 AM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; maxime.coquelin@redhat.com; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked
> return value
>
> On Wed, May 15, 2019 at 05:25:48PM +0100, Fan Zhang wrote:
> >This patch tries to fix the coverity issue of unchecked return value.
> >Since the function that causes the problem is unused, it is removed
> >completely.
> >
> >Coverity issue: 336816
> >Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> >---
> > examples/vhost_crypto/main.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
>
> It really is unused.
>
> Reviewed-by: Jens Freimann <jfreimann@redhat.com>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
2019-05-15 16:25 [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value Fan Zhang
2019-05-15 16:25 ` Fan Zhang
2019-05-16 8:07 ` Jens Freimann
@ 2019-06-17 9:26 ` Kovacevic, Marko
2019-06-20 9:43 ` Maxime Coquelin
2019-06-20 9:59 ` Maxime Coquelin
4 siblings, 0 replies; 10+ messages in thread
From: Kovacevic, Marko @ 2019-06-17 9:26 UTC (permalink / raw)
To: Zhang, Roy Fan, dev; +Cc: maxime.coquelin, Zhang, Roy Fan, stable
> Subject: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return
> value
>
> This patch tries to fix the coverity issue of unchecked return value. Since the
> function that causes the problem is unused, it is removed completely.
>
> Coverity issue: 336816
> Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/vhost_crypto/main.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index ac7118e7e..cfb9dfda2 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -354,12 +354,6 @@ static const struct vhost_device_ops
> virtio_crypto_device_ops = {
> .destroy_device = destroy_device,
> };
>
> -__attribute__((unused))
> -static void clrscr(void)
> -{
> - system("@cls||clear");
> -}
> -
> static int
> vhost_crypto_worker(void *arg)
> {
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
2019-06-17 9:09 ` Zhang, Roy Fan
@ 2019-06-19 11:56 ` Jens Freimann
0 siblings, 0 replies; 10+ messages in thread
From: Jens Freimann @ 2019-06-19 11:56 UTC (permalink / raw)
To: Zhang, Roy Fan; +Cc: dev
On Mon, Jun 17, 2019 at 09:09:59AM +0000, Zhang, Roy Fan wrote:
>Hi Jens,
>
>You are right. Sorry the code wasn't cleaned up properly in the first place.
>Do you want me to send a v2 with new title?
No it's fine for me :)
regards,
Jens
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
2019-05-15 16:25 [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value Fan Zhang
` (2 preceding siblings ...)
2019-06-17 9:26 ` Kovacevic, Marko
@ 2019-06-20 9:43 ` Maxime Coquelin
2019-06-24 12:25 ` Zhang, Roy Fan
2019-06-20 9:59 ` Maxime Coquelin
4 siblings, 1 reply; 10+ messages in thread
From: Maxime Coquelin @ 2019-06-20 9:43 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: stable
On 5/15/19 6:25 PM, Fan Zhang wrote:
> This patch tries to fix the coverity issue of unchecked
> return value. Since the function that causes the problem
> is unused, it is removed completely.
>
> Coverity issue: 336816
> Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/vhost_crypto/main.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index ac7118e7e..cfb9dfda2 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -354,12 +354,6 @@ static const struct vhost_device_ops virtio_crypto_device_ops = {
> .destroy_device = destroy_device,
> };
>
> -__attribute__((unused))
> -static void clrscr(void)
> -{
> - system("@cls||clear");
> -}
> -
> static int
> vhost_crypto_worker(void *arg)
> {
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
I'll change the title to:
examples/vhost_crypto: remove unused function
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
2019-05-15 16:25 [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value Fan Zhang
` (3 preceding siblings ...)
2019-06-20 9:43 ` Maxime Coquelin
@ 2019-06-20 9:59 ` Maxime Coquelin
4 siblings, 0 replies; 10+ messages in thread
From: Maxime Coquelin @ 2019-06-20 9:59 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: stable
On 5/15/19 6:25 PM, Fan Zhang wrote:
> This patch tries to fix the coverity issue of unchecked
> return value. Since the function that causes the problem
> is unused, it is removed completely.
>
> Coverity issue: 336816
> Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/vhost_crypto/main.c | 6 ------
> 1 file changed, 6 deletions(-)
>
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
2019-06-20 9:43 ` Maxime Coquelin
@ 2019-06-24 12:25 ` Zhang, Roy Fan
0 siblings, 0 replies; 10+ messages in thread
From: Zhang, Roy Fan @ 2019-06-24 12:25 UTC (permalink / raw)
To: Maxime Coquelin, dev; +Cc: stable
Thanks Maxime.
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Thursday, June 20, 2019 10:44 AM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: Re: [PATCH] examples/vhost_crypto: fix unchecked return value
>
>
>
> On 5/15/19 6:25 PM, Fan Zhang wrote:
> > This patch tries to fix the coverity issue of unchecked return value.
> > Since the function that causes the problem is unused, it is removed
> > completely.
> >
> > Coverity issue: 336816
> > Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > ---
> > examples/vhost_crypto/main.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/examples/vhost_crypto/main.c
> > b/examples/vhost_crypto/main.c index ac7118e7e..cfb9dfda2 100644
> > --- a/examples/vhost_crypto/main.c
> > +++ b/examples/vhost_crypto/main.c
> > @@ -354,12 +354,6 @@ static const struct vhost_device_ops
> virtio_crypto_device_ops = {
> > .destroy_device = destroy_device,
> > };
> >
> > -__attribute__((unused))
> > -static void clrscr(void)
> > -{
> > - system("@cls||clear");
> > -}
> > -
> > static int
> > vhost_crypto_worker(void *arg)
> > {
> >
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> I'll change the title to:
> examples/vhost_crypto: remove unused function
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-06-24 12:25 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 16:25 [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value Fan Zhang
2019-05-15 16:25 ` Fan Zhang
2019-05-16 8:07 ` Jens Freimann
2019-05-16 8:07 ` Jens Freimann
2019-06-17 9:09 ` Zhang, Roy Fan
2019-06-19 11:56 ` Jens Freimann
2019-06-17 9:26 ` Kovacevic, Marko
2019-06-20 9:43 ` Maxime Coquelin
2019-06-24 12:25 ` Zhang, Roy Fan
2019-06-20 9:59 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).