DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Mesut Ali Ergin <mesut.a.ergin@intel.com>
Cc: olivier.matz@6wind.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kvargs: trim spaces at the beginning and end of key and values
Date: Thu, 16 May 2019 09:36:55 -0700	[thread overview]
Message-ID: <20190516093655.2606d732@hermes.lan> (raw)
In-Reply-To: <1557985267-280205-1-git-send-email-mesut.a.ergin@intel.com>

On Wed, 15 May 2019 22:41:07 -0700
Mesut Ali Ergin <mesut.a.ergin@intel.com> wrote:

> +/* trim leading and trailing spaces */
> +static char *
> +trim_space(char *str)
> +{
> +	char *start, *end;
> +
> +	for (start = str; *start; start++) {
> +		if (!isspace((unsigned char) start[0]))
> +			break;
> +	}
> +
> +	for (end = start + strlen(start); end > start + 1; end--) {
> +		if (!isspace((unsigned char) end[-1]))
> +			break;
> +	}
> +

Why not use existing string functions like strspn?

  parent reply	other threads:[~2019-05-16 16:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  5:41 Mesut Ali Ergin
2019-05-16  5:41 ` Mesut Ali Ergin
2019-05-16 16:36 ` Stephen Hemminger [this message]
2019-05-16 20:55   ` Ergin, Mesut A
2019-05-16 23:18     ` Stephen Hemminger
2019-07-01 13:10 ` Olivier Matz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190516093655.2606d732@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=mesut.a.ergin@intel.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).