From: Bruce Richardson <bruce.richardson@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
Stephen Hemminger <stephen@networkplumber.org>,
DPDK Dev List <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ether: mark ethernet addresses as being 2-byte aligned
Date: Thu, 16 May 2019 21:38:30 +0100 [thread overview]
Message-ID: <20190516203830.GC642@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <0435f920-2ba1-e827-6bf1-96ac81ee9dbc@redhat.com>
On Thu, May 16, 2019 at 07:04:03PM +0100, Kevin Traynor wrote:
> On 16/05/2019 16:54, Bruce Richardson wrote:
> > When including the rte_ether.h header in applications with warnings
> > enabled, a warning was given because of the assumption of 2-byte alignment
> > of ethernet addresses when processing them.
> >
> > .../include/rte_ether.h:149:2: warning: converting a packed ‘const
> > struct ether_addr’ pointer (alignment 1) to a ‘unaligned_uint16_t’
> > {aka ‘const short unsigned int’} pointer (alignment 2) may result in
> > an unaligned pointer value [-Waddress-of-packed-member]
> > 149 | const unaligned_uint16_t *ea_words = (const unaligned_uint16_t *)ea;
> > | ^~~~~
> >
>
> Hi - There was a couple of these warnings in telemetry that were not
> squashed with the patch to disable the warning in 19.05. I was just
> about send a patch to address that when I saw this one.
>
> As your patch is aiming for a better solution, I won't send my patch for
> master but I'll still send to stable.
>
Good idea, thanks.
next prev parent reply other threads:[~2019-05-16 20:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 15:54 Bruce Richardson
2019-05-16 18:04 ` Kevin Traynor
2019-05-16 20:38 ` Bruce Richardson [this message]
2019-07-01 13:11 ` Olivier Matz
2019-07-01 13:38 ` Bruce Richardson
2019-07-01 14:14 ` Olivier Matz
2019-07-01 14:28 ` Bruce Richardson
[not found] ` <1e5856a8-108b-1f0c-6ce7-b7c9eafac658@sitilge.id.lv>
2020-02-05 13:45 ` Bruce Richardson
2020-02-09 19:32 ` Martins Eglitis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516203830.GC642@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).