From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B773AA00E6 for ; Thu, 16 May 2019 22:38:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 814235920; Thu, 16 May 2019 22:38:39 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id ECDC94D27 for ; Thu, 16 May 2019 22:38:36 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 13:38:35 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.252.2.218]) by orsmga007.jf.intel.com with SMTP; 16 May 2019 13:38:32 -0700 Received: by (sSMTP sendmail emulation); Thu, 16 May 2019 21:38:31 +0100 Date: Thu, 16 May 2019 21:38:30 +0100 From: Bruce Richardson To: Kevin Traynor Cc: Olivier Matz , Stephen Hemminger , DPDK Dev List Message-ID: <20190516203830.GC642@bricha3-MOBL.ger.corp.intel.com> References: <20190516155457.4006-1-bruce.richardson@intel.com> <0435f920-2ba1-e827-6bf1-96ac81ee9dbc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0435f920-2ba1-e827-6bf1-96ac81ee9dbc@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] ether: mark ethernet addresses as being 2-byte aligned X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 16, 2019 at 07:04:03PM +0100, Kevin Traynor wrote: > On 16/05/2019 16:54, Bruce Richardson wrote: > > When including the rte_ether.h header in applications with warnings > > enabled, a warning was given because of the assumption of 2-byte alignment > > of ethernet addresses when processing them. > > > > .../include/rte_ether.h:149:2: warning: converting a packed ‘const > > struct ether_addr’ pointer (alignment 1) to a ‘unaligned_uint16_t’ > > {aka ‘const short unsigned int’} pointer (alignment 2) may result in > > an unaligned pointer value [-Waddress-of-packed-member] > > 149 | const unaligned_uint16_t *ea_words = (const unaligned_uint16_t *)ea; > > | ^~~~~ > > > > Hi - There was a couple of these warnings in telemetry that were not > squashed with the patch to disable the warning in 19.05. I was just > about send a patch to address that when I saw this one. > > As your patch is aiming for a better solution, I won't send my patch for > master but I'll still send to stable. > Good idea, thanks.