From: Bruce Richardson <bruce.richardson@intel.com>
To: adham@mellanox.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: fix helloworld build on Windows
Date: Mon, 20 May 2019 10:04:24 +0100 [thread overview]
Message-ID: <20190520090423.GA1343@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190520081952.1046496-1-adham@mellanox.com>
On Mon, May 20, 2019 at 11:19:52AM +0300, adham@mellanox.com wrote:
> From: Adham Masarwah <adham@mellanox.com>
>
> The option -Dexamples=helloworld is missing.
> The helloworld binary name was wrong.
> Forcing clang may be required in some environments.
>
> Fixes: 196c650b8b63 ("doc: add guide for Windows")
>
> Signed-off-by: Adham Masarwah <adham@mellanox.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2019-05-20 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 8:19 adham
2019-05-20 9:04 ` Bruce Richardson [this message]
2019-05-29 10:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520090423.GA1343@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=adham@mellanox.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).