From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 26B4DA05D3 for ; Wed, 22 May 2019 12:51:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49CC825A1; Wed, 22 May 2019 12:51:02 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 51BF110BD; Wed, 22 May 2019 12:51:01 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2019 03:51:00 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.96]) by orsmga008.jf.intel.com with SMTP; 22 May 2019 03:50:57 -0700 Received: by (sSMTP sendmail emulation); Wed, 22 May 2019 11:50:56 +0100 Date: Wed, 22 May 2019 11:50:56 +0100 From: Bruce Richardson To: Jerin Jacob Kollanukkaran Cc: Neil Horman , "dev@dpdk.org" , "thomas@monjalon.net" , "stable@dpdk.org" Message-ID: <20190522105056.GA1368@bricha3-MOBL.ger.corp.intel.com> References: <20190521195628.16355-1-jerinj@marvell.com> <20190521202704.GA12605@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] devtools: skip the symbol check when map file under drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 22, 2019 at 03:05:54AM +0000, Jerin Jacob Kollanukkaran wrote: > > -----Original Message----- > > From: Neil Horman > > Sent: Wednesday, May 22, 2019 1:57 AM > > To: Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; thomas@monjalon.net; stable@dpdk.org > > Subject: [EXT] Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when > > map file under drivers > > > > On Wed, May 22, 2019 at 01:26:28AM +0530, jerinj@marvell.com wrote: > > > From: Jerin Jacob > > > > > > Drivers do not have ABI. > > > Skip the symbol check if map file under drivers directory. > > > > > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > > > > > Cc: stable@dpdk.org > > > Cc: Neil Horman > > > > > Sorry, but I'm not ok with this, because many of our DPDK PMDs have functions > > that get exported which are meant to be called by applications directly. The > > OK. Just to update my knowledge, Should those API needs to go through ABI/API > depreciation process? > > Actually, I am concerned about the APIs, which is called between drviers not > the application. For example, > drivers/common/dpaax/rte_common_dpaax_version.map > > it is not interface to application rather it is for intra driver case. > I think, I can change my logic to Skip the symbols which NOT starting with rte_. > Agree? > > Context: > I am adding a new driver/common/octeontx2 directory and it has some API which > Needs to shared between drivers not to the application. For me, it does not make > sense to go through any ABI process in such case. > > Maybe not, but other drivers will have APIs designed for apps to call directly - some NIC drivers have them, and I suspect that rawdev drivers will need them a lot. Therefore, it's best to have the drivers directory scanned by our tooling.