* [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch
@ 2019-05-23 7:45 Olivier Matz
2019-05-23 11:50 ` Thomas Monjalon
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Olivier Matz @ 2019-05-23 7:45 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon
Add the ability to pass custom options to checkpatch script. An example
of use is to change the output format so it can run in emacs compilation
mode:
DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
/path/to/dpdk.org/devtools/checkpatches.sh
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
devtools/checkpatches.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 6a01b39c8..bd0a93178 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -6,6 +6,7 @@
# - DPDK_CHECKPATCH_PATH
# - DPDK_CHECKPATCH_CODESPELL
# - DPDK_CHECKPATCH_LINE_LENGTH
+# - DPDK_CHECKPATCH_OPTIONS
. $(dirname $(readlink -e $0))/load-devel-config
VALIDATE_NEW_API=$(dirname $(readlink -e $0))/check-symbol-change.sh
@@ -33,6 +34,7 @@ PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
SPLIT_STRING,LONG_LINE_STRING,\
LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
NEW_TYPEDEFS,COMPARISON_TO_NULL"
+options="$options $DPDK_CHECKPATCH_OPTIONS"
clean_tmp_files() {
if echo $tmpinput | grep -q '^checkpatches\.' ; then
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch
2019-05-23 7:45 [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch Olivier Matz
@ 2019-05-23 11:50 ` Thomas Monjalon
2019-05-23 13:18 ` Bruce Richardson
2019-05-24 13:45 ` Ferruh Yigit
2019-05-24 14:04 ` Ferruh Yigit
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-05-23 11:50 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev
23/05/2019 09:45, Olivier Matz:
> Add the ability to pass custom options to checkpatch script. An example
> of use is to change the output format so it can run in emacs compilation
> mode:
>
> DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
> DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
> /path/to/dpdk.org/devtools/checkpatches.sh
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Except the usage example being with emacs,
Acked-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch
2019-05-23 11:50 ` Thomas Monjalon
@ 2019-05-23 13:18 ` Bruce Richardson
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2019-05-23 13:18 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Olivier Matz, dev
On Thu, May 23, 2019 at 01:50:41PM +0200, Thomas Monjalon wrote:
> 23/05/2019 09:45, Olivier Matz:
> > Add the ability to pass custom options to checkpatch script. An example
> > of use is to change the output format so it can run in emacs compilation
> > mode:
> >
> > DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
> > DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
> > /path/to/dpdk.org/devtools/checkpatches.sh
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Except the usage example being with emacs,
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
Yes, it should be for Windows Notepad instead. :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch
2019-05-23 7:45 [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch Olivier Matz
2019-05-23 11:50 ` Thomas Monjalon
@ 2019-05-24 13:45 ` Ferruh Yigit
2019-07-04 20:44 ` Thomas Monjalon
2019-05-24 14:04 ` Ferruh Yigit
2 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2019-05-24 13:45 UTC (permalink / raw)
To: Olivier Matz, dev; +Cc: Thomas Monjalon
On 5/23/2019 8:45 AM, Olivier Matz wrote:
> Add the ability to pass custom options to checkpatch script. An example
> of use is to change the output format so it can run in emacs compilation
> mode:
>
> DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
> DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
> /path/to/dpdk.org/devtools/checkpatches.sh
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch
2019-05-24 13:45 ` Ferruh Yigit
@ 2019-07-04 20:44 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-07-04 20:44 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev, Ferruh Yigit
24/05/2019 15:45, Ferruh Yigit:
> On 5/23/2019 8:45 AM, Olivier Matz wrote:
> > Add the ability to pass custom options to checkpatch script. An example
> > of use is to change the output format so it can run in emacs compilation
> > mode:
> >
> > DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
> > DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
> > /path/to/dpdk.org/devtools/checkpatches.sh
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch
2019-05-23 7:45 [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch Olivier Matz
2019-05-23 11:50 ` Thomas Monjalon
2019-05-24 13:45 ` Ferruh Yigit
@ 2019-05-24 14:04 ` Ferruh Yigit
2 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-05-24 14:04 UTC (permalink / raw)
To: Olivier Matz, dev; +Cc: Thomas Monjalon
On 5/23/2019 8:45 AM, Olivier Matz wrote:
> Add the ability to pass custom options to checkpatch script. An example
> of use is to change the output format so it can run in emacs compilation
> mode:
>
> DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
> DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
> /path/to/dpdk.org/devtools/checkpatches.sh
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-04 20:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 7:45 [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch Olivier Matz
2019-05-23 11:50 ` Thomas Monjalon
2019-05-23 13:18 ` Bruce Richardson
2019-05-24 13:45 ` Ferruh Yigit
2019-07-04 20:44 ` Thomas Monjalon
2019-05-24 14:04 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).