From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 22D20A05D3 for ; Thu, 23 May 2019 17:32:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E32A1B945; Thu, 23 May 2019 17:32:51 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1D7BC3DC for ; Thu, 23 May 2019 17:32:49 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 May 2019 08:32:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,503,1549958400"; d="scan'208";a="174792406" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.96]) by fmsmga002.fm.intel.com with SMTP; 23 May 2019 08:32:46 -0700 Received: by (sSMTP sendmail emulation); Thu, 23 May 2019 16:32:46 +0100 Date: Thu, 23 May 2019 16:32:45 +0100 From: Bruce Richardson To: Ali Alnubani Cc: "dev@dpdk.org" , "bluca@debian.org" Message-ID: <20190523153245.GA1388@bricha3-MOBL.ger.corp.intel.com> References: <20190523145358.1492-1-alialnu@mellanox.com> <20190523145358.1492-2-alialnu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190523145358.1492-2-alialnu@mellanox.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 2/2] examples: enable building multiprocess applications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 23, 2019 at 02:54:13PM +0000, Ali Alnubani wrote: > This enables building the example multiprocess applications in > the subdirectory multi_process. > > Signed-off-by: Ali Alnubani > --- > examples/meson.build | 8 +++++++- > .../client_server_mp/mp_client/meson.build | 14 ++++++++++++++ > .../client_server_mp/mp_server/meson.build | 14 ++++++++++++++ > examples/multi_process/hotplug_mp/meson.build | 12 ++++++++++++ > examples/multi_process/simple_mp/meson.build | 12 ++++++++++++ > .../multi_process/{ => symmetric_mp}/meson.build | 8 +++++--- > 6 files changed, 64 insertions(+), 4 deletions(-) > create mode 100644 examples/multi_process/client_server_mp/mp_client/meson.build > create mode 100644 examples/multi_process/client_server_mp/mp_server/meson.build > create mode 100644 examples/multi_process/hotplug_mp/meson.build > create mode 100644 examples/multi_process/simple_mp/meson.build > rename examples/multi_process/{ => symmetric_mp}/meson.build (68%) > > diff --git a/examples/meson.build b/examples/meson.build > index 53a786eb4..647114c23 100644 > --- a/examples/meson.build > +++ b/examples/meson.build > @@ -24,7 +24,7 @@ all_examples = [ > 'l2fwd-keepalive', 'l3fwd', > 'l3fwd-acl', 'l3fwd-power', > 'l3fwd-vf', 'link_status_interrupt', > - 'load_balancer', 'multi_process', > + 'load_balancer', > 'netmap_compat', 'packet_ordering', > 'performance-thread', 'ptpclient', > 'qos_meter', 'qos_sched', > @@ -35,6 +35,12 @@ all_examples = [ > 'vhost', 'vhost_crypto', > 'vhost_scsi', 'vm_power_manager', > 'vmdq', 'vmdq_dcb', > + 'multi_process/simple_mp', > + 'multi_process/hotplug_mp', > + 'multi_process/symmetric_mp', > + 'multi_process/client_server_mp/mp_server', > + 'multi_process/client_server_mp/mp_client', > + > ] Since these are in alphabetical order, I think we should keep the multi-process apps in the list in the correct order, rather than at the end. > # install all example code on install - irrespective of whether the example in > # question is to be built as part of this build or not. > diff --git a/examples/multi_process/client_server_mp/mp_client/meson.build b/examples/multi_process/client_server_mp/mp_client/meson.build > new file mode 100644 > index 000000000..196c39fc5 > --- /dev/null > +++ b/examples/multi_process/client_server_mp/mp_client/meson.build > @@ -0,0 +1,14 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2019 Mellanox Technologies, Ltd > + > +# meson file, for building this example as part of a main DPDK build. > +# > +# To build this example as a standalone application with an already-installed > +# DPDK instance, use 'make' > + > +includes += include_directories('../shared') > + > +name = 'mp_client' I believe your previous patch in this set already set up the names correctly for these apps, so I think you should remove this and the other name assignment lines in the other files. I'd like to try and enforce consistency in naming, and not having overrides of the name value in the individual app meson.build files is key to enforcing that consistency. Otherwise, thanks for doing this, and the rest of the patch looks fine to me. /Bruce