DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: matan@mellanox.com
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
	Stephen Hemminger <sthemmin@microsoft.com>
Subject: [dpdk-dev] [PATCH] net/vdev_netvsc: print warning if Mellanox devices are not configured
Date: Thu, 23 May 2019 15:01:24 -0700	[thread overview]
Message-ID: <20190523220124.18818-1-stephen@networkplumber.org> (raw)

Several users have run into problems where the MLX drivers were not
enabled in their build. And then trying to run their DPDK
application on Azure. What happens is that all packets
go over the slow path, and failsafe repeatedly probes for never
existing sub-device.

Both Mellanox drivers should be checked. MLX4 for current versions,
and MLX5 for future upgrades. This code is only called if Hyper-V/Azure
is detected.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 drivers/net/vdev_netvsc/vdev_netvsc.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
index 801f54c96e01..64f9dbf66e18 100644
--- a/drivers/net/vdev_netvsc/vdev_netvsc.c
+++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
@@ -812,6 +812,13 @@ vdev_netvsc_scan_callback(__rte_unused void *arg)
 	struct rte_devargs *devargs;
 	struct rte_bus *vbus = rte_bus_find_by_name("vdev");
 
+#ifndef RTE_LIBRTE_MLX4_PMD
+	DRV_LOG(WARNING, "Mellanox MLX4 not configured.");
+#endif
+#ifndef RTE_LIBRTE_MLX5_PMD
+	DRV_LOG(WARNING, "Mellanox MLX5 not configured.");
+#endif
+
 	RTE_EAL_DEVARGS_FOREACH("vdev", devargs)
 		if (!strncmp(devargs->name, VDEV_NETVSC_DRIVER_NAME,
 			     VDEV_NETVSC_DRIVER_NAME_LEN))
-- 
2.20.1


             reply	other threads:[~2019-05-23 22:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 22:01 Stephen Hemminger [this message]
2019-05-24 13:26 ` Ferruh Yigit
2019-05-24 16:07   ` Stephen Hemminger
2019-05-24 16:38     ` Thomas Monjalon
2019-05-24 16:48       ` Stephen Hemminger
2019-05-24 17:05         ` Thomas Monjalon
2019-05-24 17:11           ` Stephen Hemminger
2019-05-24 17:32             ` Thomas Monjalon
2019-05-24 22:06               ` Stephen Hemminger
2019-05-27  8:31                 ` Thomas Monjalon
2019-05-27 14:54                   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523220124.18818-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).