From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 21DE8A05D3 for ; Fri, 24 May 2019 18:48:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E71FC343C; Fri, 24 May 2019 18:48:16 +0200 (CEST) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 00ECA2C16 for ; Fri, 24 May 2019 18:48:14 +0200 (CEST) Received: by mail-pf1-f195.google.com with SMTP id z28so5669569pfk.0 for ; Fri, 24 May 2019 09:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Gu7H9UUt5UUbXpytgVrZ11yyIQhBsm+ZD8sYg0XaAzQ=; b=ibCIed3QIodSyN39pY+Kywhw7nldMJaNibFzTSiWmo5D0rMR3uM8/nYEy4cvZCzWb7 Dvy+OGVLCv3xIJf8LF9iXaRQbZSY5wxFdmnPJn2lCb+uU/iwNauxsAF1yRcn63lXJwB6 w5JVy8jaTUqqqPJZwBYSLyq36B/K65DpuDbPn6Wxz8uhO3gDQNr1He7zop4zKWvKiDq6 tni6yLYqW/8/dm1e8exJ88PMjKm8CENrqG+0cVRdJ/6yCefnlWhlj7uAKg0xhajrODVo eURcoesIE/2Mqx+Q67AFlhrN98PIeb9Xmbh5oaKCiL2m6lY30MLq3uH5vHgNtv2OjY09 6N/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Gu7H9UUt5UUbXpytgVrZ11yyIQhBsm+ZD8sYg0XaAzQ=; b=GnutePwzEGfcDCFT6IeikWkbfQV79TvSeApA3mH4Lz2kc9xXVsRoWBxXgIsoHrlTwc KX7q78Yr/nnSton9bC9O5g1/Nn4zHAERX5jDxF7p5EcbykK8oNKu6fgx+B7Coyv8uKlr uu+Y1V9/bzyLELxAaZuuQrAztT74h6xtzdZ717TqKgv2v39yL2xlsVEQgVxEWMdkcjME buiZOBhuwCafsGvgb1PbYguBbEXUM7sOCZUzSdlV9GdNBGIj7mHzDUFbDXV2at2u1m+B fShoo2Ok+mOew2IGPuARy1BE6ngEpAo0zaWcE5yjOB53LmatX/w+iSg7whzu2GEpZnrN xusw== X-Gm-Message-State: APjAAAXmkGe7NhqD/y0T589EJ7V1nt6ZBeocO1a26GDrmcGvdwby3RbE VCbF9+2HeWWdqQr8TDXatPqfcayLWCM= X-Google-Smtp-Source: APXvYqwhiMfxqwSFcelq5mUxfAhtkxOdnSJkGZy1dc2nrtkZnXm6Vx3CugDdl5MbgHW9A2n8ZLVaRg== X-Received: by 2002:a63:2c01:: with SMTP id s1mr106960028pgs.261.1558716494191; Fri, 24 May 2019 09:48:14 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w66sm3669398pfb.47.2019.05.24.09.48.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 May 2019 09:48:14 -0700 (PDT) Date: Fri, 24 May 2019 09:48:12 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, Ferruh Yigit , matan@mellanox.com, Stephen Hemminger Message-ID: <20190524094812.1d4aba4c@hermes.lan> In-Reply-To: <11553980.mcJyG3iUic@xps> References: <20190523220124.18818-1-stephen@networkplumber.org> <20190524090749.086ef683@hermes.lan> <11553980.mcJyG3iUic@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/vdev_netvsc: print warning if Mellanox devices are not configured X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 24 May 2019 18:38:53 +0200 Thomas Monjalon wrote: > 24/05/2019 18:07, Stephen Hemminger: > > On Fri, 24 May 2019 14:26:40 +0100 > > Ferruh Yigit wrote: > > > > > On 5/23/2019 11:01 PM, Stephen Hemminger wrote: > > > > Several users have run into problems where the MLX drivers were not > > > > enabled in their build. And then trying to run their DPDK > > > > application on Azure. What happens is that all packets > > > > go over the slow path, and failsafe repeatedly probes for never > > > > existing sub-device. > > > > > > > > Both Mellanox drivers should be checked. MLX4 for current versions, > > > > and MLX5 for future upgrades. This code is only called if Hyper-V/Azure > > > > is detected. > > > > > > > > Signed-off-by: Stephen Hemminger > > > > --- > > > > drivers/net/vdev_netvsc/vdev_netvsc.c | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c > > > > index 801f54c96e01..64f9dbf66e18 100644 > > > > --- a/drivers/net/vdev_netvsc/vdev_netvsc.c > > > > +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c > > > > @@ -812,6 +812,13 @@ vdev_netvsc_scan_callback(__rte_unused void *arg) > > > > struct rte_devargs *devargs; > > > > struct rte_bus *vbus = rte_bus_find_by_name("vdev"); > > > > > > > > +#ifndef RTE_LIBRTE_MLX4_PMD > > > > + DRV_LOG(WARNING, "Mellanox MLX4 not configured."); > > > > +#endif > > > > +#ifndef RTE_LIBRTE_MLX5_PMD > > > > + DRV_LOG(WARNING, "Mellanox MLX5 not configured."); > > > > +#endif > > > > > > Is it OK a virtual PMD being this much aware of another PMD? > > > Can it be an option to add this check into build system? And if there is direct > > > dependency perhaps even don't compile the 'vdev_netvsc' when none mlx PMD is > > > enabled. > > > > vdev_netvsc is not a device, it is really just a hack to start other > > device drivers on Hyper-V/Azure. If the build system supported dependencies > > (like Linux kbuild) this would not be necessary. Meson only does dynamic dependencies > > so that doesn't help. > > > > This is a warning and not fatal only because application will still at > > least run, and somebody may want to run with SR-IOV with Intel NIC's on Hyper-V. > > > > > > The warning is just to give users better immediate feedback rather than > > trying to diagnose poor performance or mystery device not found messages. > > > It really looks strange to me. > What you need is to fail at compilation if requested PMD is not built. > I would advise to work on a script to configure meson. None of the people that ran into this were using meson build. For example, VPP doesn't use meson.