From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
matan@mellanox.com, Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] net/vdev_netvsc: print warning if Mellanox devices are not configured
Date: Fri, 24 May 2019 10:11:08 -0700 [thread overview]
Message-ID: <20190524101108.574621c8@hermes.lan> (raw)
In-Reply-To: <2341346.KjBqQsXUje@xps>
On Fri, 24 May 2019 19:05:20 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > device drivers on Hyper-V/Azure. If the build system supported dependencies
> > > > (like Linux kbuild) this would not be necessary. Meson only does dynamic dependencies
> > > > so that doesn't help.
> > > >
> > > > This is a warning and not fatal only because application will still at
> > > > least run, and somebody may want to run with SR-IOV with Intel NIC's on Hyper-V.
> > > >
> > > >
> > > > The warning is just to give users better immediate feedback rather than
> > > > trying to diagnose poor performance or mystery device not found messages.
> > >
> > >
> > > It really looks strange to me.
> > > What you need is to fail at compilation if requested PMD is not built.
> > > I would advise to work on a script to configure meson.
> >
> > None of the people that ran into this were using meson build.
> > For example, VPP doesn't use meson.
>
> They will use meson when makefile will be removed :)
>
> Anyway, no matter the build system, what we want is a way
> to guide users to a proper DPDK installation.
> Your solution is to add some very specific logs.
> My proposal is to guide the user with a script and some
> specific parameters so it will fail if a required dependency is not met.
Not familiar enough with meson magic syntax to make vdev_netvsc not build
without MLX. But that would just be pushing the mystery failure further
down the road.
Another alternative would be to drop vdev_netvsc from the default Linux
build. That way users would have to enable it manually.
My preferred solution would be to just kill vdev_netvsc and go to only netvsc PMD
but that is a couple releases away.
next prev parent reply other threads:[~2019-05-24 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 22:01 Stephen Hemminger
2019-05-24 13:26 ` Ferruh Yigit
2019-05-24 16:07 ` Stephen Hemminger
2019-05-24 16:38 ` Thomas Monjalon
2019-05-24 16:48 ` Stephen Hemminger
2019-05-24 17:05 ` Thomas Monjalon
2019-05-24 17:11 ` Stephen Hemminger [this message]
2019-05-24 17:32 ` Thomas Monjalon
2019-05-24 22:06 ` Stephen Hemminger
2019-05-27 8:31 ` Thomas Monjalon
2019-05-27 14:54 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524101108.574621c8@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=sthemmin@microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).