From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 482BBA046B for ; Tue, 28 May 2019 16:07:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BED1F2E8F; Tue, 28 May 2019 16:07:02 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id D99051B05 for ; Tue, 28 May 2019 16:07:00 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id h2so8004460pgg.1 for ; Tue, 28 May 2019 07:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mv/nvaYqPxpKbuKMhHL7Tl6PlvZ3k5Dks0/40Wb/gcM=; b=kdlWts40KTKCAdfZRtpP+5YdAxFzs99EJihQGP4BWyM027HOJUclrLLgxszADt6YuI OCj8Q3S7P/uTwpqbp6Xo5SF3sEuAionWxe8Js0RLCVjxqcjjolHKjlV4/nGCopLpc/dc uHOrfLfax+K8Nj40d6aY2u2AR3nLyt6VkxKyz0cMx+CupPC4o45csYD0AfB8F3XDyReM 3MRwCu12THsw9n1R1mPn9soVW8IVadvXaMkEFGO6pGqKsFozZig4m+wWBoSyfc5N2dPx 0MuJYSBJ3JB6AoCGGcYzcRjDrtH8Eh54N7edGbQTkh5Hb4v5IRH8EUwpjAGD2rfXPkk+ rSpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mv/nvaYqPxpKbuKMhHL7Tl6PlvZ3k5Dks0/40Wb/gcM=; b=KYXVGYgWGUyc89KraMlhETCJ8wEregHD/ZpnJq6k+nPqsuyuWWGMpwOzdRLzL2fBg5 ViBMp4BozyqmCmwzc1PkVfqclAvTFD1PRa3iMdpt6MFRgF909lY/xpcN7a7H6Xi3RZe+ 7GBzExr4cgthYx9PYVS+Ji3J7+F+rJtgcOLmT1+CBnbL8o2FnlIzBTCKN24F09uytMCB GiM4DrgpN3jy7lNS3TvQPOVYFuezPeozuv9BCvyLCMSGhqwohGQpWNa7GrVdrf/pGFLB SoWIIiW8CPO0xuKfVKYoc/eLnZ7/0iBsoW92NXVfW2TQ+kgjQPZJcEBgWWMa7lxc4fUu wBJg== X-Gm-Message-State: APjAAAUV1stPH9V0/C0Ii4yhdzVd5k8pCjcfB2t5q0ww9sYVYU3+H7N6 TBhy32oOIsMZgD8rrJ7JKFgjCw== X-Google-Smtp-Source: APXvYqzZkzgeReGVu0iEaN7MrsRU3rXiid0Ag6AjBXy0N9XvpRqooM2sMp2qEL3Spfyf4UY6YCUuyw== X-Received: by 2002:a63:18e:: with SMTP id 136mr103714555pgb.277.1559052420024; Tue, 28 May 2019 07:07:00 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z9sm13281020pgc.82.2019.05.28.07.06.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 07:06:59 -0700 (PDT) Date: Tue, 28 May 2019 07:06:58 -0700 From: Stephen Hemminger To: Lukasz Krakowiak Cc: cristian.dumitrescu@intel.com, dev@dpdk.org, Jasvinder Singh , Abraham Tovar Message-ID: <20190528070658.2c3c9c3c@hermes.lan> In-Reply-To: <20190528120553.2992-8-lukaszx.krakowiak@intel.com> References: <20190528120553.2992-1-lukaszx.krakowiak@intel.com> <20190528120553.2992-8-lukaszx.krakowiak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 07/27] sched: update pipe profile add api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 28 May 2019 14:05:33 +0200 Lukasz Krakowiak wrote: > > static int > pipe_profile_check(struct rte_sched_pipe_params *params, > - uint32_t rate) > + uint32_t rate, uint16_t *qsize) > { > uint32_t i; > > /* Pipe parameters */ > if (params == NULL) > - return -10; > + return -11; Having used this before, and suffered from the error handling. Please change this to do proper logging and use a normal convention for error numbers. This is not in fast path, it should be more user friendly.