From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 64C57A046B for ; Wed, 29 May 2019 06:59:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D62E37A2; Wed, 29 May 2019 06:59:28 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 7A8D137A2 for ; Wed, 29 May 2019 06:59:26 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id u22so803643pfm.3 for ; Tue, 28 May 2019 21:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gycEFB5eK6PdvHPjiGLtlgbPdcnrHNACy2hOk3GwU14=; b=0hKmp33lAEswl/2meyQ0wnVqoMrDbjLwUXMMTcRWYbVdDqzSxHW/Bn2tIi7/OJ+BlP /2CuN5XasV9pgtu1H1/j3xcq4RebeWQhflZ94ZwepthU3rDAPwu7/+gLyEbsLpO8ZZCD MsmyoNjB+I02X2Elx/uk3XyP8ELiNmp5EQDMT4LVp+88weiRZkIxJ/oBSX0zWNg4HaZ/ kwAWYWQMM94b9h4vlIbi3+juabisgff/ILs98n7BJY6jVSIeXmpQVRMZNpF0TKsNBsqa PjxzHBbSEJ2rG3DEPmUEhR3v1tb8apWF/CDvrmP0jnv5bjVybmCpqZYFYku2V1ZhQCaf YAcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gycEFB5eK6PdvHPjiGLtlgbPdcnrHNACy2hOk3GwU14=; b=FvcrFz9uCT0IuWkODtEH/pFGRXsN0d+4lEy+8SuxOII/4rCknDJXrUjsEbvBjaavhs YDbBK4BSw4kRSx+f8ttw9jcwGm4GLe5r3jKFYZy9Kj/AZh0DoJ6Zlbanevo8kXhhC5vC 6RyW59ZVYvLYRc6lIcJkrzrJh20weBgwdKGjVUme8r94Hp1bIkl+GwDIWHDRHMyU5eMQ PJTK6O/WczZ9dOwaJ/DJMZxDQ/W7pZX3/1mcLletzva/fLoJ0F4551KPiG+IUBP8Da2z U/Z2y/kmjIM1ipiFgEiUupaDRr1iK1FCwWUdnZ3YcTINSp+8IeJUUxrtCAT1bFnSpJL5 IlBg== X-Gm-Message-State: APjAAAUJzg/V3XRgLYH2//8ALVcHk5bfhryVbHL/BT3H5jmcs/TN9mXr TlDJENHoA2la+db1oUxUAv5dww== X-Google-Smtp-Source: APXvYqwI4Z0O7GcOLmrLVwWikM/7scMHuO8ed1pU2VyLl9h5LeNT0WcSoHC706ZyDYzPCsVqmIor2g== X-Received: by 2002:a17:90b:d8c:: with SMTP id bg12mr10032200pjb.70.1559105965318; Tue, 28 May 2019 21:59:25 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q125sm22301167pfq.62.2019.05.28.21.59.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 21:59:25 -0700 (PDT) Date: Tue, 28 May 2019 21:59:23 -0700 From: Stephen Hemminger To: Ziyang Xuan Cc: , , , , , Message-ID: <20190528215923.6e2a5a9f@hermes.lan> In-Reply-To: <185ce730f156c964c84344a4173882bdbbdd8509.1559100649.git.xuanziyang2@huawei.com> References: <185ce730f156c964c84344a4173882bdbbdd8509.1559100649.git.xuanziyang2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 08/11] net/hinic: add hinic PMD build and doc files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 29 May 2019 11:50:36 +0800 Ziyang Xuan wrote: > +Huawei hinic > +M: Xiaoyun Wang > +M: Ziyang Xuan > +M: Guoyang Zhou > +M: Rami Rosen You should remove Rami, he will be missed. > diff --git a/drivers/net/hinic/base/hinic_logs.c b/drivers/net/hinic/base/hinic_logs.c > new file mode 100644 > index 000000000..1e9b5ad92 > --- /dev/null > +++ b/drivers/net/hinic/base/hinic_logs.c > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2017 Huawei Technologies Co., Ltd > + */ > + > + > +#include "hinic_logs.h" > + > +int hinic_logtype; > + > +RTE_INIT(hinic_init_log) > +{ > + hinic_logtype = rte_log_register("pmd.net.hinic"); > + if (hinic_logtype >= 0) > + rte_log_set_level(hinic_logtype, RTE_LOG_INFO); > +} > + You could just put this in some other file > diff --git a/drivers/net/hinic/base/hinic_logs.h b/drivers/net/hinic/base/hinic_logs.h > new file mode 100644 > index 000000000..ed84a37a6 > --- /dev/null > +++ b/drivers/net/hinic/base/hinic_logs.h > @@ -0,0 +1,31 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2017 Huawei Technologies Co., Ltd > + */ > + > +#ifndef _HINIC_LOGS_H_ > +#define _HINIC_LOGS_H_ > + > +#ifdef __cplusplus > +#if __cplusplus > +extern "C"{ > +#endif > +#endif /* __cplusplus */ > +#include Why all the C++ guards, this is a private file. > +error_cflags = ['-Wno-unused-value', > + '-Wno-unused-but-set-variable', > + '-Wno-unused-variable', > +] Please fix these errors instead of masking them > +/** > + * Atomically writes the link status information into global > + * struct rte_eth_dev. > + */ > +int hinic_dev_atomic_write_link_status(struct rte_eth_dev *dev, > + struct rte_eth_link *link) > +{ > + struct rte_eth_link *dst = &dev->data->dev_link; > + struct rte_eth_link *src = link; > + > + if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst, > + *(uint64_t *)src) == 0) > + return HINIC_ERROR; > + > + return HINIC_OK; > +} There already is code in rte_ethdev in current versions of DPDK to do this.