From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 84B71A0465 for ; Wed, 29 May 2019 11:18:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 35BB437A2; Wed, 29 May 2019 11:18:03 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id B3B262C55 for ; Wed, 29 May 2019 11:18:01 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 02:18:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,526,1549958400"; d="scan'208";a="179516560" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.64]) by fmsmga002.fm.intel.com with SMTP; 29 May 2019 02:17:58 -0700 Received: by (sSMTP sendmail emulation); Wed, 29 May 2019 10:17:57 +0100 Date: Wed, 29 May 2019 10:17:57 +0100 From: Bruce Richardson To: Shreyansh Jain Cc: ferruh.yigit@intel.com, stephen@networkplumber.org, bluca@debian.org, dev@dpdk.org Message-ID: <20190529091757.GA1099@bricha3-MOBL.ger.corp.intel.com> References: <20190529064716.14344-1-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190529064716.14344-1-shreyansh.jain@nxp.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] common/dpaax: fix i686 compilation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 29, 2019 at 12:17:16PM +0530, Shreyansh Jain wrote: > Meson build on i686, part of DPDK CI, reports: (example report [1]) > *Meson Failed Build #1: > OS: UB1604-32 > Target: i686-native-linuxapp-gcc > ../drivers/common/dpaax/dpaax_iova_table.c:121:3: note: in expansion of > macro ‘DPAAX_DEBUG’ > DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)", > ^ > > 'statbuf.st_size', part of fstat() is a 'off_t' - which should be printable > as '%lu'. But, only a particularly old compiler reports this (5.4.0). > For now, removing the variable being dumped as part of debug. > > [1] http://mails.dpdk.org/archives/test-report/2019-May/082622.html > > Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") > Cc: shreyansh.jain@nxp.com > > Signed-off-by: Shreyansh Jain > --- > Note: > - Another option was to use the PRIu32 macros but, in absence of a proper > verification environment, I wish to take the safer route. In future, if > need arises, the field would be added to debug logs. > Actually, I think it's a bit more complicated than that, since for meson and make builds, the type and size of the offset field varies. I've already posted a fix for this and other 32-bit build issues. Please review that, and let me know what you think. Ref: http://patches.dpdk.org/patch/53728/ Ref: http://patches.dpdk.org/project/dpdk/list/?series=4792 Regards, /Bruce