From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 79CB0A045E for ; Wed, 29 May 2019 18:40:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F5DB1B994; Wed, 29 May 2019 18:40:53 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 4CCB71B951 for ; Wed, 29 May 2019 18:40:52 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id q17so1977864pfq.8 for ; Wed, 29 May 2019 09:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E8IyXQT6I8Q9Zz8hFe/22/6WXcvQjkeb+BbelE3y+FY=; b=N27op3IraSH9B5jVeH3blWYLeTR2sqW/OxP2qIa8byd9BIYPUva3VaVhEFyQPKCv1A SNEOhEskAaf9XJcEAjuSCzyyB9SUwKOjpqrJ8QirIVgtjXRx60zIpmBmB3dFWz+oOZzW uR8chDRe0pdM+Eu/xHVNxgAaYTaiWP/caae4G6X8mRJ5cBqe2ZPnmI+S08vvxTQR4gUx zWgylkyRjF+lYcYiD81HJIw6j+IGD3slU+T2383h6vuCPgjV7lL6X2JsiiVcBgzgQW3q RV4zbhosljWTIy0dduBjcqgva1cQa5d9DwOHRAjhCx2xWCH429zUJ5TAKlvNg6CO4CHQ 3pPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E8IyXQT6I8Q9Zz8hFe/22/6WXcvQjkeb+BbelE3y+FY=; b=cFgGGDzP23mH+YgRFlYlKyj/cQbMXT3pFFFOgtOWrBZ3ZIyVGXiZCXZZccFCTV05vS g12cpPVxyg9E3Pa+/IKpESh6oFq+zBbO8pruCsrsUrCx/MO23GatZZieOPMoyOxEhFNT yoagatbleNeQU3kN7gbcMtbBYwYLJUjJSoEWas+HB55zz7MuJvrDqO2yUF4Wv/23YmRi a0t2BT+3/VNR41lioMEY6jYXhxVuNlSSqm20Jc/bkkCY7yPPNj8pyqqMv+Ffi5tldbuz maXSCPxlvEKMkfQceYz/zfVe9PEuZ9ELs7MMzbUqDdbtR/LSGYl8UkiDXelMarCSvYT/ 7BNw== X-Gm-Message-State: APjAAAVYXmpe6vwi6d19q0lnfF1+VTtmCPmXSQYKPVH1ZaS5WGrjIV+j oNaN8IoOvAPMrhht+uehbh8+MQ== X-Google-Smtp-Source: APXvYqxtiSy+U0ASRCsSgHwWgbqFzftDWde5i8q465fbNCHMQi8Dn5E1iDpsNkqLAFUc/f8kzEVXcg== X-Received: by 2002:a63:d205:: with SMTP id a5mr49119075pgg.402.1559148051531; Wed, 29 May 2019 09:40:51 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p16sm147623pff.35.2019.05.29.09.40.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 09:40:51 -0700 (PDT) Date: Wed, 29 May 2019 09:40:49 -0700 From: Stephen Hemminger To: Anatoly Burakov Cc: dev@dpdk.org, Konstantin Ananyev , David Hunt , Bruce Richardson , Byron Marohn , Pablo de Lara Guarch , Yipeng Wang , Sameh Gobriel , Vladimir Medvedkin , Olivier Matz , Andrew Rybchenko , Reshma Pattan , thomas@monjalon.net, david.marchand@redhat.com Message-ID: <20190529094049.3cdd7dcd@hermes.lan> In-Reply-To: <6551141356fbab88a06c94e54348177939be60b5.1559147228.git.anatoly.burakov@intel.com> References: <6551141356fbab88a06c94e54348177939be60b5.1559147228.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 25/25] eal: hide shared memory config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 29 May 2019 17:31:11 +0100 Anatoly Burakov wrote: > +static inline void > +rte_eal_mcfg_wait_complete(struct rte_mem_config *mcfg) > +{ > + /* wait until shared mem_config finish initialising */ > + while (mcfg->magic != RTE_MAGIC) > + rte_pause(); > +} > Not fast path, why is this inline? > +#endif // EAL_MEMCFG_H Avoid C++ style comments.