From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 22AC8A045E for ; Thu, 30 May 2019 00:51:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E2C065680; Thu, 30 May 2019 00:51:45 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 5204C4F91 for ; Thu, 30 May 2019 00:51:44 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id g9so1675493plm.6 for ; Wed, 29 May 2019 15:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BK8g+JZJsmXyPqK5stjFHcIeMTA/xuXElpbQGqhlUaY=; b=BcCDmW6/uZhLTSKa2cX64WhTGOv1zqzzBLmzSv5eCpJM/89lbwTxFs7KXt9hmw4Y9p KjJHnTL2on7MWcXvE3RP9cVHWVy7ddQnydnBf+/wTmA55Y3YcKDh1QKPSz64DgUdKP6c cZBsCJ+3UtPH+JXKduvumyGQY4YYlHkvRwodHIWySInWSCXKr1o8nDA9l+9xmOLE7Gve C3TdFreejcQV04cJH/Ju5/8+2b31DW0IY1Go2iT9hQOhjSyLtRY8DlDTKM5ZmFwyB3wk ZyaGcYbWVBijJRNHzqucEuyKUjwhy5BxcSRrvgrCi6Xxls6pr06RLiqvF4wZ3iZg1WQH DsgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BK8g+JZJsmXyPqK5stjFHcIeMTA/xuXElpbQGqhlUaY=; b=tkdYmMCeDyu30SpN5RdLOb1L+0OmynAKBL3vjRwPZQbvmxayAXD9QhI1jDKPlAYDsD xZo+BdBbtcJVMsXaIXh7uQwQCeuvBOxIztykKzt0/FDe3pA4P6XKglSpLk0TNV/5OArN E+Xvub1T4EOVhliIT7rScbF8wKR05lnP+/xWYulGyvAu02tnLyMrmYIbvqlh5t79yOSl qHLsX0gfmuwVOQzahyFtOLYoqG8ZjYP8R5jDlzxPLUTFhaUd5c0JZ7lnTh4+bYSoMIAD OFTPgbLmVP/n+H9aQfy3KufB8s/9955kSvRmP3BalxRSAlrGFQelid3CnBITxV6tcLOj kAUQ== X-Gm-Message-State: APjAAAWwGyABweKV9bGN1r/XX3qGBY4dWyEgC37L9cSEHaiWFqR6aolm clnwwKTsvhVHU0wMDU2SKxlc+w== X-Google-Smtp-Source: APXvYqy5LdKkZu6Kx3Fcx4tBQxSBjlBG2n6OYtbCQ7knR1Wy1yy44KTB8TCeB6bGtgrmv4sekLegAQ== X-Received: by 2002:a17:902:1125:: with SMTP id d34mr428179pla.101.1559170303454; Wed, 29 May 2019 15:51:43 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q4sm384962pgb.39.2019.05.29.15.51.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 15:51:43 -0700 (PDT) Date: Wed, 29 May 2019 15:51:41 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, David Marchand , ktraynor@redhat.com, nhorman@tuxdriver.com, bluca@debian.org, bruce.richardson@intel.com Message-ID: <20190529155141.5d773396@hermes.lan> In-Reply-To: <1721310.r4ByrxUKRB@xps> References: <20190408182510.16078-1-stephen@networkplumber.org> <1558619942-9723-1-git-send-email-david.marchand@redhat.com> <1558619942-9723-3-git-send-email-david.marchand@redhat.com> <1721310.r4ByrxUKRB@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/5] eal: add lcore accessors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 30 May 2019 00:46:30 +0200 Thomas Monjalon wrote: > 23/05/2019 15:58, David Marchand: > > From: Stephen Hemminger > > > > The fields of the internal EAL core configuration are currently > > laid bare as part of the API. This is not good practice and limits > > fixing issues with layout and sizes. > > > > Make new accessor functions for the fields used by current drivers > > and examples. > [...] > > +DPDK_19.08 { > > + global: > > + > > + rte_lcore_cpuset; > > + rte_lcore_index; > > + rte_lcore_to_cpu_id; > > + rte_lcore_to_socket_id; > > + > > +} DPDK_19.05; > > + > > EXPERIMENTAL { > > global: > > Just to make sure, are we OK to introduce these functions > as non-experimental? They were in previous releases as inlines this patch converts them to real functions.