From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 62610A045E for ; Wed, 29 May 2019 21:16:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20FB21B9AC; Wed, 29 May 2019 21:15:21 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 832B91B959 for ; Wed, 29 May 2019 21:15:09 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id h17so475901pgv.0 for ; Wed, 29 May 2019 12:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gSnXwIFnTv6UYY3D3EYXQiuIw8trSygVlcI8ZjxvfG4=; b=OiqUGMSS7KenSlzhA1unfpKe2oqmwBL8GUaPeaPNo/a+X6MKWqEwaKbeSwvpHTgTtF pyGlyF6H9PT2DqhJEf8LLMnvcTLvC+g5/NznQ48JzX3M8ke19nYM6Py+cCdsoqQQMc5u br0JQ+sjjnkQkrXjv5XzKVHTpVyV7O6gpPANs8DGlPAUK6sOyovZXnuayAI3pe6K0EQC zF3t5efF2FuQUAXcBd8A/yNf1tjvOZZRkFoTpfrYbxTXWOziDGzJPOAnsb+GAMYcrAES BwKuLwzZrZv4jZh7U9PsDf4cJIzD6vEwxiwzZVXFvHzCHEdGySX82ux/GHfg6YAkaAfF PCTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gSnXwIFnTv6UYY3D3EYXQiuIw8trSygVlcI8ZjxvfG4=; b=c8g+pgLMqpIpHxL4qvd8Peao5+Wu7VRI5E2XLbAY/mMrsjNOl217HOYT2wkXHpNuen lBrCVWebNJlUMTHywJKwdqimkUU51bG8G1oKV5iVwM426s+u4tsVE3NOkP7ta6L7RD47 G9kNMqoQ4TNoo4xMk1YJpMa9bd55Nxf25rMa4XeOVu8PTEYhBzzeTpiSFNtbyyXv27dT bPlLQY+XhzNjMI1XlGug5qwuojgZwStYWoa5u/agmoOtib0Zw1PD8C+oK8jNhuumCfGT aK/kSXDcXpQJCUqeUERdq6FqIRBUhMewKnbg7eUSH7rgxL69ZQ1bNFwyGlJNrOonoFiH oA9A== X-Gm-Message-State: APjAAAVjRktv0Bv3KnVIOhpnid1oJjZHIvYdg6JXtf91KIxwFprS24jI DqIpZp6HjoubGIZd0c62juPXm7P3Cw4= X-Google-Smtp-Source: APXvYqyf08THqiipId51Yj0aubmDvpnCR5HoNtyYB8eSh9587yrlVeJMvT5tbl9ZBX6RYAvpwYuMDw== X-Received: by 2002:aa7:8b0b:: with SMTP id f11mr4835104pfd.142.1559157308450; Wed, 29 May 2019 12:15:08 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t18sm142943pgm.69.2019.05.29.12.15.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 May 2019 12:15:07 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Wed, 29 May 2019 12:14:54 -0700 Message-Id: <20190529191501.19053-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190529191501.19053-1-stephen@networkplumber.org> References: <20190529191501.19053-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 05/12] net/bonding: remove unnecessary cast X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_pmd.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 7087bc01b139..cea289c246d1 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -160,8 +160,7 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev, uint16_t slave_port) { struct rte_eth_dev_info slave_info; struct rte_flow_error error; - struct bond_dev_private *internals = (struct bond_dev_private *) - (bond_dev->data->dev_private); + struct bond_dev_private *internals = bond_dev->data->dev_private; const struct rte_flow_action_queue lacp_queue_conf = { .index = 0, @@ -201,8 +200,7 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev, int bond_8023ad_slow_pkt_hw_filter_supported(uint16_t port_id) { struct rte_eth_dev *bond_dev = &rte_eth_devices[port_id]; - struct bond_dev_private *internals = (struct bond_dev_private *) - (bond_dev->data->dev_private); + struct bond_dev_private *internals = bond_dev->data->dev_private; struct rte_eth_dev_info bond_info; uint16_t idx; @@ -227,9 +225,7 @@ int bond_ethdev_8023ad_flow_set(struct rte_eth_dev *bond_dev, uint16_t slave_port) { struct rte_flow_error error; - struct bond_dev_private *internals = (struct bond_dev_private *) - (bond_dev->data->dev_private); - + struct bond_dev_private *internals = bond_dev->data->dev_private; struct rte_flow_action_queue lacp_queue_conf = { .index = internals->mode4.dedicated_queues.rx_qid, }; @@ -1735,8 +1731,7 @@ slave_configure_slow_queue(struct rte_eth_dev *bonded_eth_dev, struct rte_eth_dev *slave_eth_dev) { int errval = 0; - struct bond_dev_private *internals = (struct bond_dev_private *) - bonded_eth_dev->data->dev_private; + struct bond_dev_private *internals = bonded_eth_dev->data->dev_private; struct port *port = &bond_mode_8023ad_ports[slave_eth_dev->data->port_id]; if (port->slow_pool == NULL) { @@ -1802,8 +1797,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, uint16_t q_id; struct rte_flow_error flow_error; - struct bond_dev_private *internals = (struct bond_dev_private *) - bonded_eth_dev->data->dev_private; + struct bond_dev_private *internals = bonded_eth_dev->data->dev_private; /* Stop slave */ rte_eth_dev_stop(slave_eth_dev->data->port_id); @@ -2421,8 +2415,8 @@ bond_ethdev_slave_link_status_change_monitor(void *cb_arg) if (cb_arg == NULL) return; - bonded_ethdev = (struct rte_eth_dev *)cb_arg; - internals = (struct bond_dev_private *)bonded_ethdev->data->dev_private; + bonded_ethdev = cb_arg; + internals = bonded_ethdev->data->dev_private; if (!bonded_ethdev->data->dev_started || !internals->link_status_polling_enabled) -- 2.20.1