From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id AD87BA045E
for <public@inbox.dpdk.org>; Thu, 30 May 2019 19:49:34 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 509281B994;
Thu, 30 May 2019 19:48:46 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 0D25B1B948
for <dev@dpdk.org>; Thu, 30 May 2019 19:48:29 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
30 May 2019 10:48:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,532,1549958400"; d="scan'208";a="180020100"
Received: from bwalker-desk.ch.intel.com ([143.182.136.145])
by fmsmga002.fm.intel.com with ESMTP; 30 May 2019 10:48:27 -0700
From: Ben Walker <benjamin.walker@intel.com>
To: dev@dpdk.org
Cc: Ben Walker <benjamin.walker@intel.com>
Date: Thu, 30 May 2019 10:48:14 -0700
Message-Id: <20190530174819.1160221-8-benjamin.walker@intel.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20190530174819.1160221-1-benjamin.walker@intel.com>
References: <20190530174819.1160221-1-benjamin.walker@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH 07/12] eal/pci: Reverse if check in
rte_pci_get_iommu_class
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
It's simpler to reverse the if statement here, especially
with an upcoming simplification.
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Change-Id: I6cff80231032304f3f865fdf38157554fad7fd07
---
drivers/bus/pci/linux/pci.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index ebe62f140..f678d2318 100644
--- a/drivers/bus/pci/linux/pci.c
+++ b/drivers/bus/pci/linux/pci.c
@@ -601,10 +601,8 @@ rte_pci_get_iommu_class(void)
if (pci_ignore_device(dev))
continue;
- if (dev->kdrv == RTE_KDRV_UNKNOWN ||
- dev->kdrv == RTE_KDRV_NONE) {
- continue;
- } else {
+ if (dev->kdrv != RTE_KDRV_UNKNOWN &&
+ dev->kdrv != RTE_KDRV_NONE) {
is_bound = true;
break;
}
--
2.20.1