From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 346D5A045E for ; Fri, 31 May 2019 17:16:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C12B1B952; Fri, 31 May 2019 17:16:29 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 929BB1B94B for ; Fri, 31 May 2019 17:16:27 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 May 2019 08:16:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,535,1549958400"; d="scan'208";a="180358348" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga002.fm.intel.com with ESMTP; 31 May 2019 08:16:25 -0700 Date: Fri, 31 May 2019 23:07:52 +0800 From: Ye Xiaolong To: Allain Legacy Cc: thomas@monjalon.net, dev@dpdk.org, ferruh.yigit@intel.com, Matt Peters Message-ID: <20190531150752.GA47868@intel.com> References: <20190527170255.30853-1-allain.legacy@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190527170255.30853-1-allain.legacy@windriver.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/avp: remove resources when port is closed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/27, Allain Legacy wrote: >The rte_eth_dev_close() function now handles freeing resources for >devices (e.g., mac_addrs). To conform with the new close() behaviour we >are asserting the RTE_ETH_DEV_CLOSE_REMOVE flag so that >rte_eth_dev_close() releases all device level dynamic memory. > >Second level memory allocated to each individual rx/tx queue is now >freed as part of the close() operation therefore making it safe for the >rte_eth_dev_close() function to free the device private data without >orphaning the rx/tx queue pointers. > >Cc: Matt Peters >Signed-off-by: Allain Legacy Reviewed-by: Xiaolong Ye