From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D9799A0096 for ; Tue, 4 Jun 2019 17:50:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A61861BC6E; Tue, 4 Jun 2019 17:50:42 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 92C181BC22 for ; Tue, 4 Jun 2019 17:50:41 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id x7so7521399plr.12 for ; Tue, 04 Jun 2019 08:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Rc8zpwoqmbHW2TbBcZ8pFq4/M+9L4Du5NG74gobmsa4=; b=glMYlOKY1UnV5Yr72TRJq2QK9I7Wah7NWZh+uowaOHSnvRmdvGBVj+6DaB06nzccGZ eg1SC0hS7+CfTUqJ+86+AlDWWwMeycyHmFyJzk8hVh97PilAN2aZHgfzZoccMmC0daOY hXO4G4OVI3JN50UvjCzcgQSdVoHTl4r/YWIdwD7Ggy1cIafFNvvTx5Lz/k5Q6PG0JB8j JBdpGVaN1d4OAzJi7m+mGp/Br3xDShBu3korBy1xEuakKhBx/ZjnW1mIXLUKZgVdhp4Z KjMAXcPAj/Msq3HHiAG//Gc+/mYruSBVtLyBNkUW41zPWVqs51Wj05kXmlwMXaub9PIY vylg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Rc8zpwoqmbHW2TbBcZ8pFq4/M+9L4Du5NG74gobmsa4=; b=F19xY5iXK1Zgmi/IiDzGRrs71dY8eYuWCji4/X21DQcWHselOerNKc32bJiEfCoMHl zdYOFx4suhEhe5nmS678uM+VAnd8T8jZOZ+2kx2jDmtQicKRzNRiHN4VpYRacGniq5ln 1bivkCDBvF6djPhzx192nA/5jp4E4ehyoj5HU833nlOB+gmHpHkK6wx6ELbnmHUSgNbC bhgW6sPBT4qhtH3xB3ETkHWBiVWSBLTtcLeuY6ZJ1OtrmMTgSlH5a4nfJfeiOqe+UCKw TGAYc7KE5dqMpBFGd5+OgqmdQJ5DmknGdYOZajmGLQrwFc10JbaZsY+qLDLn6CTfFnkV /9Ig== X-Gm-Message-State: APjAAAXtAw95GeryZC8+W2b7N2tBGyuTr4L68qTSFF1eYSREqeovNpdj gW7mi+K8tyn12bKAICAeOWdmKSLP5KM= X-Google-Smtp-Source: APXvYqwwKvsZJiyR2OVzPPIQMarn4wvlsCNdfAGuUeyFpqaa2qv15qNGQ+McUK9gHEcR3yfPZXLf1g== X-Received: by 2002:a17:902:9a90:: with SMTP id w16mr36711632plp.113.1559663440663; Tue, 04 Jun 2019 08:50:40 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z125sm22228000pfb.75.2019.06.04.08.50.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Jun 2019 08:50:40 -0700 (PDT) Date: Tue, 4 Jun 2019 08:50:38 -0700 From: Stephen Hemminger To: Loc Nguyen Cc: thomas@monjalon.net, dev@dpdk.org Message-ID: <20190604085038.6e5a0ab4@hermes.lan> In-Reply-To: <20190603125736.48511-1-locnguyen@niometrics.com> References: <20190603125736.48511-1-locnguyen@niometrics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] usertools: add device index for dpdk-devbind script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 3 Jun 2019 20:57:36 +0800 Loc Nguyen wrote: > Add a device index in front of the PCI ID for easy counting > > Network devices using DPDK-compatible driver > ============================================ > 0: 0000:07:00.0 ... > 1: 0000:07:00.1 ... > > Signed-off-by: Loc Nguyen > --- > usertools/dpdk-devbind.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py > index 9e79f0d28..21da3deca 100755 > --- a/usertools/dpdk-devbind.py > +++ b/usertools/dpdk-devbind.py > @@ -534,7 +534,9 @@ def display_devices(title, dev_list, extra_params=None): > strings.append("%s '%s'" % (dev["Slot"], dev["Device_str"])) > # sort before printing, so that the entries appear in PCI order > strings.sort() > - print("\n".join(strings)) # print one per line > + # add device index in front of each device > + enum_dev_list = ['%2d' % index + ": " + device for index, device in enumerate(strings)] > + print("\n".join(enum_dev_list)) # print one per line > > def show_device_status(devices_type, device_name): > global dpdk_drivers This is a bad idea. it is making assumption about how ports are ordered which can change if their are other busses, whitelist/blackst or the device may be owned. Longer term, I want DPDK to get away from using and exposing portid's as the preferred API to applications.